Displaying 13 results from an estimated 13 matches for "call_netdevice_notifiers_info".
2019 Mar 29
0
[PATCH net v4] failover: allow name change on IFF_UP slave interfaces
...piler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/core/dev.c: In function 'dev_change_name':
>> net/core/dev.c:1252:48: error: passing argument 2 of 'call_netdevice_notifiers_info' from incompatible pointer type [-Werror=incompatible-pointer-types]
call_netdevice_notifiers_info(NETDEV_CHANGE, dev,
^~~
net/core/dev.c:164:12: note: expected 'struct netdev_notifier_info *' but argument is of type 'struc...
2019 Apr 05
2
[PATCH net v6] failover: allow name change on IFF_UP slave interfaces
On Wed, 3 Apr 2019 00:52:47 -0400
Si-Wei Liu <si-wei.liu at oracle.com> wrote:
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
This notifier is not really necessary, there already is a CHANGENAME
that gets sent.
NETDEV_CHANGE is used in other cases to mean that the state (flags)
have changed.
2019 Apr 05
2
[PATCH net v6] failover: allow name change on IFF_UP slave interfaces
On Wed, 3 Apr 2019 00:52:47 -0400
Si-Wei Liu <si-wei.liu at oracle.com> wrote:
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
This notifier is not really necessary, there already is a CHANGENAME
that gets sent.
NETDEV_CHANGE is used in other cases to mean that the state (flags)
have changed.
2016 Jul 06
3
[PATCH net-next V4 0/6] switch to use tx skb array in tun
...notifier_call_chain+0x5d/0x80
[ 72.487844] [<ffffffff816365c0>] ? show_tx_maxrate+0x30/0x30
[ 72.493520] [<ffffffff810eeb3e>] __raw_notifier_call_chain+0xe/0x10
[ 72.499801] [<ffffffff810eeb56>] raw_notifier_call_chain+0x16/0x20
[ 72.506001] [<ffffffff8160eb30>] call_netdevice_notifiers_info+0x40/0x70
[ 72.512706] [<ffffffff8160ec36>] call_netdevice_notifiers+0x16/0x20
[ 72.518986] [<ffffffff816365f8>] change_tx_queue_len+0x38/0x80
[ 72.524838] [<ffffffff816381cf>] netdev_store.isra.5+0xbf/0xd0
[ 72.530688] [<ffffffff81638330>] tx_queue_len_store+0x5...
2016 Jul 06
3
[PATCH net-next V4 0/6] switch to use tx skb array in tun
...notifier_call_chain+0x5d/0x80
[ 72.487844] [<ffffffff816365c0>] ? show_tx_maxrate+0x30/0x30
[ 72.493520] [<ffffffff810eeb3e>] __raw_notifier_call_chain+0xe/0x10
[ 72.499801] [<ffffffff810eeb56>] raw_notifier_call_chain+0x16/0x20
[ 72.506001] [<ffffffff8160eb30>] call_netdevice_notifiers_info+0x40/0x70
[ 72.512706] [<ffffffff8160ec36>] call_netdevice_notifiers+0x16/0x20
[ 72.518986] [<ffffffff816365f8>] change_tx_queue_len+0x38/0x80
[ 72.524838] [<ffffffff816381cf>] netdev_store.isra.5+0xbf/0xd0
[ 72.530688] [<ffffffff81638330>] tx_queue_len_store+0x5...
2019 Apr 05
0
[PATCH net v6] failover: allow name change on IFF_UP slave interfaces
...n Wed, 3 Apr 2019 00:52:47 -0400
> Si-Wei Liu <si-wei.liu at oracle.com> wrote:
>
> >
> > + if (unlikely(dev->flags & IFF_UP)) {
> > + struct netdev_notifier_change_info change_info = {
> > + .info.dev = dev,
> > + };
> > +
> > + call_netdevice_notifiers_info(NETDEV_CHANGE,
> > + &change_info.info);
> > + }
>
> This notifier is not really necessary, there already is a CHANGENAME
> that gets sent.
> NETDEV_CHANGE is used in other cases to mean that the state (flags)
> have changed.
The point is some existing scr...
2016 Jul 08
0
[PATCH net-next V4 0/6] switch to use tx skb array in tun
...+0x5d/0x80
> [ 72.487844] [<ffffffff816365c0>] ? show_tx_maxrate+0x30/0x30
> [ 72.493520] [<ffffffff810eeb3e>] __raw_notifier_call_chain+0xe/0x10
> [ 72.499801] [<ffffffff810eeb56>] raw_notifier_call_chain+0x16/0x20
> [ 72.506001] [<ffffffff8160eb30>] call_netdevice_notifiers_info+0x40/0x70
> [ 72.512706] [<ffffffff8160ec36>] call_netdevice_notifiers+0x16/0x20
> [ 72.518986] [<ffffffff816365f8>] change_tx_queue_len+0x38/0x80
> [ 72.524838] [<ffffffff816381cf>] netdev_store.isra.5+0xbf/0xd0
> [ 72.530688] [<ffffffff81638330>] tx...
2019 Apr 02
0
[PATCH net v5] failover: allow name change on IFF_UP slave interfaces
...t; hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name));
> write_unlock_bh(&dev_base_lock);
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
> +
> ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev);
> ret = notifier_to_errno(ret);
>
>
2019 Apr 02
0
[PATCH net v5] failover: allow name change on IFF_UP slave interfaces
...> hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name));
> write_unlock_bh(&dev_base_lock);
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
> +
> ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev);
> ret = notifier_to_errno(ret);
>
> --
> 1.8.3.1
2019 Mar 29
0
[PATCH net v4] failover: allow name change on IFF_UP slave interfaces
...gt; hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name));
> write_unlock_bh(&dev_base_lock);
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info;
> +
> + change_info.flags_changed = 0;
> + call_netdevice_notifiers_info(NETDEV_CHANGE, dev,
> + &change_info.info);
This function no longer takes the dev parameter in the net-next kernel.
Did you consider calling netdev_state_change() although it does send a
RTM_NEWLINK message too. May be just fixing the notifier call should be
fine.
> + }
>...
2019 Mar 29
0
[PATCH net v4] failover: allow name change on IFF_UP slave interfaces
...name));
> > > write_unlock_bh(&dev_base_lock);
> > > + if (unlikely(dev->flags & IFF_UP)) {
> > > + struct netdev_notifier_change_info change_info;
> > > +
> > > + change_info.flags_changed = 0;
> > > + call_netdevice_notifiers_info(NETDEV_CHANGE, dev,
> > > + &change_info.info);
> >
> > This function no longer takes the dev parameter in the net-next kernel.
> OK. Will get my patch updated with the latest net-next tree.
>
> >
> > Did you consider calling ne...
2019 Apr 05
2
[PATCH net v6] failover: allow name change on IFF_UP slave interfaces
...> hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name));
> write_unlock_bh(&dev_base_lock);
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
> +
> ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev);
> ret = notifier_to_errno(ret);
>
> diff --git a/net/core/failover.c b/net/core/failover.c
> index 4a92a98..b5cd3c7 100644
> --- a/net/core/failo...
2019 Apr 05
2
[PATCH net v6] failover: allow name change on IFF_UP slave interfaces
...> hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name));
> write_unlock_bh(&dev_base_lock);
>
> + if (unlikely(dev->flags & IFF_UP)) {
> + struct netdev_notifier_change_info change_info = {
> + .info.dev = dev,
> + };
> +
> + call_netdevice_notifiers_info(NETDEV_CHANGE,
> + &change_info.info);
> + }
> +
> ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev);
> ret = notifier_to_errno(ret);
>
> diff --git a/net/core/failover.c b/net/core/failover.c
> index 4a92a98..b5cd3c7 100644
> --- a/net/core/failo...