search for: call_blockdev

...daemon/blockdev.c | 30 ++++++++++++++++++++---------- generator/actions.ml | 14 ++++++++++++++ 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a/daemon/blockdev.c b/daemon/blockdev.c index 8a7b1a8..6e8821d 100644 --- a/daemon/blockdev.c +++ b/daemon/blockdev.c @@ -62,7 +62,7 @@ call_blockdev (const char *device, const char *switc, int extraarg, int prints) */ udev_settle (); - if (extraarg > 0) { + if (extraarg >= 0) { snprintf (buf, sizeof buf, "%d", extraarg); argv[2] = buf; argv[3] = device; @@ -89,33 +89,43 @@ call_blockdev (const char *dev...

See http://rwmj.wordpress.com/2014/11/23/mapping-files-to-disk/

Does *not* incorporate changes suggested by Pino yet. Rich.

The warnings in daemon were aggravating and risky for development (too easy to miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

From: "Richard W.M. Jones" <rjones at redhat.com> This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11. --- daemon/file.c | 18 +++--------------- daemon/parted.c | 3 +-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index 057e15d..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -525,7 +525,7 @@

I ran the Coverity static analyzer[1] on libguestfs, and fixed many errors as a result. Coverity found some errors in gnulib, but it doesn't seem to be worth following those up since the version of gnulib we are using is so old. There are a couple more errors (possibly 1 false-positive) which I'm going to send in a separate email. BTW all the errors found by Coverity were in the daemon

...4 --- a/daemon/blockdev.c +++ b/daemon/blockdev.c @@ -28,6 +28,8 @@ #include "daemon.h" #include "actions.h" +GUESTFSD_EXT_CMD(str_blockdev, blockdev); + /* These functions are all about using the blockdev command, so * we centralize it in one call. */ @@ -38,7 +40,7 @@ call_blockdev (const char *device, const char *switc, int extraarg, int prints) int64_t rv; char *out, *err; const char *argv[] = { - "blockdev", + str_blockdev, switc, NULL, NULL, diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 411fdea..8ecde01 100644 --- a/daemon/btrf...

...44 --- a/daemon/blockdev.c +++ b/daemon/blockdev.c @@ -28,6 +28,8 @@ #include "daemon.h" #include "actions.h" +GUESTFS_EXT_CMD(str_blockdev, blockdev); + /* These functions are all about using the blockdev command, so * we centralize it in one call. */ @@ -38,7 +40,7 @@ call_blockdev (const char *device, const char *switc, int extraarg, int prints) int64_t rv; char *out, *err; const char *argv[] = { - "blockdev", + str_blockdev, switc, NULL, NULL, diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 411fdea..b055267 100644 --- a/daemon/btrf...

...4 --- a/daemon/blockdev.c +++ b/daemon/blockdev.c @@ -28,8 +28,6 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_blockdev, blockdev); - /* These functions are all about using the blockdev command, so * we centralize it in one call. */ @@ -40,7 +38,7 @@ call_blockdev (const char *device, const char *switc, int extraarg, int prints) int64_t rv; CLEANUP_FREE char *out = NULL, *err = NULL; const char *argv[] = { - str_blockdev, + "blockdev", switc, NULL, NULL, diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 5f1e5d1d0..8fd...

...ev.c @@ -28,7 +28,7 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_blockdev, blockdev); +DECLARE_EXTERNAL_COMMANDS ("blockdev") /* These functions are all about using the blockdev command, so * we centralize it in one call. @@ -40,7 +40,7 @@ call_blockdev (const char *device, const char *switc, int extraarg, int prints) int64_t rv; CLEANUP_FREE char *out = NULL, *err = NULL; const char *argv[] = { - str_blockdev, + "blockdev", switc, NULL, NULL, diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 5f1e5d1d0..c7f...

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’