search for: calculatecallsinform

...amsung.com> wrote: > On 23/11/15 16:46, Jay Foad wrote: >> >> In LowerGET_DYNAMIC_AREA_OFFSET() you're calling >> MFI->getMaxCallFrameSize(), but it looks like that doesn't return useful >> information until after the PrologEpilogInserter's >> PEI::calculateCallsInformation() has run. >> >> So maybe the lowering has to be done as part of frame index elimination? >> (I'm not too familiar with this code.) > > > Yeah, this sounds like a good idea. I'm attaching another draft patch that > tries to lower getDynamicAreaOffset durin...

In LowerGET_DYNAMIC_AREA_OFFSET() you're calling MFI->getMaxCallFrameSize(), but it looks like that doesn't return useful information until after the PrologEpilogInserter's PEI::calculateCallsInformation() has run. So maybe the lowering has to be done as part of frame index elimination? (I'm not too familiar with this code.) Jay. On 23 November 2015 at 13:07, Jay Foad <jay.foad at gmail.com> wrote: > Maxim, > > It seems to be doing roughly the right thing, but it isn'...

The code has changed a lot over the years. Looks like at some point of time the assumption was broken. calculateCallsInformation() may have eliminated the pseudo set up instructions already. // If call frames are not being included as part of the stack frame, and...

...tual registers in frame setup, but I'm not sure how popular that would be. So far I have only seen that in the Thumb backend. -Krzysztof On 9/26/2013 3:30 PM, Evan Cheng wrote: > The code has changed a lot over the years. Looks like at some point of > time the assumption was broken. calculateCallsInformation() may have > eliminated the pseudo set up instructions already. > > // If call frames are not being included as part of the stack frame, and > // the target doesn't indicate otherwise, remove the call frame pseudos > // here. The sub/add sp instruction pairs are still insert...

Jay, do you have a PowerPC64 target? If so, could you please check attached patch on PPC box? This is a draft patch, but it would be nice to make sure that we are moving to right direction here. Thanks, -Maxim On 18/11/15 00:12, Jay Foad wrote: >>> Currently test/asan/TestCases/alloca_vla_interact.cc is XFAILed for >>> powerpc64. I've had a look at why it

...(which requires a bytes of stack space) in the call graph, we only need to allocate (a + MAX(f, g, h)) bytes of stack space in A's prologue and then eliminate the check in F, G and H. This can implemented by dividing the PEI pass into an analyze and an action pass. The analyze pass just calls calculateCallsInformation for each MachineFunction. After this, if we are compiling with split-stacks (i.e. the target supports it, and it is enabled), we run a CallGraphSCCPass (InferGlobalStackSpace, say) which implements the algorithm mentioned in the paper. The actual insertion of the prologue and epilogue code is...

Consider this example: --- ex.ll --- declare void @bar() ; Function Attrs: nounwind optsize define void @main() { entry: %hin = alloca [256 x i32], align 4 %xin = alloca [256 x i32], align 4 call void @bar() ret void } ------------- Freshly built llc: llc -O2 -march=x86 < ex.ll -print-before-all # *** IR Dump Before Prologue/Epilogue Insertion & Frame Finalization ***: #