search for: cached_feature

...3 100644 --- a/src/available.c +++ b/src/available.c @@ -18,17 +18,87 @@ #include <config.h> +#include <string.h> +#include <libintl.h> + #include "guestfs.h" +#include "guestfs-internal.h" #include "guestfs-internal-actions.h" +static struct cached_feature * +find_or_cache_feature (guestfs_h *g, const char *group) +{ + struct cached_feature *f; + size_t i; + int res; + + for (i = 0; i < g->nr_features; ++i) { + f = &g->features[i]; + + if (STRNEQ (f->group, group)) + continue; + + return f; + } + + res = guestfs_in...

Rename the current available and feature_available into internal daemon functions, and provide non-daemon functions wrapping them at library side. This will make it possible to e.g. add caching for them. Should be only refactoring, no actual behaviour change. --- daemon/available.c | 4 +- generator/actions.ml | 192 ++++++++++++++++++++++++++++----------------------- po/POTFILES |

...+++++++++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+) diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h index adeb9478a..c66c55e70 100644 --- a/lib/guestfs-internal.h +++ b/lib/guestfs-internal.h @@ -510,6 +510,9 @@ struct guestfs_h { /* Cached features. */ struct cached_feature *features; size_t nr_features; + + /* Used by lib/info.c. -1 = not tested or error; else 0 or 1. */ + int qemu_img_supports_U_option; }; /** diff --git a/lib/handle.c b/lib/handle.c index a47aaafab..297ff6d67 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -101,6 +101,8 @@ guestfs_create_...

...files changed, 44 insertions(+) > > diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h > index adeb9478a..c66c55e70 100644 > --- a/lib/guestfs-internal.h > +++ b/lib/guestfs-internal.h > @@ -510,6 +510,9 @@ struct guestfs_h { > /* Cached features. */ > struct cached_feature *features; > size_t nr_features; > + > + /* Used by lib/info.c. -1 = not tested or error; else 0 or 1. */ > + int qemu_img_supports_U_option; > }; > > /** > diff --git a/lib/handle.c b/lib/handle.c > index a47aaafab..297ff6d67 100644 > --- a/lib/handle.c > +...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.