search for: ca2a0bb

...t; Or is there a case when it might be useful to get the result? > >Yes I don't know what I was thinking there. It's difficult to revisit >and revise patches months later. It would be better as simply: > >diff --git a/options/decrypt.c b/options/decrypt.c >index 8eb24bc..ca2a0bb 100644 >--- a/options/decrypt.c >+++ b/options/decrypt.c >@@ -25,6 +25,7 @@ > > #include <stdio.h> > #include <stdlib.h> >+#include <stdbool.h> > #include <string.h> > #include <libintl.h> > #include <error.h> >@@ -82,11 +83,19 @@...

On Mon, Sep 07, 2020 at 10:41:20AM +0100, Richard W.M. Jones wrote: >For BitLocker disks cryptsetup does not (yet? ever?) support reading >UUIDs and this function will fail. This does not matter here so just >ignore the error. > >Note there is no error message, cryptsetup simply returns with a bad >exit code: > >><rescue> cryptsetup luksUUID /dev/sda2

...ou know it will fail. > Or is there a case when it might be useful to get the result? Yes I don't know what I was thinking there. It's difficult to revisit and revise patches months later. It would be better as simply: diff --git a/options/decrypt.c b/options/decrypt.c index 8eb24bc..ca2a0bb 100644 --- a/options/decrypt.c +++ b/options/decrypt.c @@ -25,6 +25,7 @@ #include <stdio.h> #include <stdlib.h> +#include <stdbool.h> #include <string.h> #include <libintl.h> #include <error.h> @@ -82,11 +83,19 @@ inspect_do_decrypt (guestfs_h *g, struct k...

...en it might be useful to get the result? >> >>Yes I don't know what I was thinking there. It's difficult to revisit >>and revise patches months later. It would be better as simply: >> >>diff --git a/options/decrypt.c b/options/decrypt.c >>index 8eb24bc..ca2a0bb 100644 >>--- a/options/decrypt.c >>+++ b/options/decrypt.c >>@@ -25,6 +25,7 @@ >> >> #include <stdio.h> >> #include <stdlib.h> >>+#include <stdbool.h> >> #include <string.h> >> #include <libintl.h> >> #include...