search for: c_isprint

...#802109: Because stderr is usually not buffered, avoid + * single 'putc' calls (which translate to a 1 byte write), and + * try to send longest possible strings in single fwrite calls + * (thanks to Jim Meyering for the basic approach). */ +#define NO_ESCAPING(c) \ + (c_isprint ((c)) || (from_appliance && ((c) == '\n' || (c) == '\r'))) + for (i = 0; i < buf_len; ++i) { - c = buf[i]; - if (c_isprint (c) || (from_appliance && (c == '\n' || c == '\r'))) - putc (c, stderr); - else { - switch...

..."c-ctype.h" #include "ignore-value.h" #include "daemon.h" @@ -96,7 +96,7 @@ main_loop (int _sock) printf (" "); printf ("|"); for (j = i; j < MIN (i+16, len); ++j) - if (isprint (buf[j])) + if (c_isprint (buf[j])) printf ("%c", buf[j]); else printf ("."); diff --git a/examples/Makefile.am b/examples/Makefile.am index fb3d656..adbb934 100644 --- a/examples/Makefile.am +++ b/examples/Makefile.am @@ -7,7 +7,9 @@ hello_CFLAGS = -I$(top_srcdir)/sr...

...s page may help with this: http://gcc.gnu.org/wiki/Visibility Symbols: asnprintf at Base 1.2.1 c_isalnum at Base 1.2.1 c_isalpha at Base 1.2.1 c_isascii at Base 1.2.1 c_isblank at Base 1.2.1 c_iscntrl at Base 1.2.1 c_isdigit at Base 1.2.1 c_isgraph at Base 1.2.1 c_islower at Base 1.2.1 c_isprint at Base 1.2.1 c_ispunct at Base 1.2.1 c_isspace at Base 1.2.1 c_isupper at Base 1.2.1 c_isxdigit at Base 1.2.1 c_tolower at Base 1.2.1 c_toupper at Base 1.2.1 exit_failure at Base 1.2.1 full_read at Base 1.2.1 full_write at Base 1.2.1 printf_fetchargs at Base 1.2.1 printf_parse at Base 1...

...pr " fprintf (dest, \"%%s\", linesep);\n" + | name, FBuffer -> + pr " fprintf (dest, \"%%s%s: \", indent);\n" name; + pr " for (i = 0; i < %s->%s_len; ++i)\n" typ name; + pr " if (c_isprint (%s->%s[i]))\n" typ name; + pr " fprintf (dest, \"%%c\", %s->%s[i]);\n" typ name; + pr " else\n"; + pr " fprintf (dest, \"\\\\x%%02x\", (unsigned) %s->%s[i]);\n" + typ...

...': *(n++) = '\\'; *n = ' '; break; + + default: + // Hexadecimal escape unprintable character. This violates identity + // after composition of bsquote_filename after debsquote_filename + // (i.e. can escape some characters differently). + if (!c_isprint(*p)) { + n += sprintf(n, "\\x%x", (int) (*p & 0xff)) - 1; + } else { + *n = *p; + } + break; + error: + fprintf (stderr, ("%s: invalid escape sequence in string (starting at offset %d)\n"), + program_name, (i...

From: Maros Zatko <hacxman@gmail.com> Auxiliary functions for readline to support space character escaping in filenames in future. Escaping function is taken from fish.c (used to be parse_quoted_string) plus its un-escaping counterpart. There are a few tests for both. Maros Zatko (3): fish: rl.{c,h} - escaping functions for readline fish: basic tests for readline escaping autotools:

From: Maros Zatko <mzatko@redhat.com> Helper functions for future support of backslash escaped spaces in filenames. There are a few tests too. Changed according to review remarks. Maros Zatko (3): fish: rl.{c, h} - escaping functions for readline fish: basic tests for readline escaping autotools: add fish/test Makefile.am | 1 + configure.ac | 1 +

Helper functions for future support of backslash escaped spaces in filenames. There are a few tests too. Changed according to review remarks and fixed few other mistakes. Maros Zatko (4): fish: copy parse_quoted_string and hexdigit from fish.h to rl.c fish: rl.{c,h} - escaping functions for readline fish: basic tests for readline escaping autotools: add fish/test Makefile.am

Some of the data in names and string values were being unsafely printed, causing some types of XML processors to fail (e.g. Python's Expat). This patch checks for printability of each character and outputs base64 with an encoding attribute for unsafe data. --- xml/hivexml.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 64 insertions(+), 11 deletions(-)

...yp typ; pr "{\n"; if needs_i then ( - pr " unsigned int i;\n"; + pr " size_t i;\n"; pr "\n" ); List.iter ( @@ -288,7 +288,8 @@ Guestfish will prompt for these separately." pr " if (c_isprint (%s->%s[i]))\n" typ name; pr " printf (\"%%c\", %s->%s[i]);\n" typ name; pr " else\n"; - pr " printf (\"\\\\x%%02x\", %s->%s[i]);\n" typ name; + pr " printf (\&quot...

...yp typ; pr "{\n"; if needs_i then ( - pr " unsigned int i;\n"; + pr " size_t i;\n"; pr "\n" ); List.iter ( @@ -288,7 +288,8 @@ Guestfish will prompt for these separately." pr " if (c_isprint (%s->%s[i]))\n" typ name; pr " printf (\"%%c\", %s->%s[i]);\n" typ name; pr " else\n"; - pr " printf (\"\\\\x%%02x\", %s->%s[i]);\n" typ name; + pr " printf (\&quot...

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

...size_t buf_len) { size_t i, count = 0; @@ -167,8 +167,8 @@ guestfs_int_call_callbacks_message (guestfs_h *g, uint64_t event, * try to send longest possible strings in single fwrite calls * (thanks to Jim Meyering for the basic approach). */ -#define NO_ESCAPING(c) \ - (c_isprint ((c)) || (from_appliance && ((c) == '\n' || (c) == '\r'))) +#define NO_ESCAPING(c) \ + (c_isprint ((c)) || (from_appliance && ((c) == '\n' || (c) == '\r'))) for (i = 0; i < buf_len; ++i) { if (NO_ESCAPING (buf[i])) { @@ -204,...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

...rintf"); - exit (EXIT_FAILURE); - } + if (printf ("-> %s", link) < 0) + error (EXIT_FAILURE, errno, "printf"); } } @@ -949,15 +924,11 @@ output_binary (const char *s, size_t len) print_no_quoting: for (i = 0; i < len; ++i) { if (c_isprint (s[i])) { - if (putchar (s[i]) == EOF) { - perror ("putchar"); - exit (EXIT_FAILURE); - } + if (putchar (s[i]) == EOF) + error (EXIT_FAILURE, errno, "putchar"); } else { - if (printf ("\\x%02x", (unsigned ch...

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.