search for: c49f7cb

...them? > > Wouldn't that be confusing? > > Maybe I could rename it to test-v2v-i-ova.ovf and > test-v2v-i-ova.expected and then use it in both tests. Good idea. > > > diff --git a/v2v/test-v2v-i-ova-subfolders.sh b/v2v/test-v2v-i-ova-subfolders.sh > > > index c49f7cb..89a9a3e 100755 > > > --- a/v2v/test-v2v-i-ova-subfolders.sh > > > +++ b/v2v/test-v2v-i-ova-subfolders.sh > > > @@ -35,6 +35,7 @@ fi > > > export VIRT_TOOLS_DATA_DIR="$srcdir/../test-data/fake-virt-tools" > > > > > > . $srcdir/../t...

...ile it really checks against a wanted version -- I'd suggest qemu_is_version, just like the simple tool we have for shell tests involving libvirt, libvirt-is-version (see src/libvirt-is-version.c). > diff --git a/v2v/test-v2v-i-ova-subfolders.sh b/v2v/test-v2v-i-ova-subfolders.sh > index c49f7cb..89a9a3e 100755 > --- a/v2v/test-v2v-i-ova-subfolders.sh > +++ b/v2v/test-v2v-i-ova-subfolders.sh > @@ -35,6 +35,7 @@ fi > export VIRT_TOOLS_DATA_DIR="$srcdir/../test-data/fake-virt-tools" > > . $srcdir/../test-data/guestfs-hashsums.sh > +. $srcdir/../test-data/ut...

...ted version -- I'd suggest qemu_is_version, just > like the simple tool we have for shell tests involving libvirt, > libvirt-is-version (see src/libvirt-is-version.c). Good point. > > diff --git a/v2v/test-v2v-i-ova-subfolders.sh b/v2v/test-v2v-i-ova-subfolders.sh > > index c49f7cb..89a9a3e 100755 > > --- a/v2v/test-v2v-i-ova-subfolders.sh > > +++ b/v2v/test-v2v-i-ova-subfolders.sh > > @@ -35,6 +35,7 @@ fi > > export VIRT_TOOLS_DATA_DIR="$srcdir/../test-data/fake-virt-tools" > > > > . $srcdir/../test-data/guestfs-hashsums.sh &...

...using? > > > > Maybe I could rename it to test-v2v-i-ova.ovf and > > test-v2v-i-ova.expected and then use it in both tests. > > Good idea. > > > > > diff --git a/v2v/test-v2v-i-ova-subfolders.sh b/v2v/test-v2v-i-ova-subfolders.sh > > > > index c49f7cb..89a9a3e 100755 > > > > --- a/v2v/test-v2v-i-ova-subfolders.sh > > > > +++ b/v2v/test-v2v-i-ova-subfolders.sh > > > > @@ -35,6 +35,7 @@ fi > > > > export VIRT_TOOLS_DATA_DIR="$srcdir/../test-data/fake-virt-tools" > > > > >...

This series fixes and enhances parsing of the OVA manifest file. The changes are: - Added mandatory space to the regexp - Process all lines in the file, not just one - Warn on improperly formated lines - Support SHA256 hashes v4 -> v5: - fix tests - change one test to include the SHA256 checksum Tomáš Golembiovský (2): v2v: ova: fix checking of the manifest file v2v: ova: support SHA256

...240", "file": { "filename":"test-v2v-i-ova-subfolders.d/test.ova" } } } (vmdk) [scsi] +removable media: + CD-ROM [ide] in slot 0 +NICs: + Network "Network adapter 1" + diff --git a/v2v/test-v2v-i-ova-subfolders.sh b/v2v/test-v2v-i-ova-subfolders.sh index c49f7cb..89a9a3e 100755 --- a/v2v/test-v2v-i-ova-subfolders.sh +++ b/v2v/test-v2v-i-ova-subfolders.sh @@ -35,6 +35,7 @@ fi export VIRT_TOOLS_DATA_DIR="$srcdir/../test-data/fake-virt-tools" . $srcdir/../test-data/guestfs-hashsums.sh +. $srcdir/../test-data/utils.sh d=test-v2v-i-ova-subfolde...

This series is related to the problem of inefficient import of OVA files. The needed enhancements of QEMU were merged into the codebase and should be available in QEMU 2.8. From there we can use 'size' and 'offset' options in raw driver to tell QEMU to use only subset of a file as an image. The patch set is more or less complete. The only outstanding issue is the missing detection

v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards suggestion - 4/6: added tests for nsplit v3: Addressed Pino's comments, namely: - input_ova.ml - untar takes list of paths - renamed untar_partial to untar_metadata - replaced uggly regex with nsplit - tests - test changes

v3: Addressed Pino's comments, namely: - input_ova.ml - untar takes list of paths - renamed untar_partial to untar_metadata - replaced uggly regex with nsplit - tests - test changes are part of the main commit - renamed test-data/guestfs-hashsums.sh to test-data/test-utils.sh - renamed qemu_version to qemu_is_version and moved it to test-data/test-utils.sh - normalize paths