search for: c328319

...d to get the label of a filesystem, so this special case for btrfs should be added there (just like the ones done in set_label). Isn't blkid working on btrfs filesystems? From what I see, there is support for it already. > diff --git a/generator/actions.ml b/generator/actions.ml > index c328319..5223eb8 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12281,6 +12281,21 @@ corrupt data." }; > longdesc = "\ > Check or repair a btrfs filesystem offline." }; > > + { defaults with > + name = "btrfs_filesystem_get_lab...

In data martedì 6 gennaio 2015 09:30:19, Hu Tao ha scritto: > > > diff --git a/generator/actions.ml b/generator/actions.ml > > > index c328319..5223eb8 100644 > > > --- a/generator/actions.ml > > > +++ b/generator/actions.ml > > > @@ -12281,6 +12281,21 @@ corrupt data." }; > > > longdesc = "\ > > > Check or repair a btrfs filesystem offline." }; > > > > > &...

...> +} We do have already a "fsck" action; OTOH fsck.btrfs does nothing, so I would rather call `btrfs check` there, instead of adding a new btrfs-specific API. Let's make our fsck useful on btrfs :) > diff --git a/generator/actions.ml b/generator/actions.ml > index b44ce1c..c328319 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums > and the duplicate copies from RAID storage to identify and repair any > corrupt data." }; > > + { defaul...

Hi, There is one problem: btrfs_filesystem_set_label just doesnt work, giving error message: libguestfs: error: btrfs_filesystem_set_label: /: ERROR: unable to set label Bad address I'm almost sure the patch has no problem, but can't figure out what's the cause. So patch 5 is only for review. Other APIs have no problem. Regards, Hu Hu Tao (5): New API: btrfs_scrub New API:

...;label"); + ADD_ARG (argv, i, path_buf); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return NULL; + } + + return out; +} diff --git a/generator/actions.ml b/generator/actions.ml index c328319..5223eb8 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12281,6 +12281,21 @@ corrupt data." }; longdesc = "\ Check or repair a btrfs filesystem offline." }; + { defaults with + name = "btrfs_filesystem_get_label"; + style = RString "lab...

...l). > > Isn't blkid working on btrfs filesystems? From what I see, there is > support for it already. Yes, blkid just works. I think this patch can be dropped. Thanks for reminding! Regards, Hu > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index c328319..5223eb8 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12281,6 +12281,21 @@ corrupt data." }; > > longdesc = "\ > > Check or repair a btrfs filesystem offline." }; > > > > + { defaults with > > +...

...k"); + ADD_ARG (argv, i, device); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", device, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index b44ce1c..c328319 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums and the duplicate copies from RAID storage to identify and repair any corrupt data." }; + { defaults with + name = "btrfs_che...

...dding a new > btrfs-specific API. > Let's make our fsck useful on btrfs :) I found btrfs_fsck has been already implemented. Do you mean we should extend btrfs to support btrfs? Regards, Hu > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index b44ce1c..c328319 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums > > and the duplicate copies from RAID storage to identify and repair any > > corrupt data." }...