search for: c169c6444637

...n 29/01/16 02:31, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski <luto at kernel.org> > --- > drivers/virtio/virtio_ring.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index c169c6444637..305c05cc249a 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -47,6 +47,18 @@ > > static bool vring_use_dma_api(void) > { > +#if defined(CONFIG_X86) && defined(CONFIG_XEN) > + /* > + * In theory, it's possible to have...

...n 29/01/16 02:31, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski <luto at kernel.org> > --- > drivers/virtio/virtio_ring.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index c169c6444637..305c05cc249a 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -47,6 +47,18 @@ > > static bool vring_use_dma_api(void) > { > +#if defined(CONFIG_X86) && defined(CONFIG_XEN) > + /* > + * In theory, it's possible to have...

...off-by: Andy Lutomirski <luto at kernel.org> >> > --- >> > drivers/virtio/virtio_ring.c | 12 ++++++++++++ >> > 1 file changed, 12 insertions(+) >> > >> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >> > index c169c6444637..305c05cc249a 100644 >> > --- a/drivers/virtio/virtio_ring.c >> > +++ b/drivers/virtio/virtio_ring.c >> > @@ -47,6 +47,18 @@ >> > >> > static bool vring_use_dma_api(void) >> > { >> > +#if defined(CONFIG_X86) && defined(CONFIG_...

...off-by: Andy Lutomirski <luto at kernel.org> >> > --- >> > drivers/virtio/virtio_ring.c | 12 ++++++++++++ >> > 1 file changed, 12 insertions(+) >> > >> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >> > index c169c6444637..305c05cc249a 100644 >> > --- a/drivers/virtio/virtio_ring.c >> > +++ b/drivers/virtio/virtio_ring.c >> > @@ -47,6 +47,18 @@ >> > >> > static bool vring_use_dma_api(void) >> > { >> > +#if defined(CONFIG_X86) && defined(CONFIG_...

Signed-off-by: Andy Lutomirski <luto at kernel.org> --- drivers/virtio/virtio_ring.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index c169c6444637..305c05cc249a 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -47,6 +47,18 @@ static bool vring_use_dma_api(void) { +#if defined(CONFIG_X86) && defined(CONFIG_XEN) + /* + * In theory, it's possible to have a buggy QEMU-supposed + * emulated Q35 IOMM...

...rote: > > Signed-off-by: Andy Lutomirski <luto at kernel.org> > > --- > > drivers/virtio/virtio_ring.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > index c169c6444637..305c05cc249a 100644 > > --- a/drivers/virtio/virtio_ring.c > > +++ b/drivers/virtio/virtio_ring.c > > @@ -47,6 +47,18 @@ > > > > static bool vring_use_dma_api(void) > > { > > +#if defined(CONFIG_X86) && defined(CONFIG_XEN) > > + /* > &...

...to at kernel.org> > >> > --- > >> > drivers/virtio/virtio_ring.c | 12 ++++++++++++ > >> > 1 file changed, 12 insertions(+) > >> > > >> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > >> > index c169c6444637..305c05cc249a 100644 > >> > --- a/drivers/virtio/virtio_ring.c > >> > +++ b/drivers/virtio/virtio_ring.c > >> > @@ -47,6 +47,18 @@ > >> > > >> > static bool vring_use_dma_api(void) > >> > { > >> > +#if defined(CON...

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too

This switches virtio to use the DMA API on Xen and if requested by module option. This fixes virtio on Xen, and it should break anything because it's off by default on everything except Xen PV on x86. To the Xen people: is this okay? If it doesn't work on other Xen variants (PVH? HVM?), can you submit follow-up patches to fix it? To everyone else: we've waffled on this for way too