Displaying 2 results from an estimated 2 matches for "c06c4c1844de".
2020 Jan 29
1
Re: [PATCH v2v v2 1/2] rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
...| k, _ ->
> error (f_"-o rhv-upload: unknown output option ‘-oo %s’") k
>--
I was too fast with the sending, consider this squashed in, (the fixed version
is in my github repo [1]):
diff --git i/v2v/output_rhv_upload.ml w/v2v/output_rhv_upload.ml
index 6482460f8de8..c06c4c1844de 100644
--- i/v2v/output_rhv_upload.ml
+++ w/v2v/output_rhv_upload.ml
@@ -57,7 +57,7 @@ let is_nonnil_uuid uuid =
PCRE.compile str
) in
if uuid = nil_uuid then false
- else PCRE.matches rex_uuid uuid
+ else PCRE.matches (Lazy.force rex_uuid) uuid
let parse_output_options options =...
2020 Jan 29
4
[PATCH v2v v2 0/2] rhv-upload: Validate UUIDs and check they don't exist already
My stab v2 at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279
It took me quite some time to go through the whole rfc 4122 just to realize we
do not need to do anything with the versions.
v2:
- Use EEXIST instead of EINVAL
- Put the colliding UUID into the error
- Do not evaluate the PCRE needlessly multiple times
v1: