search for: buyukkurt

...google.com> writes: > I have sent my review comments. I think most of my high level concerns > have been addressed (except for last few minor fix ups). > > Justin, do you have a chance to take a look? > > thanks, > > David > > On Wed, May 13, 2015 at 10:49 AM, Betul Buyukkurt <betulb at codeaurora.org> wrote: >>> Xinliang David Li <davidxl at google.com> writes: >>>>> From: <betulb at codeaurora.org> >>>>> Date: Tue, Apr 7, 2015 at 12:44 PM >>>>> Subject: [LLVMdev] IC profiling infrastructure >&g...

...just indirect call >> promotion), but this can be done as a follow up. >> >> I will start with some reviews. Hopefully others will help with reviews >> too. >> >> thanks, >> >> David >> >> >> >>> Thanks, >>> -Betul Buyukkurt >>> >>> Qualcomm Innovation Center, Inc. >>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a >>> Linux >>> Foundation Collaborative Project >>> >>> >>> >>> _________________________________________...

"Betul Buyukkurt" <betulb at codeaurora.org> writes: >> - We don't need to store the value profiling kind in the data at all. >> The frontend knows which invocations of the intrinsic are for each kind >> implicitly, much like it knows the difference between a counter for an >...

...ementation, which we plan to put it up for review. However, I’d like to inquire prior if there are any plans or ongoing work done in the community to enable indirect call target profiling support or not. Please inform if cfe-dev is a better candidate for posting PGO related emails. Thanks, -Betul Buyukkurt Employee of the Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

...;d like to make the runtime part of the change to be shared and used as a general purpose value profiler (not just indirect call promotion), but this can be done as a follow up. I will start with some reviews. Hopefully others will help with reviews too. thanks, David > Thanks, > -Betul Buyukkurt > > Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux > Foundation Collaborative Project > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu...

...remove the reserved kinds 2. In compiler-rt code, assert the kind to be icalltarget and remove the loop 3. Keep the indexed format (as is now) 4. Add assertion in profile use that icalltarget is the only expected kind. Justin, does this sound reasonable? David On Jul 2, 2015 1:10 PM, "Betul Buyukkurt" <betulb at codeaurora.org> wrote: > Any decision on below? Is everyone OK w/ removing the value_kind and > keeping > the raw profile writer and reader code to do exactly what we need it to do > today. Justin, if you agree, I'll make/upload the changes to right away? &gt...

> Xinliang David Li <davidxl at google.com> writes: >> Justin, thanks for the reply. >> I would like to point out that value_kind is actually not really stored in the raw profile data (nor do we intend to do so), other than the minimal information about per value kind NumOfSites info in per-function profile header. Basically the data is organized per value kind instead of

...such a way to > enable both use cases, we could share infrastructure. Thanks, we've recently posted an RFC on the design. The design is quite straightforward and simple but the gains will be seen when the data is used in optimizations. > Philip >> >> Thanks, >> -Betul Buyukkurt >> >> Employee of the Qualcomm Innovation Center, Inc. >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a >> Linux >> Foundation Collaborative Project >> >> >> _______________________________________________ >> LLVM Develope...

Xinliang David Li <davidxl at google.com> writes: > On Mon, Jun 15, 2015 at 5:35 PM, Justin Bogner <mail at justinbogner.com> wrote: >> "Betul Buyukkurt" <betulb at codeaurora.org> writes: >>>> - We don't need to store the value profiling kind in the data at all. >>>> The frontend knows which invocations of the intrinsic are for each kind >>>> implicitly, much like it knows the difference betwe...

Justin, do you have more concerns on keeping value_kind? If there is still disagreement, can we agree to move on with it for now ? After the initial version of the patches checked in, we can do more serious testings with large apps and revisit this if there are problems discovered. thanks, David On Mon, Jun 15, 2015 at 10:47 PM, Xinliang David Li <davidxl at google.com> wrote:

...the indirect call profile infrastructure http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-April/084271.html Your feedback and comments will be highly appreciated. Thanks, Ivan ============================================================================RFC: Indirect Call Promotion LLVM Pass Betul Buyukkurt and Ivan Baev 1. Introduction Indirect call promotion (ICP) replaces an indirect call instruction to a set of target addresses with a sequence of tests guarding direct calls to selected targets, plus a fall through branch containing the original indirect call. The ICP optimization is found to be t...