search for: build_supermin_appliance

https://bugzilla.redhat.com/show_bug.cgi?id=769680

...fs_h *g, const char *dir, ...); static int contains_old_style_appliance (guestfs_h *g, const char *path, void *data); static int contains_fixed_appliance (guestfs_h *g, const char *path, void *data); static int contains_supermin_appliance (guestfs_h *g, const char *path, void *data); -static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, uid_t uid, char **kernel, char **initrd, char **appliance); +static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, char **kernel, char **initrd, char **appliance); static int run_supermin_build (guestfs_h *g, const char *lockfile, c...

...22e4a875bb061d259e87d missed a couple of uses of print_timestamped_message in launch.c. --- src/launch.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/launch.c b/src/launch.c index 9deb0cf..07a89ec 100644 --- a/src/launch.c +++ b/src/launch.c @@ -927,7 +927,7 @@ build_supermin_appliance (guestfs_h *g, const char *path, int r, len; if (g->verbose) - print_timestamped_message (g, "begin building supermin appliance"); + guestfs___print_timestamped_message (g, "begin building supermin appliance"); len = strlen (g->tmpdir); *kernel = safe...

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.

This attempts to implement the idea proposed in https://www.redhat.com/archives/libguestfs/2010-April/msg00087.html The idea is that an externally managed QEMU (manual, or via libvirt) can boot the appliance kernel/initrd. libguestfs can then be just told of the UNIX domain socket associated with the guest daemon. An example based on guestfish. 1. Step one, find the appliance kernel/initrd

...fs_h *g, > CLEANUP_FREE char *path = NULL; > > /* Step (1). */ > - r = find_path (g, contains_supermin_appliance, NULL, &supermin_path); > - if (r == -1) > - return -1; > - > - if (r == 1) > - /* Step (2): build supermin appliance. */ > - return build_supermin_appliance (g, supermin_path, > - kernel, initrd, appliance); > - > - /* Step (3). */ > r = find_path (g, contains_fixed_appliance, NULL, &path); > if (r == -1) > return -1; > @@ -162,7 +152,7 @@ build_appliance (guestfs_h *g, >...

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

...ppliance (guestfs_h *g, const char *path, void *da static char *calculate_supermin_checksum (guestfs_h *g, const char *supermin_path); static int check_for_cached_appliance (guestfs_h *g, const char *supermin_path, const char *checksum, char **kernel, char **initrd, char **appliance); static int build_supermin_appliance (guestfs_h *g, const char *supermin_path, const char *checksum, char **kernel, char **initrd, char **appliance); +static pid_t fork_helper(guestfs_h *g); /* Locate or build the appliance. * @@ -170,19 +172,59 @@ calculate_supermin_checksum (guestfs_h *g, const char *supermin_path) if (g-&gt...

...st step is search supermin.d in all specified > directories: > /* Step (1). */ > r = find_path (g, contains_supermin_appliance, NULL, &supermin_path); > if (r == -1) > return -1; > > if (r == 1) > /* Step (2): build supermin appliance. */ > return build_supermin_appliance (g, supermin_path, > kernel, initrd, appliance); OK, I see, that is indeed a bug. Can you suggest a patch which fixes this so that directories are searched correctly? However I still think that putting all of the appliances into a single directory and expe...

...s /usr/lib64/guestfs > initrd kernel README.fixed root supermin.d > > libguestfs by default uses a single path to search fixed appliance and > supermin.d. It seemed to me that the presence of options "--disable > appliance --disable-daemon" must exclude the use of > build_supermin_appliance. > But libguestfs in any case trying to find supermin.d. OK, I see - what's actually happening is that you've got a path which is both a fixed appliance and a supermin appliance (although maybe it only appears to be a supermin appliance -- libguestfs just looks for the "supermin.d&...

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

...| 3 +-- src/launch-unix.c | 6 ++---- src/launch.c | 25 ------------------------- 7 files changed, 16 insertions(+), 58 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index de088e9..864761f 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -233,18 +233,15 @@ build_supermin_appliance (guestfs_h *g, } (void) utimes (cachedir, NULL); - if (g->verbose) - guestfs_int_print_timestamped_message (g, "begin building supermin appliance"); + debug (g, "begin building supermin appliance"); /* Build the appliance if it needs to be built. */ - if (g...

...nexpected serial (%d/%d)", hdr->serial, serial); + error (g, "unexpected serial (%u/%u)", hdr->serial, serial); return -1; } diff --git a/src/appliance.c b/src/appliance.c index 2167ac3..2645cca 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -229,7 +229,7 @@ build_supermin_appliance (guestfs_h *g, */ len = strlen (tmpdir) + 128; char cachedir[len]; - snprintf (cachedir, len, "%s/.guestfs-%d", tmpdir, uid); + snprintf (cachedir, len, "%s/.guestfs-%ju", tmpdir, (uintmax_t) uid); char lockfile[len]; snprintf (lockfile, len, "%s/lock&quot...

...nexpected serial (%d/%d)", hdr->serial, serial); + error (g, "unexpected serial (%u/%u)", hdr->serial, serial); return -1; } diff --git a/src/appliance.c b/src/appliance.c index 2167ac3..2645cca 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -229,7 +229,7 @@ build_supermin_appliance (guestfs_h *g, */ len = strlen (tmpdir) + 128; char cachedir[len]; - snprintf (cachedir, len, "%s/.guestfs-%d", tmpdir, uid); + snprintf (cachedir, len, "%s/.guestfs-%ju", tmpdir, (uintmax_t) uid); char lockfile[len]; snprintf (lockfile, len, "%s/lock&quot...

Various changes/fixes to use smaller stack frames. Rich.

...min_appliance (guestfs_h *g, const char *path, void *data) { - return dir_contains_files (path, "supermin.d", NULL); + return dir_contains_files (g, path, "supermin.d", NULL); } /* Build supermin appliance from supermin_path to $TMPDIR/.guestfs-$UID. @@ -201,19 +201,12 @@ build_supermin_appliance (guestfs_h *g, char **appliance) { CLEANUP_FREE char *tmpdir = guestfs_get_cachedir (g); + CLEANUP_FREE char *cachedir = NULL, *lockfile = NULL, *appliancedir = NULL; struct stat statbuf; - size_t len; - /* len must be longer than the length of any pathname we...

...pliance in current directory\n"); + fprintf (stderr, + "looking for supermin appliance in current directory\n"); if (dir_contains_files (".", - supermin_name, supermin_hostfiles_name, - "kmod.whitelist", NULL)) { - if (build_supermin_appliance (g, ".", &kernel, &initrd) == -1) - return -1; - break; + supermin_name, supermin_hostfiles_name, + "kmod.whitelist", NULL)) { + if (build_supermin_appliance (g, ".", &kernel, &initrd) =...

Lots of changes since v2, too much to remember or summarize. Please ignore patch 11/11, it's just for my testing. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2016-March/thread.html#00157 Not running the 'hwclock' command reduces boot times considerably. However I'm not sure if it is safe. See the question I posted on qemu-devel: http://thread.gmane.org/gmane.comp.emulators.qemu/402194 At the moment, about 50% of the time is consumed by SeaBIOS. Of this, about ⅓rd is SGABIOS