search for: buffer_get_bignum2

I am working on a port of Openssh 3.8p1 after already having done a port of Openssh 3.5p1. There are a couple of new lines in buffer_get_bignum2() that are causing me problems: if (len > 0 && (bin[0] & 0x80)) fatal("buffer_get_bignum2: negative numbers not supported"); The "& 0x80" check is not relevant in ebcdic. Does anyone know why this check was added? What are the c...

...added smartcard support to PuTTY and this worked fine until yesterday when we replaced one of our Slackware-9 machines by a Slackware-10 one. Slackware-9 contained OpenSSH 3.5p1 while Slackware-10 has OpenSSH 3.8.1p1. Now the same keys that worked before do not work anymore and OpenSSH fails with buffer_get_bignum2: negative numbers not supported I first supected that my smartcard-modification were the reason and I double-checked the way I deliver the smartcards public key to PuTTY. Maybe I forgot to prepend a 0x00 byte to a modulus starting with 0x80. But I did not. Here's the relevant output from sshd...

...====================================================== RCS file: /cvs/src/usr.bin/ssh/bufaux.h,v retrieving revision 1.17 diff -u -r1.17 bufaux.h --- bufaux.h 18 Mar 2002 17:25:29 -0000 1.17 +++ bufaux.h 19 Apr 2002 12:55:56 -0000 @@ -23,6 +23,9 @@ void buffer_get_bignum(Buffer *, BIGNUM *); void buffer_get_bignum2(Buffer *, BIGNUM *); +u_short buffer_get_short(Buffer *); +void buffer_put_short(Buffer *, u_short); + u_int buffer_get_int(Buffer *); void buffer_put_int(Buffer *, u_int);

...====================================================== RCS file: /cvs/src/usr.bin/ssh/bufaux.h,v retrieving revision 1.17 diff -u -r1.17 bufaux.h --- bufaux.h 18 Mar 2002 17:25:29 -0000 1.17 +++ bufaux.h 19 Apr 2002 12:55:56 -0000 @@ -23,6 +23,9 @@ void buffer_get_bignum(Buffer *, BIGNUM *); void buffer_get_bignum2(Buffer *, BIGNUM *); +u_short buffer_get_short(Buffer *); +void buffer_put_short(Buffer *, u_short); + u_int buffer_get_int(Buffer *); void buffer_put_int(Buffer *, u_int);

On 8 June 2018 at 11:21, PGNet Dev <pgnet.dev at gmail.com> wrote: > fyi > > add'l -- and looks unrelated -- issue > /usr/include/pthread.h:251:12: note: previous declaration of ?pthread_join? was here > extern int pthread_join (pthread_t __th, void **__thread_return); What included pthread.h? That's explicitly not supported by sshd: $ grep THREAD

...:07 2003 +++ openssh-3.7.1p2/bufaux.c Tue Oct 7 08:22:00 2003 @@ -126,7 +126,7 @@ carry = !++uc[i]; } } - buffer_put_string(buffer, buf+hasnohigh, bytes-hasnohigh); + buffer_put_binary(buffer, buf+hasnohigh, bytes-hasnohigh); memset(buf, 0, bytes); xfree(buf); } @@ -136,7 +136,7 @@ buffer_get_bignum2(Buffer *buffer, BIGNUM *value) { u_int len; - u_char *bin = buffer_get_string(buffer, &len); + u_char *bin = buffer_get_binary(buffer, &len); if (len > 8 * 1024) fatal("buffer_get_bignum2: cannot handle BN of size %d", len); @@ -212,6 +212,36 @@ * will be stored the...