search for: btrfsvol

...with list-filesystems, inspect-os, inspect-get-roots, etc... I'm seeing this in version 1.26, but haven't found anything directly resolving this in newer versions. These commands all show the partition listed twice as in the following output: ><fs> inspect-get-roots /dev/sda2 btrfsvol:/dev/sda2/@ The output above complicates the existing virt-v2v process, as it prompts users to select the appropriate root filesystem. (Either one works for the conversion.) I've patched v2v to strip out the duplicate 'btrfsvol' entry if the partition itself is in both strings, but...

...ev wrote: > Hello everyone! > > I have an issue with OpenSUSE-42.1 (I guess this is the only distro > with btrfs snapshots by default). > As we remember, list_filesystems returns btrfs snapshots along with devices. > > ><fs> list-filesystems > /dev/sda1: swap > btrfsvol:/dev/sda2/@: btrfs > btrfsvol:/dev/sda2/@/.snapshots: btrfs > btrfsvol:/dev/sda2/@/.snapshots/1/snapshot: btrfs > btrfsvol:/dev/sda2/@/.snapshots/2/snapshot: btrfs > ... > btrfsvol:/dev/sda2/@/.snapshots/16/snapshot: btrfs > /dev/sda2: btrfs > > > The btrfs snapshots ar...

...ge_format> <package_management>zypper</package_management> <hostname>linux-luwo.site</hostname> <format>installed</format> <mountpoints> <mountpoint dev="/dev/sda3">/</mountpoint> <mountpoint dev="btrfsvol:/dev/sda3/@/opt">/opt</mountpoint> <mountpoint dev="btrfsvol:/dev/sda3/@/srv">/srv</mountpoint> <mountpoint dev="btrfsvol:/dev/sda3/@/tmp">/tmp</mountpoint> <mountpoint dev="btrfsvol:/dev/sda3/@/home">/home&...

On Wednesday 09 September 2015 15:54:10 Olaf Hering wrote: > Just poked around in my =libguestfs folder... > > On Wed, Sep 09, Pino Toscano wrote: > > > + if (STRPREFIX (line, "ID=")) { > > This is not handled: > > NAME="SLES" > VERSION="12" > VERSION_ID="12" > PRETTY_NAME="SUSE Linux Enterprise Server

...directory guestmount: '/dev/sda1' could not be mounted. guestmount: Check mount(8) man page to ensure options 'subvol=.snapshots/2/snapshot' guestmount: are supported by the filesystem that is being mounted. guestmount: Did you mean to mount one of these filesystems? guestmount: btrfsvol:/dev/sda1/@ (btrfs) guestmount: btrfsvol:/dev/sda1/@/.snapshots (btrfs) guestmount: btrfsvol:/dev/sda1/@/opt (btrfs) guestmount: btrfsvol:/dev/sda1/@/srv (btrfs) guestmount: btrfsvol:/dev/sda1/@/tmp (btrfs) guestmount: btrfsvol:/dev/sda1/@/home (btrfs) [etc] The problem here is...

...p;vols->val[i]; + + /* Ignore the default subvolume. We get it by simply mounting + * the whole device of this btrfs filesystem. + */ + if (this->btrfssubvolume_id == (uint64_t) default_volume) + continue; + guestfs_int_add_sprintf (g, sb, "btrfsvol:%s/%s", device, this->btrfssubvolume_path); -- 2.5.0

These 3 patches implement support for APIs which must accept a mountable, but don't update apis which must return mountables. Matt

Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/inspect-fs-unix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index 01a59f1..f55e53b 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -58,8 +58,8 @@ COMPILE_REGEXP (re_scientific_linux, "Scientific Linux.*release

...(g, "%s/value", opts[i]); - snprintf (augpath, sizeof augpath, "%s/value", *opt); - subvol = guestfs_aug_get (g, augpath); + subvol = guestfs_aug_get (g, optvalue); if (subvol == NULL) return -1; - new = safe_asprintf (g, "btrfsvol:%s/%s", mountable, subvol); - free (mountable); - mountable = new; + old_mountable = mountable; + mountable = safe_asprintf (g, "btrfsvol:%s/%s", mountable, subvol); + free (old_mountable); } } } -- 2.7.4

...er of configuration. To test this, I installed /boot into a btrfs subvolume. Post install, I then edited extlinx.conf to add the prefix /boot1/ to the /vmlinuz and /initramfs parameters. The installation included a mount point for the btrfs volume so I then ran: /sbin/extlinux --install /btrfsvol/boot1/extlinux and it responded with device on /dev/vda1. This looked like it should work but it did not. Instead I got a lot of "found" messages. Comments? Any ideas? Gene

...fs_btrfs (['/dev/sda2'], label => 'ROOT'); + $g->mount ('/dev/sda2', '/'); + $g->btrfs_subvolume_create ('/root'); + $g->btrfs_subvolume_create ('/home'); + $g->umount ('/'); - $g->mount ('btrfsvol:/dev/sda2/root', '/'); + $g->mount ('btrfsvol:/dev/sda2/root', '/'); + } } elsif ($ENV{LAYOUT} eq 'lvm-luks') { -- 2.19.0.rc0

...ests/mountable' make check-TESTS make[1]: Entering directory '/home/rjones/d/libguestfs/tests/mountable' 2 seconds: ./test-internal-parse-mountable PASS: test-internal-parse-mountable /home/rjones/d/libguestfs/run --test ./test-mountable-inspect.sh libguestfs: error: mount: mount_stub: btrfsvol:btrfsvol:/dev/sda2/root/root: expecting a btrfs volume /home/rjones/d/libguestfs/tests/mountable/test-mountable-inspect.sh: error #1: unexpected output from inspect-get-mountpoints /home/rjones/d/libguestfs/run: command failed with exit code 1 FAIL: test-mountable-inspect.sh =================== 1 o...

...y > > mounting > > + * the whole device of this btrfs filesystem. > > + */ > > + if (this->btrfssubvolume_id == (uint64_t) default_volume) > > + continue; > > + > > guestfs_int_add_sprintf (g, sb, > > "btrfsvol:%s/%s", > > device, this->btrfssubvolume_path); > > ACK. > > Was there an RHBZ# for this? Can't seem to find it ... I least none that I am aware of, not even a bsc# as we have an pretty old version on openSUSE. I just got the problem with my testing of r...

v2: - Moved the btrfs available test into the subclause where it is used. Note I got tired of fighting emacs indentation mode and I pushed a whitespace only patch which fixes the indentation to be 4 spaces instead of 2 spaces: https://github.com/libguestfs/libguestfs/commit/df54c75d4c53ed580e5269306e11e0758d169452 This v2 patch requires that one. Rich.

...ect_os, inspect_get_filesystems and inspect_get_mountpoints can't express a btrfs subvolume as they're expected to be the names of block devices. As a starter for 10, I propose the addition of parallel apis suffixed _ext which return annotated device descriptions, e.g.: block:/dev/vda2 btrfsvol:/dev/vda4,root The string before the colon is a descriptor. The format of the string after the colon is custom to the descriptor, and is described in the API. A client program can ignore strings with unknown descriptors. New descriptors can be added as required. The old apis would return the s...

...le (or simple, anyway) in this case for 2 reasons: 1. You'd need 2 arguments passed to the cleanup function, not one. Without fs->type you don't know whether fs_buf has been mounted or not. 2. You can't catch and report an error. [PATCH 3/7] mountable: Make list-filesystems return btrfsvols Already provisionally ACKed. [PATCH 4/7] New internal API: internal_parse_mountable [PATCH 5/7] inspect: Update inspect_os to use mountables [PATCH 6/7] btrfs: Make a stub Fedora btrfs guest for inspection [PATCH 7/7] mountable: Test inspection of fedora image Not previously reviewed.

This type is initially identical to Device. --- generator/bindtests.ml | 2 +- generator/c.ml | 7 +++++-- generator/csharp.ml | 6 ++++-- generator/daemon.ml | 4 ++-- generator/erlang.ml | 6 +++--- generator/fish.ml | 8 ++++---- generator/gobject.ml | 11 ++++++----- generator/haskell.ml | 11 +++++++---- generator/java.ml | 10 +++++-----

This is a series of simplifications to the stubs code. It's all refactoring, there is no functional change. Rich.

...check-TESTS > make[1]: Entering directory '/home/rjones/d/libguestfs/tests/mountable' > 2 seconds: ./test-internal-parse-mountable > PASS: test-internal-parse-mountable > /home/rjones/d/libguestfs/run --test ./test-mountable-inspect.sh > libguestfs: error: mount: mount_stub: btrfsvol:btrfsvol:/dev/sda2/root/root: expecting a btrfs volume > /home/rjones/d/libguestfs/tests/mountable/test-mountable-inspect.sh: error #1: unexpected output from inspect-get-mountpoints > /home/rjones/d/libguestfs/run: command failed with exit code 1 > FAIL: test-mountable-inspect.sh > ===...

Is btrfs subvol support failing just for me? Looks like nothing adds the required '@/' string. virt-ls uses the first variant of the command: ><rescue> mount -vo subvol=var/spool,ro /dev/sda2 /sysroot/ [ 113.852047] BTRFS info (device sda2): disk space caching is enabled [ 113.852869] BTRFS: has skinny extents mount: mount(2) failed: No such file or directory ><rescue>