search for: btrfs_unlink

We need an smb_mb() before waitqueue_active to avoid missing wakeups. Before Mitch was hitting a deadlock between the ordered flushers and the transaction commit because the ordered flushers were waiting for more refs and were never woken up, so those smp_mb()''s are the most important. Everything else I added for correctness sake and to avoid getting bitten by this again somewhere else.

...fs_free_path+0x22/0x26 [ 676.673653] [<ffffffff8120fa5e>] __btrfs_end_transaction+0x98/0x1f3 [ 676.673653] [<ffffffff8120fbf0>] btrfs_end_transaction_throttle+0x13/0x15 [ 676.673653] [<ffffffff81211a56>] __unlink_end_trans+0x68/0x6d [ 676.673653] [<ffffffff81216558>] btrfs_unlink+0x8a/0xa7 [ 676.673653] [<ffffffff810f5d83>] vfs_unlink+0x6f/0xbd [ 676.673653] [<ffffffff810f5eba>] do_unlinkat+0xe9/0x173 [ 676.673653] [<ffffffff810e993b>] ? filp_close+0x69/0x75 [ 676.673653] [<ffffffff810f71d7>] sys_unlinkat+0x24/0x26 [ 676.673653] [<ffffff...

...s] Jul 2 21:42:59 bkp010 kernel: [ 668.552214] [<ffffffffa0706af9>] btrfs_end_transaction+0xb/0xd [btrfs] Jul 2 21:42:59 bkp010 kernel: [ 668.552321] [<ffffffffa07097f5>] __unlink_end_trans+0x5e/0x63 [btrfs] Jul 2 21:42:59 bkp010 kernel: [ 668.552428] [<ffffffffa070e69f>] btrfs_unlink+0x86/0xa0 [btrfs] Jul 2 21:42:59 bkp010 kernel: [ 668.552526] [<ffffffff810ef004>] vfs_unlink+0x6f/0xdc Jul 2 21:42:59 bkp010 kernel: [ 668.552621] [<ffffffff810ef15e>] do_unlinkat+0xed/0x199 Jul 2 21:42:59 bkp010 kernel: [ 668.552717] [<ffffffff812c274e>] ? sock_alloc_fi...

...i2c_i801 i2c_core sky2 intel_agp pcspkr intel_gtt sg processor button Mar  9 23:59:17 ftp2 kernel: [121661.742911] Mar  9 23:59:17 ftp2 kernel: [121661.742911] Pid: 15572, comm: rm Not tainted 2.6.37-gentoo-mykernel #2 965GM-S2/965GM-S2 Mar  9 23:59:17 ftp2 kernel: [121661.742911] RIP: 0010:[]  [] btrfs_unlink+0x74/0xe7 [btrfs] Mar  9 23:59:17 ftp2 kernel: [121661.742911] RSP: 0018:ffff880123e3be68  EFLAGS: 00010282 Mar  9 23:59:17 ftp2 kernel: [121661.742911] RAX: 00000000fffffffb RBX: ffff880103770900 RCX: ffff8801277ce510 Mar  9 23:59:17 ftp2 kernel: [121661.742911] RDX: 0000000000000000 RSI: ffffea00...

When adding orphans to an inode''s root, we start a transaction for that root that when ended in several places such as for example extent-tree.c:btrfs_remove_block_group(), inode.c:btrfs_unlink() and inode.c:btrfs_evict_node(), doesn''t result in a commit, that is, inode.c:btrfs_orphan_commit_root() doesn''t get called (via transaction.c:commit_fs_roots()). The respective inode will end up being called by inode.c:btrfs_evict_node() (via the VFS). So my likely dirty hack,...

With the ATI bug I was hitting earlier fixed, only my btrfs partition continues to show high cpu usage for some operations. Rsync, git pull, git checkout and svn up are typicall operations which trigger the high cpu usage. As an example, this perf report is from using git checkout to change to a new branch; the change needed to checkout 208 files out of about 1600 total files. du(1) reports

If we have particularly full nodes, we could call btrfs_node_blockptr up to 32 times, which is 32 pairs of kmap/kunmap, which _sucks_. So go ahead and map the extent buffer while we look for readahead targets. Thanks, Signed-off-by: Josef Bacik <josef@redhat.com> --- fs/btrfs/ctree.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git

...* do a destroy_inode */ if (is_bad_inode(inode)) { + /* 1 item for the orphan entry */ trans = btrfs_start_transaction(root, 1); + BUG_ON(IS_ERR(trans)); btrfs_orphan_del(trans, inode); btrfs_end_transaction(trans, root); iput(inode); @@ -2337,7 +2348,16 @@ static int btrfs_unlink(struct inode *dir, struct dentry *dentry) root = BTRFS_I(dir)->root; - trans = btrfs_start_transaction(root, 1); + /* + * 1 item for the orphan entry + * 1 for the actual inode + * 1 for inode ref + * 2 for dir items + * 2 for the log entries + */ + trans = btrfs_start_transaction(ro...

...} @@ -2220,7 +2220,7 @@ int btrfs_orphan_del(struct btrfs_trans_handle *trans, struct inode *inode) if (trans && delete_item) { ret = btrfs_del_orphan_item(trans, root, inode->i_ino); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); } if (release_rsv) @@ -2651,7 +2651,7 @@ int btrfs_unlink_inode(struct btrfs_trans_handle *trans, ret = btrfs_del_dir_entries_in_log(trans, root, name, name_len, dir, index); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); err: btrfs_free_path(path); if (ret) @@ -2868,11 +2868,11 @@ static int btrfs_unlink(struct inode *dir, struct dentry *d...