Displaying 6 results from an estimated 6 matches for "btrfs_replace_start".
2015 Jun 12
0
Re: [PATCH] New API: btrfs_replace_start
...that I am sure
> this api can work
While I appreciate the effort you are putting in writing and testing
the new API, and the explanation about the added calls in checks,
in my opinion the added tests are not (in they way they are added)
useful.
The problem is that if I, for example, make the btrfs_replace_start
implementation a no-op (for example by having just "return 0" in it),
the test would keep working as before, as the status-quo before and
after each block of btrfs-replace-start calls is the same, and nobody
would notice if not by running it.
Sure, making it a no-op is a stretch, sure, bu...
2015 Jun 11
0
Re: [PATCH] New API: btrfs_replace_start
...nsertions(+)
>
> diff --git a/daemon/btrfs.c b/daemon/btrfs.c
> index 39392f7..acc300d 100644
> --- a/daemon/btrfs.c
> +++ b/daemon/btrfs.c
> @@ -2083,3 +2083,43 @@ do_btrfs_image (char *const *sources, const char *image,
>
> return 0;
> }
> +
> +int
> +do_btrfs_replace_start (const char *srcdev, const char *targetdev,
> + const char* mntpoint, int force)
> +{
> + const size_t MAX_ARGS = 64;
> + const char *argv[MAX_ARGS];
> + size_t i = 0;
> + CLEANUP_FREE char *err = NULL;
> + CLEANUP_FREE char *path_buf = NULL;
> +...
2015 Jun 12
0
Re: [PATCH] New API: btrfs_replace_start
...9392f7..acc300d 100644
> >> --- a/daemon/btrfs.c
> >> +++ b/daemon/btrfs.c
> >> @@ -2083,3 +2083,43 @@ do_btrfs_image (char *const *sources, const char *image,
> >>
> >> return 0;
> >> }
> >> +
> >> +int
> >> +do_btrfs_replace_start (const char *srcdev, const char *targetdev,
> >> + const char* mntpoint, int force)
> >> +{
> >> + const size_t MAX_ARGS = 64;
> >> + const char *argv[MAX_ARGS];
> >> + size_t i = 0;
> >> + CLEANUP_FREE char *err = NUL...
2015 Jun 12
2
Re: [PATCH] New API: btrfs_replace_start
...t;>> --- a/daemon/btrfs.c
>>>> +++ b/daemon/btrfs.c
>>>> @@ -2083,3 +2083,43 @@ do_btrfs_image (char *const *sources, const char *image,
>>>>
>>>> return 0;
>>>> }
>>>> +
>>>> +int
>>>> +do_btrfs_replace_start (const char *srcdev, const char *targetdev,
>>>> + const char* mntpoint, int force)
>>>> +{
>>>> + const size_t MAX_ARGS = 64;
>>>> + const char *argv[MAX_ARGS];
>>>> + size_t i = 0;
>>>> + CLEANUP_FR...
2015 Jun 10
2
[PATCH] New API: btrfs_replace_start
...s/test-btrfs-devices.sh | 8 ++++++++
3 files changed, 67 insertions(+)
diff --git a/daemon/btrfs.c b/daemon/btrfs.c
index 39392f7..acc300d 100644
--- a/daemon/btrfs.c
+++ b/daemon/btrfs.c
@@ -2083,3 +2083,43 @@ do_btrfs_image (char *const *sources, const char *image,
return 0;
}
+
+int
+do_btrfs_replace_start (const char *srcdev, const char *targetdev,
+ const char* mntpoint, int force)
+{
+ const size_t MAX_ARGS = 64;
+ const char *argv[MAX_ARGS];
+ size_t i = 0;
+ CLEANUP_FREE char *err = NULL;
+ CLEANUP_FREE char *path_buf = NULL;
+ int r;
+
+ path_buf = sysroot_path (mn...
2015 Jun 12
2
Re: [PATCH] New API: btrfs_replace_start
...mon/btrfs.c b/daemon/btrfs.c
>> index 39392f7..acc300d 100644
>> --- a/daemon/btrfs.c
>> +++ b/daemon/btrfs.c
>> @@ -2083,3 +2083,43 @@ do_btrfs_image (char *const *sources, const char *image,
>>
>> return 0;
>> }
>> +
>> +int
>> +do_btrfs_replace_start (const char *srcdev, const char *targetdev,
>> + const char* mntpoint, int force)
>> +{
>> + const size_t MAX_ARGS = 64;
>> + const char *argv[MAX_ARGS];
>> + size_t i = 0;
>> + CLEANUP_FREE char *err = NULL;
>> + CLEANUP_FREE ch...