search for: btrfs_remove_free_spac

We keep hitting bugs in the tree log replay because btrfs_remove_free_space doesn''t account for some corner case. So add a bunch of tests to try and fully test btrfs_remove_free_space since the only time it is called is during tree log replay. These tests all finish successfully, so as we find more of these bugs we need to add to these tests to make sure we don...

...mutex_lock(&caching_ctl->mutex); if (start >= caching_ctl->progress) { - ret = add_excluded_extent(root, start, num_bytes); - BUG_ON(ret); /* -ENOMEM */ + add_excluded_extent(root, start, num_bytes); } else if (start + num_bytes <= caching_ctl->progress) { ret = btrfs_remove_free_space(block_group, start, num_bytes); @@ -6222,8 +6221,7 @@ int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, start = caching_ctl->progress; num_bytes = ins->objectid + ins->offset - caching_ctl->progress; - ret = add_excluded_extent(root, s...

...ytes; + + ret = search_bitmap(block_group, bitmap_info, &search_start, + &search_bytes); + if (ret < 0 || search_start != *offset) + return -EAGAIN; + goto again; } else if (!bitmap_info->bytes) { unlink_free_space(block_group, bitmap_info); @@ -644,8 +660,13 @@ int btrfs_remove_free_space(struct btrfs_block_group_cache *block_group, again: info = tree_search_offset(block_group, offset, 0, 0); if (!info) { - WARN_ON(1); - goto out_lock; + info = tree_search_offset(block_group, + offset_to_bitmap(block_group, offset), + 1, 0); + if (!info) { + WARN_ON(1); + g...

Hi guys, my computer suddenly failed to boot. It seams that it is unable to mount /home which is btrfs. Here are the messages I get during the boot (the relevant part; hopefully): Feb 02 13:59:58 Edge kernel: kernel BUG at fs/btrfs/extent-tree.c:6185! Feb 02 13:59:58 Edge kernel: invalid opcode: 0000 [#1] PREEMPT SMP Feb 02 13:59:58 Edge kernel: Modules linked in: joydev coretemp kvm_intel kvm

Hello, My computer locked up and I had to press the reset button. Ever since then I can''t mount the btrfs filesystem, here''s the output: [ 37.645583] ------------[ cut here ]------------ [ 37.645598] WARNING: at fs/btrfs/free-space-cache.c:1887 btrfs_remove_free_space+0x329/0x350 [btrfs]() [ 37.645600] Modules linked in: btrfs zlib_deflate libcrc32c ext4 jbd2 mbcache crc16 snd_hda_codec_realtek rc_dib0700_rc5 mt2266 dvb_usb_dib0700 dib3000mc dib8000 dib0070 dib7000m dib7000p dibx000_common dib0090 dvb_usb dvb_core rc_core microcode joydev usb_storage uas core...

...UG_ON(ret); + btrfs_fixable_bug_on(ret); leaf = path->nodes[0]; extent_item = btrfs_item_ptr(leaf, path->slots[0], @@ -5225,28 +5225,28 @@ int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, if (!caching_ctl) { BUG_ON(!block_group_cache_done(block_group)); ret = btrfs_remove_free_space(block_group, start, num_bytes); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); } else { mutex_lock(&caching_ctl->mutex); if (start >= caching_ctl->progress) { ret = add_excluded_extent(root, start, num_bytes); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); } else if (...

...31d244ca4 0000000000000000 ffff88031ca0bf00 Feb 1 22:57:37 localhost kernel: [ 8561.602956] ffff88031d37f000 ffff8803098fb840 ffffffffa01ff633 ffffffff8107dbd0 Feb 1 22:57:37 localhost kernel: [ 8561.602956] Call Trace: Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01ff633>] btrfs_remove_free_space+0x53/0x280 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffff8107dbd0>] ? finish_wait+0x80/0x80 Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01b1e97>] btrfs_alloc_logged_file_extent+0x1b7/0x1d0 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956]...

...00000286 ffff8801cf424d24 0000000cc10b6000 0000000000008000 [ 316.548172] 0000000000008050 ffff8801e8aae4a0 ffff8801cf424d00 0000000000000000 [ 316.548267] ffff8801d3d162c0 ffff8801cfde7943 0000000000000000 ffffffffa01af105 [ 316.548363] Call Trace: [ 316.548429] [<ffffffffa01af105>] ? btrfs_remove_free_space+0x24c/0x276 [btrfs] [ 316.548540] [<ffffffffa0170d2f>] ? btrfs_alloc_logged_file_extent+0x86/0x18d [btrfs] [ 316.548658] [<ffffffffa01aa42a>] ? replay_one_extent+0x2fa/0x43e [btrfs] [ 316.548742] [<ffffffff8109b605>] ? __call_rcu+0x5d/0x16e [ 316.548835] [<ffffffffa01a...