search for: btrfs_relocate_chunk

The WARN_ON() in start_transaction() was triggered while balancing. The cause is btrfs_relocate_chunk() started a transaction and then called iput() on the inode that stores free space cache, and iput() called btrfs_start_transaction() again. Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/inode.c | 2 +- 1 files changed,...

...ffffff8117832b>] kmem_cache_alloc_trace+0xeb/0x1d0 [<ffffffffa04db499>] btrfs_alloc_block_rsv+0x39/0x70 [btrfs] [<ffffffffa04f8bad>] btrfs_orphan_add+0x13d/0x1b0 [btrfs] [<ffffffffa04e2b13>] btrfs_remove_block_group+0x143/0x500 [btrfs] [<ffffffffa0518158>] btrfs_relocate_chunk.isra.63+0x618/0x790 [btrfs] [<ffffffffa051bc27>] btrfs_balance+0x8f7/0xe90 [btrfs] [<ffffffffa05240a0>] btrfs_ioctl_balance+0x250/0x550 [btrfs] [<ffffffffa05269ca>] btrfs_ioctl+0xdfa/0x25f0 [btrfs] [<ffffffff8119c936>] do_vfs_ioctl+0x96/0x570 [<fffffff...

...[18483.577422] [<ffffffffa0734f6a>] add_data_references+0xc1/0x245 [btrfs] [18483.577480] [<ffffffffa0735a87>] relocate_block_group+0x212/0x503 [btrfs] [18483.577537] [<ffffffffa0735ec7>] btrfs_relocate_block_group+0x14f/0x283 [btrfs] [18483.577634] [<ffffffffa0715d8a>] btrfs_relocate_chunk.isra.65+0x50/0x3bc [btrfs] [18483.577731] [<ffffffffa0711d09>] ? free_extent_buffer+0x77/0x7c [btrfs] [18483.577788] [<ffffffffa07190cc>] btrfs_balance+0x9c2/0xb9a [btrfs] [18483.577838] [<ffffffff810b9117>] ? __do_fault+0x3d0/0x40a [18483.577888] [<ffffffff810e5e02>] ?...

I have a 3 disk raid1 filesystem mounted with nodatacow. I have a folder in said filesystem with the ''C'' NOCOW & ''Z'' Not_Compressed flags set for good measure. I then copy in a large file and proceed to make random modifications. Filefrag shows no additional extents created, good so far. A big thank you to the those devs who got that working. However, after

...relocation+0x3be/0x510 [ 347.237740] [<ffffffff812839f3>] relocate_tree_blocks+0x5e3/0x610 [ 347.237743] [<ffffffff812849a4>] relocate_block_group+0x444/0x6c0 [ 347.237747] [<ffffffff81284dc9>] btrfs_relocate_block_group+0x1a9/0x2d0 [ 347.237751] [<ffffffff8125de36>] btrfs_relocate_chunk.isra.53+0x56/0x730 [ 347.237754] [<ffffffff812621fe>] btrfs_balance+0x82e/0xd50 [ 347.237758] [<ffffffff812627a0>] balance_kthread+0x80/0x90 [ 347.237762] [<ffffffff8105ec33>] kthread+0xb3/0xc0 [ 347.237766] [<ffffffff815a43fc>] ret_from_fork+0x7c/0xb0 [ 347.237770]...

Hi all, Did someone have met this problem before. When doing the tests, I hit the WARN_ON. Is this log make sense or someone had fixed the problem. If needed, I can supply the detail log and the testcase source file. Version: the latest codes at linus git tree. [ 2140.981293] use_block_rsv: 336 callbacks suppressed [ 2140.981295] ------------[ cut here ]------------ [ 2140.981308]

...1105.179518] [<ffffffffa03456b5>] relocate_tree_blocks+0x124/0x14a [btrfs] [ 1105.179994] [<ffffffffa034624e>] relocate_block_group+0x21a/0x439 [btrfs] [ 1105.180774] [<ffffffffa03465ac>] btrfs_relocate_block_group+0x13f/0x267 [btrfs] [ 1105.181471] [<ffffffffa032b849>] btrfs_relocate_chunk.isra.51+0x4b/0x2ce [btrfs] [ 1105.182037] [<ffffffffa032e532>] btrfs_shrink_device+0x1fa/0x34d [btrfs] [ 1105.182623] [<ffffffffa033011f>] btrfs_rm_device+0x1f4/0x4a6 [btrfs] [ 1105.183206] [<ffffffffa0331ad2>] btrfs_ioctl_rm_dev+0x95/0xbe [btrfs] [ 1105.183797] [<ffffffffa...

...nel: [158311.402485] [<ffffffffa020d58b>] ? relocate_block_group+0x468/0x4eb [btrfs] Nov 18 06:59:46 hsad-srv-03 kernel: [158311.402495] [<ffffffffa020d751>] ? btrfs_relocate_block_group+0x143/0x26a [btrfs] Nov 18 06:59:46 hsad-srv-03 kernel: [158311.402506] [<ffffffffa01ee006>] ? btrfs_relocate_chunk.isra.59+0x59/0x5fb [btrfs] Nov 18 06:59:46 hsad-srv-03 kernel: [158311.402516] [<ffffffffa01fb012>] ? btrfs_set_lock_blocking_rw+0xc9/0xdb [btrfs] Nov 18 06:59:46 hsad-srv-03 kernel: [158311.402523] [<ffffffffa01b1525>] ? btrfs_item_key_to_cpu+0x12/0x30 [btrfs] Nov 18 06:59:46 hsad-srv-...

...] [12451.490698] [<ffffffffa024c2d8>] merge_reloc_roots+0x118/0x150 [btrfs] [12451.490741] [<ffffffffa024c91b>] relocate_block_group+0x3db/0x640 [btrfs] [12451.490784] [<ffffffffa024cd45>] btrfs_relocate_block_group+0x1c5/0x300 [btrfs] [12451.490825] [<ffffffffa02250b5>] btrfs_relocate_chunk.isra.54+0x75/0x730 [btrfs] [12451.490864] [<ffffffffa021b5e1>] ? release_extent_buffer.isra.26+0x81/0xf0 [btrfs] [12451.490904] [<ffffffffa0220b37>] ? free_extent_buffer+0x37/0x90 [btrfs] [12451.490945] [<ffffffffa02294d7>] btrfs_balance+0x8e7/0xe00 [btrfs] [12451.490988] [&lt...

Hello, This patch series adds an initial implementation of restriper (it''s a clever name for relocation framework that allows to do selective profile changing and selective balancing with some goodies like pausing/resuming and reporting progress to the user. Profile changing is global (per-FS) so far, per-subvolume profiles require some discussion and can be implemented in future.

...btrfs_trans_handle *trans, struct btrfs_root *root); int btrfs_end_transaction_throttle(struct btrfs_trans_handle *trans, diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 8d9c42e..b3430cc 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1743,10 +1743,18 @@ static int btrfs_relocate_chunk(struct btrfs_root *root, ret = btrfs_relocate_block_group(extent_root, chunk_offset); BUG_ON(ret); - trans = btrfs_start_transaction(root, 1); - BUG_ON(!trans); + /* + * 2 - for one dev extent plus updating the device item, we''ll have to + * extend the transaction if there are more...

Hi all - The following 9 patches add more error handling to the btrfs code: - Add btrfs_panic - Catch locking failures in {set,clear}_extent_bit - Push up set_extent_bit errors to callers - Push up lock_extent errors to callers - Push up clear_extent_bit errors to callers - Push up unlock_extent errors to callers - Make pin_down_extent return void - Push up btrfs_pin_extent errors to

...ype = BTRFS_CHUNK_ITEM_KEY; ret = btrfs_search_slot(trans, root, &key, path, -1, 1); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); ret = btrfs_del_item(trans, root, path); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); btrfs_free_path(path); return 0; @@ -1774,25 +1774,25 @@ static int btrfs_relocate_chunk(struct btrfs_root *root, for (i = 0; i < map->num_stripes; i++) { ret = btrfs_free_dev_extent(trans, map->stripes[i].dev, map->stripes[i].physical); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); if (map->stripes[i].dev) { ret = btrfs_update_device(trans, map-&...

Hi all - Here''s my current error handling patchset, against 3.1-rc8. Almost all of this patchset is preparing for actual error handling. Before we start in on that work, I''m trying to reduce the surface we need to worry about. It turns out that there is a ton of code that returns an error code but never actually reports an error. The patchset has grown to 65 patches. 46 of them