search for: btrfs_orphan_commit_root

Running an Ubuntu Raring VM which was built a week ago that is now running 3.8-rc6, I was booting it last night when it hung. After a few forced reboots, it came back up and I found the attached in kern.log. Mostly, the VM has been used for testing anisble deployment, so not a lot of work, just upgrading and installing software, then rebooting. Are these reports useful? Is there any

...one? Got this after a crash/reboot: if (block_rsv) { WARN_ON(block_rsv->size > 0); <<<<<<<<<<<<<<<<<<<<<< btrfs_free_block_rsv(root, block_rsv); } ------------[ cut here ]------------ WARNING: at fs/btrfs/inode.c:2165 btrfs_orphan_commit_root+0xcb/0xdf() Hardware name: 2429A78 Modules linked in: tun ppdev cpufreq_userspace cpufreq_stats cpufreq_conservative cpufreq_powersave rfcomm bnep autofs4 pci_stub vboxpci(O) vboxnetadp(O) vboxnetflt(O) vboxdrv(O) binfmt_misc uinput nfsd auth_rpcgss nfs_acl nfs lockd fscache sunrpc fuse configs par...

...ion with Ceph and it looks like after a while with a high rsync workload that the IO stalls for some time, could the warnings result in IO stall? Kind regards, Stefan Kleijkers Output of dmesg: [ 3924.297754] ------------[ cut here ]------------ [ 3924.297772] WARNING: at fs/btrfs/inode.c:2198 btrfs_orphan_commit_root+0xa8/0xc0 [btrfs]() [ 3924.297774] Hardware name: X8ST3 [ 3924.297776] Modules linked in: nfs lockd nfs_acl sunrpc btrfs zlib_deflate lzo_compress md_mod target_core_mod configfs ahci libahci e1000e mptsas mptscsih mptbase i7core_edac scsi_transport_sas bnx2 i5000_edac edac_core ipmi_devintf ipm...

Hi I am hitting this Warning reproducible, the workload is a ceph osd, kernel ist 3.1.0-rc5. Best Regards, martin [ 5472.099766] ------------[ cut here ]------------ [ 5472.099833] WARNING: at fs/btrfs/inode.c:2193 btrfs_orphan_commit_root+0xb0/0xc0 [btrfs]() [ 5472.099838] Hardware name: MS-96B3 [ 5472.099842] Modules linked in: radeon ttm drm_kms_helper drm i2c_algo_bit psmouse sp5100_tco edac_core lp shpchp serio_raw k8temp i2c_piix4 edac_mce_amd parport ahci pata_atiixp e1000e libahci btrfs zlib_deflate libcrc32c [ 5472.099878...

...8 59 70 ff ff 85 c0 [69003.807987] RIP [<ffffffffa015250e>] btrfs_truncate+0x447/0x47c [btrfs] [69003.807987] RSP <ffff880127723d68> [69004.051172] ---[ end trace f6f04441e6b02726 ]--- [69374.600892] ------------[ cut here ]------------ [69374.606357] WARNING: at fs/btrfs/inode.c:2143 btrfs_orphan_commit_root+0x7f/0x9b [btrfs]() [69374.611890] Hardware name: X7SBi-LN4 [69374.617420] Modules linked in: nfs lockd fscache nfs_acl auth_rpcgss sunrpc bonding loop evdev radeon ttm snd_pcm snd_timer drm_kms_helper snd drm i2c_algo_bit i2c_i801 soundcore snd_page_alloc i2c_core i3200_edac e1000e shpchp pci_hotp...

...m> --- fs/btrfs/inode.c | 23 +++++++++++++++++++---- 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 9ae9c2e..9de15f1 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1951,12 +1951,28 @@ enum btrfs_orphan_cleanup_state { void btrfs_orphan_commit_root(struct btrfs_trans_handle *trans, struct btrfs_root *root) { + struct btrfs_block_rsv *block_rsv; int ret; if (!list_empty(&root->orphan_list) || root->orphan_cleanup_state != ORPHAN_CLEANUP_DONE) return; + spin_lock(&root->orphan_lock); + if (!list_empt...

...in. Performance with the current "for-linux-min" branch and big metadata is much better. The only problem (?) I''m still seeing is a warning that seems to occur from time to time: [87703.784552] ------------[ cut here ]------------ [87703.789759] WARNING: at fs/btrfs/inode.c:2103 btrfs_orphan_commit_root+0xf6/0x100 [btrfs]() [87703.799070] Hardware name: ProLiant DL180 G6 [87703.804024] Modules linked in: btrfs zlib_deflate libcrc32c xfs exportfs sunrpc bonding ipv6 sg serio_raw pcspkr iTCO_wdt iTCO_vendor_support i7core_edac edac_core ixgbe dca mdio iomemory_vsl(PO) hpsa squashfs [last unloaded: s...

When adding orphans to an inode''s root, we start a transaction for that root that when ended in several places such as for example extent-tree.c:btrfs_remove_block_group(), inode.c:btrfs_unlink() and inode.c:btrfs_evict_node(), doesn''t result in a commit, that is, inode.c:btrfs_orphan_commit_root() doesn''t get called (via transaction.c:commit_fs_roots()). The respective inode will end up being called by inode.c:btrfs_evict_node() (via the VFS). So my likely dirty hack, after some debugging, of freeing the orphan block rsv in btrfs_evict_inode() if its not being used by other tasks...

...item for the snapshot */ WARN_ON(!root->orphan_item_inserted); ret = btrfs_insert_orphan_item(trans, root->fs_info->tree_root, snap->root_key.objectid); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); snap->orphan_item_inserted = 1; #endif } @@ -2108,7 +2108,7 @@ void btrfs_orphan_commit_root(struct btrfs_trans_handle *trans, btrfs_root_refs(&root->root_item) > 0) { ret = btrfs_del_orphan_item(trans, root->fs_info->tree_root, root->root_key.objectid); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); root->orphan_item_inserted = 0; } @@ -2177,...

Hi all - Here''s my current error handling patchset, against 3.1-rc8. Almost all of this patchset is preparing for actual error handling. Before we start in on that work, I''m trying to reduce the surface we need to worry about. It turns out that there is a ton of code that returns an error code but never actually reports an error. The patchset has grown to 65 patches. 46 of them