Displaying 1 result from an estimated 1 matches for "btrfs_mount_xxxx_opt".
2012 Sep 18
3
R: [PATCH 2/2] Btrfs-progs: add mount-option command
...p;= ~BTRFS_MOUNT_##opt)
>+#define btrfs_set_opt(o, opt) ((o) |= BTRFS_MOUNT_##opt)
>+#define btrfs_test_opt(root, opt) ((root)->fs_info->mount_opt& \
>+ BTRFS_MOUNT_##opt)
I think that the macro names are too generic, I suggest to rename the three
macros above as
#define btrfs_mount_XXXX_opt
Also, the last one should be
#define btrfs_test_opt(o, opt) ( o & BTRFS_MOUNT_##opt)
Or better the other two
#define btrfs_mount_clear_opt(root, opt) (((root)->fs_info->mount_opt) &=
~BTRFS_MOUNT_##opt)
#define btrfs_mount_set_opt(root, opt) (((root)->fs_info->mount_opt)...