search for: btrfs_ioctl_snap_cr

Hi everyone, This patchset is the latest approach I''m using for the Ceph storage daemon to keep track of which data has safely committed to disk. The basic idea is to not use the (problematic) user transaction ioctls at all. Instead, the daemon quiesces its own write requests, initiates an async snapshot, and then continues. The snapshot approach is nice because it provides rollback.

...trfs] [36700.671729] [<ffffffffa05a4dde>] btrfs_commit_transaction+0x4fe/0xa10 [btrfs] [36700.671735] [<ffffffffa0610af3>] create_subvol+0x5c0/0x636 [btrfs] [36700.671742] [<ffffffffa05d49ff>] btrfs_mksubvol.isra.60+0x33f/0x3f0 [btrfs] [36700.671747] [<ffffffffa05d4bf2>] btrfs_ioctl_snap_create_transid+0x142/0x190 [btrfs] [36700.671752] [<ffffffffa05d4c6c>] ? btrfs_ioctl_snap_create+0x2c/0x80 [btrfs] [36700.671757] [<ffffffffa05d4c9e>] btrfs_ioctl_snap_create+0x5e/0x80 [btrfs] [36700.671759] [<ffffffff8113a764>] ? handle_pte_fault+0x84/0x920 [36700.671764] [<f...

Hi Chris, This is the extent of my current queue of Btrfs snapshot/subvol/commit stuff. Most of these were posted several months ago. Can be sent upstream during this merge window? Not having this functionality is becoming a bit of a roadblock for our efforts to keep the Ceph data in a consistent state. These patches are also available from

Hello I think strlen is unsafe here Regards YZ diff -r 24c661119092 inode.c --- a/inode.c Mon Sep 17 11:25:58 2007 -0400 +++ b/inode.c Thu Sep 20 22:25:34 2007 +0800 @@ -1985,7 +1988,7 @@ static int btrfs_ioctl_snap_create(struc if (copy_from_user(&vol_args, arg, sizeof(vol_args))) return -EFAULT; - namelen = strlen(vol_args.name); + namelen = strnlen(vol_args.name, BTRFS_VOL_NAME_MAX + 1); if (namelen > BTRFS_VOL_NAME_MAX) return -EINVAL; if (strchr(vol_args.name, '/'))

...t_flags); + up_write(&root->fs_info->subvol_sem); +out_drop_write: + mnt_drop_write_file(file); +out: + return ret; +} + static noinline int btrfs_ioctl_subvol_getflags(struct file *file, void __user *arg) { @@ -4509,6 +4571,8 @@ long btrfs_ioctl(struct file *file, unsi return btrfs_ioctl_snap_create(file, argp, 1); case BTRFS_IOC_SUBVOL_CREATE_V2: return btrfs_ioctl_snap_create_v2(file, argp, 1); + case BTRFS_IOC_SUBVOL_MODIFY: + return btrfs_ioctl_subvol_modify(file, argp); case BTRFS_IOC_SNAP_DESTROY: return btrfs_ioctl_snap_destroy(file, argp); case BTRFS_IOC_SUBVOL_GETFLAG...

...__user *arg) goto out; } - vol_args->name[BTRFS_PATH_NAME_MAX] = ''\0''; + vol_args->name[BTRFS_VOL_NAME_MAX] = ''\0''; namelen = strlen(vol_args->name); mutex_lock(&root->fs_info->volume_mutex); @@ -576,7 +576,7 @@ static noinline int btrfs_ioctl_snap_create(struct file *file, goto out; } - vol_args->name[BTRFS_PATH_NAME_MAX] = ''\0''; + vol_args->name[BTRFS_VOL_NAME_MAX] = ''\0''; namelen = strlen(vol_args->name); if (strchr(vol_args->name, ''/'')) { ret = -EINVAL; @@ -685,7...

The freeze rwsem is taken by sb_start_intwrite() and dropped during the commit_ or end_transaction(). In the async case, that happens in a worker thread. Tell lockdep the calling thread is releasing ownership of the rwsem and the async thread is picking it up. Josef and I worked out a more complicated solution that made the async commit thread join and potentially get a later transaction, but

Hello On my HP Compaq dc5800 with Ubuntu 13.04 and their 3.8.0-19-lowlatency kernel, I''ve got quite some kernel traces in the syslog. You can find them below or at http://pastebin.com/bLXPBX67 (to avoid line breaks…). These kernel traces all begin with: WARNING: at fs/btrfs/free-space-cache.c:921 __btrfs_write_out_cache+0x6b9/0x9a0 [btrfs]() Most of the time, it starts with: Call

This is a first draft of a subvolume quota implementation. It is possible to limit subvolumes and any group of subvolumes and also to track the amount of space that will get freed when deleting snapshots. The current version is functionally incomplete, with the main missing feature being the initial scan and rescan of an existing filesystem. I put some effort into writing an introduction into