search for: btrfs_fsck

Hi, This series fix two bad commit ids referenced in commit messages, by first reverting the two commits and then re-applying them with correct commit ids referenced. No big problem, but for clarity. Hu Tao (4): Revert "Update gobject/Makefile.inc and POTFILES" Revert "Update gobject/Makefile.inc and POTFILES" Update gobject/Makefile.inc and POTFILES Update

...| 2 +- 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index ab3babc..62f07f3 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -619,3 +619,20 @@ do_btrfs_set_seeding (const char *device, int svalue) free (err); return r; } + +int +do_btrfs_fsck (const char *device) +{ + char *err; + int r; + + r = commandr (NULL, &err, "btrfsck", device, NULL); + if (r == -1) { + reply_with_error ("%s: %s", device, err); + free (err); + return -1; + } + + free (err); + return r; +} diff --git a/generator/generator_a...

...n 0; > > > +} > > > > We do have already a "fsck" action; OTOH fsck.btrfs does nothing, so > > I would rather call `btrfs check` there, instead of adding a new > > btrfs-specific API. > > Let's make our fsck useful on btrfs :) > > I found btrfs_fsck has been already implemented. Do you mean we should > extend btrfs to support btrfs? I guess you mean "... extend fsck to support btrfs", right? :) That could be an idea, but given that "btrfs check" may usually need additional parameter, then it might not be worth it. --...

...args-add_drive_scratch.h \ include/guestfs-gobject/optargs-add_libvirt_dom.h \ + include/guestfs-gobject/optargs-aug_transform.h \ include/guestfs-gobject/optargs-btrfs_filesystem_defragment.h \ include/guestfs-gobject/optargs-btrfs_filesystem_resize.h \ include/guestfs-gobject/optargs-btrfs_fsck.h \ @@ -143,6 +144,7 @@ guestfs_gobject_sources= \ src/optargs-add_drive.c \ src/optargs-add_drive_scratch.c \ src/optargs-add_libvirt_dom.c \ + src/optargs-aug_transform.c \ src/optargs-btrfs_filesystem_defragment.c \ src/optargs-btrfs_filesystem_resize.c \ src/optargs-btrfs_fsc...

In data venerdì 26 dicembre 2014 16:17:46, Hu Tao ha scritto: > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > daemon/btrfs.c | 24 ++++++++++++++++++++++++ > generator/actions.ml | 14 ++++++++++++++ > src/MAX_PROC_NR | 2 +- > 3 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/daemon/btrfs.c b/daemon/btrfs.c > index

...akefile.inc b/gobject/Makefile.inc index 7a60933..3129275 100644 --- a/gobject/Makefile.inc +++ b/gobject/Makefile.inc @@ -65,7 +65,8 @@ guestfs_gobject_headers= \ include/guestfs-gobject/optargs-mkfs_btrfs.h \ include/guestfs-gobject/optargs-set_e2attrs.h \ include/guestfs-gobject/optargs-btrfs_fsck.h \ - include/guestfs-gobject/optargs-fstrim.h + include/guestfs-gobject/optargs-fstrim.h \ + include/guestfs-gobject/optargs-xfs_growfs.h guestfs_gobject_sources= \ src/session.c \ @@ -112,4 +113,5 @@ guestfs_gobject_sources= \ src/optargs-mkfs_btrfs.c \ src/optargs-set_e2attrs.c \...

These assorted patches end up with adding virtio-scsi support to libguestfs. It passes libguestfs-test-tool, but I haven't yet tried to run the full set of tests. In theory > 26 devices can be added, but it's likely that certain parts of the daemon will break if you actually try this. This of course needs to be fixed. Thanks Paolo Bonzini for invaluable help. Rich.

...> + } > > + > > + return 0; > > +} > > We do have already a "fsck" action; OTOH fsck.btrfs does nothing, so > I would rather call `btrfs check` there, instead of adding a new > btrfs-specific API. > Let's make our fsck useful on btrfs :) I found btrfs_fsck has been already implemented. Do you mean we should extend btrfs to support btrfs? Regards, Hu > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index b44ce1c..c328319 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -1...

This is only lightly tested at the moment. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Note this is not a complete fix. At least one more libguestfs patch is required (to implement virDomainPtr in the python bindings). Plus a virt-manager patch. Rich.

More comprehensive support for virtio-scsi. Passes all the tests. Rich.

Although the commit message ties this to https://bugzilla.redhat.com/1804207, in fact I believe this commit could be applied independently. It's a simple optimization. Rich.

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

An experimental series that adds support for rsync. Rich.

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

Hi, This series adds new APIs to support btrfs scrub, balance, rescue and inspect. Some of them don't have tests because: - btrfs_scrub and btrfs_balance completes too early before we can test btrfs_scrub_cancel, btrfs_scrub_resume, btrfs_scrub_status, btrfs_balance_pause, btrfs_balance_cancel, btrfs_balance_resume and btrfs_balance_status. - can't

...mds.c +fish/cmds_gperf.c fish/completion.c fish/config.c fish/copy.c @@ -135,6 +137,7 @@ format/format.c fuse/guestmount.c gobject/src/optargs-add_domain.c gobject/src/optargs-add_drive.c +gobject/src/optargs-add_drive_opts.c gobject/src/optargs-btrfs_filesystem_resize.c gobject/src/optargs-btrfs_fsck.c gobject/src/optargs-compress_device_out.c @@ -150,12 +153,15 @@ gobject/src/optargs-internal_test.c gobject/src/optargs-md_create.c gobject/src/optargs-mkfs.c gobject/src/optargs-mkfs_btrfs.c +gobject/src/optargs-mkfs_opts.c gobject/src/optargs-mount_9p.c gobject/src/optargs-mount_local.c...

Add xfs_info to show the geometry of the xfs filesystem. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- Hi Rich, I got an odd error, can you help me with this error or give me a debug method? Thanks, Wanlong Gao daemon/Makefile.am | 1 + daemon/xfs.c | 278 +++++++++++++++++++++++++++++++ generator/generator_actions.ml

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.