search for: btrfs_alloc_logged_file_extent

The memory allocation failure is BUG_ON in add_excluded_extent (following the code path). No need to BUG_ON -ENOMEM inside btrfs_alloc_logged_file_extent. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/btrfs/extent-tree.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 95492cc..9b9a6fa 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c...

...: CPU 1 Feb 02 13:59:58 Edge systemd[1]: home.mount mount process exited, code=killed status=11 Feb 02 13:59:58 Edge kernel: Pid: 314, comm: mount Tainted: G C 3.7.5-1-ARCH #1 LENOVO 129886G/129886G Feb 02 13:59:58 Edge kernel: RIP: 0010:[<ffffffffa024e0a7>] [<ffffffffa024e0a7>] btrfs_alloc_logged_file_extent+0x1c7/0x1e0 [btrfs] Feb 02 13:59:58 Edge kernel: RSP: 0018:ffff880138b53758 EFLAGS: 00010286 Feb 02 13:59:58 Edge kernel: RAX: 00000000fffffff5 RBX: ffff880135bc4200 RCX: 000000000001a7c0 Feb 02 13:59:58 Edge kernel: RDX: ffffea0004dea100 RSI: 0000000000000002 RDI: ffff880138bdd840 Feb 02 13:59:58...

Hi all, It seems like memory barrier is not required in cached_block_group.I am looking at kernel 2.6.34-rc2. cache_block_group(struct btrfs_block_group_cache *cache) { smp_mb(); if (cache->cached != BTRFS_CACHE_NO) return 0; .... } This function is called from btrfs_alloc_logged_file_extent and find_free_extent. In btrfs_alloc_logged_file_extent the code snippet is as follows block_group = btrfs_lookup_block_group(root->fs_info, ins->objectid); cache_block_group(block_group); btrfs_lookup_block_group releases a spin_lock at the end so the writes in spin_lock cannot get out....

...path_common+0x7f/0xc0 [ 37.645662] [<ffffffff8105162a>] warn_slowpath_null+0x1a/0x20 [ 37.645670] [<ffffffffa0f4a159>] btrfs_remove_free_space+0x329/0x350 [btrfs] [ 37.645674] [<ffffffff81073bb0>] ? abort_exclusive_wait+0xb0/0xb0 [ 37.645682] [<ffffffffa0efaa6f>] btrfs_alloc_logged_file_extent+0x1bf/0x1e0 [btrfs] [ 37.645688] [<ffffffffa0ee7bfa>] ? btrfs_free_path+0x2a/0x40 [btrfs] [ 37.645697] [<ffffffffa0f44c5e>] replay_one_extent+0x5be/0x620 [btrfs] [ 37.645701] [<ffffffff81179f55>] ? iput+0x105/0x210 [ 37.645710] [<ffffffffa0f4549b>] replay_one_buf...

...rd_extent(root, start, len, NULL); btrfs_add_free_space(cache, start, len); - btrfs_update_reserved_bytes(cache, len, 0, 1); + btrfs_update_reserved_bytes(cache, len, RESERVE_FREE); btrfs_put_block_group(cache); trace_btrfs_reserved_extent_free(root, start, len); @@ -5607,7 +5620,8 @@ int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, put_caching_control(caching_ctl); } - ret = btrfs_update_reserved_bytes(block_group, ins->offset, 1, 1); + ret = btrfs_update_reserved_bytes(block_group, ins->offset, + RESERVE_LOG); BUG_ON(ret); btrfs_put_block_group(block_group); ret = al...

...rd_extent(root, start, len, NULL); btrfs_add_free_space(cache, start, len); - btrfs_update_reserved_bytes(cache, len, 0, 1); + btrfs_update_reserved_bytes(cache, len, RESERVE_FREE); btrfs_put_block_group(cache); trace_btrfs_reserved_extent_free(root, start, len); @@ -5607,7 +5619,8 @@ int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, put_caching_control(caching_ctl); } - ret = btrfs_update_reserved_bytes(block_group, ins->offset, 1, 1); + ret = btrfs_update_reserved_bytes(block_group, ins->offset, + RESERVE_LOG); BUG_ON(ret); btrfs_put_block_group(block_group); ret = al...

...ns_handle *trans, path->leave_spinning = 1; ret = btrfs_insert_empty_item(trans, fs_info->extent_root, path, ins, size); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); leaf = path->nodes[0]; extent_item = btrfs_item_ptr(leaf, path->slots[0], @@ -5225,28 +5225,28 @@ int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, if (!caching_ctl) { BUG_ON(!block_group_cache_done(block_group)); ret = btrfs_remove_free_space(block_group, start, num_bytes); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); } else { mutex_lock(&caching_ctl->mutex); if (start >= caching_...

...: Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01ff633>] btrfs_remove_free_space+0x53/0x280 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffff8107dbd0>] ? finish_wait+0x80/0x80 Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01b1e97>] btrfs_alloc_logged_file_extent+0x1b7/0x1d0 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01f9bd0>] replay_one_extent+0x620/0x690 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956] [<ffffffffa01fa92b>] replay_one_buffer+0x2ab/0x350 [btrfs] Feb 1 22:57:37 localhost kernel: [ 8561.602956]...

...050 ffff8801e8aae4a0 ffff8801cf424d00 0000000000000000 [ 316.548267] ffff8801d3d162c0 ffff8801cfde7943 0000000000000000 ffffffffa01af105 [ 316.548363] Call Trace: [ 316.548429] [<ffffffffa01af105>] ? btrfs_remove_free_space+0x24c/0x276 [btrfs] [ 316.548540] [<ffffffffa0170d2f>] ? btrfs_alloc_logged_file_extent+0x86/0x18d [btrfs] [ 316.548658] [<ffffffffa01aa42a>] ? replay_one_extent+0x2fa/0x43e [btrfs] [ 316.548742] [<ffffffff8109b605>] ? __call_rcu+0x5d/0x16e [ 316.548835] [<ffffffffa01ab873>] ? replay_one_buffer+0x1cf/0x22b [btrfs] [ 316.548938] [<ffffffffa01aa704>] ? wa...

Hi all - Here''s my current error handling patchset, against 3.1-rc8. Almost all of this patchset is preparing for actual error handling. Before we start in on that work, I''m trying to reduce the surface we need to worry about. It turns out that there is a ton of code that returns an error code but never actually reports an error. The patchset has grown to 65 patches. 46 of them