search for: brouer

...formation through XDP_REDIRECT to another driver. - XDP does not support checksum offload right now. So simply disable guest csum if possible in this the case of XDP. Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set") Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Pavel Popa <pashinho1990 at gmail.com> Cc: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 ++------ 1 file changed, 2 i...

...formation through XDP_REDIRECT to another driver. - XDP does not support checksum offload right now. So simply disable guest csum if possible in this the case of XDP. Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set") Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Pavel Popa <pashinho1990 at gmail.com> Cc: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 ++------ 1 file changed, 2 i...

...vice open/close functions. Driver hook points for xdp_rxq_info: * reg : virtnet_open * unreg: virtnet_close Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: virtualization at lists.linux-foundation.org Signed-off-by: Jesper Dangaard Brouer <brouer at redhat.com> --- drivers/net/virtio_net.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 6fb7b658a6cc..6d45d687ec6a 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@...

...d_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header and there's no way for XDP to know the existence of the vnet header currently. So let's just not reserve space for vnet header in this case. Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 11f722460513..98dd75b665a5 100644 --- a/drivers/net...

...d_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header and there's no way for XDP to know the existence of the vnet header currently. So let's just not reserve space for vnet header in this case. Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 11f722460513..98dd75b665a5 100644 --- a/drivers/net...

On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 11:19:03 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> This series tries to re-enable XDP_REDIRECT for mergeable buffer which >> was removed since commit 7324f5399b06 ("virtio_net: disable >> XDP_REDIRECT in receive_mergea...

On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 11:19:03 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> This series tries to re-enable XDP_REDIRECT for mergeable buffer which >> was removed since commit 7324f5399b06 ("virtio_net: disable >> XDP_REDIRECT in receive_mergea...

On 2018?03?01? 18:35, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 17:23:37 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: >>> On Thu, 1 Mar 2018 11:19:03 +0800 >>> Jason Wang <jasowang at redhat.com> wrote: >>> >&gt...

On 2018?03?01? 18:35, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 17:23:37 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: >>> On Thu, 1 Mar 2018 11:19:03 +0800 >>> Jason Wang <jasowang at redhat.com> wrote: >>> >&gt...

...atch: 24.4 Gbits/sec > > netperf (TCP_RR): > * With the patch: 47963.25 trans/s, 20.71us mean latency > * Without the patch: 45796.70 trans/s, 21.68us mean latency > > Signed-off-by: Tonghao Zhang <zhangtonghao at didichuxing.com> -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer

On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote: > We should not exclude headroom and tailroom when XDP is set. So this > patch fixes this by initializing the truesize from PAGE_SIZE when XDP > is set. > > Cc: Jesper Dangaard Brouer <brouer at redhat.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> Seems too aggressive, we do not use up the whole page for the size. > --- > drivers/net/virtio_net.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers...

On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote: > We should not exclude headroom and tailroom when XDP is set. So this > patch fixes this by initializing the truesize from PAGE_SIZE when XDP > is set. > > Cc: Jesper Dangaard Brouer <brouer at redhat.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> Seems too aggressive, we do not use up the whole page for the size. > --- > drivers/net/virtio_net.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers...

...> skb_shared_info which breaks XDP assumption. Other complaints are, the > complex linearize logic and EWMA estimation may increase the > possibility of linearizing. This patch also have the intermixing issues, I mentioned for patch 2/2. On Thu, 1 Mar 2018 09:02:06 +0100 Jesper Dangaard Brouer <brouer at redhat.com> wrote: > 1. XDP generic is not feature complete, e.g. cpumap will drop these > packets. It might not be possible to implement some features, think > of (AF_XDP) zero-copy. > > 2. This can easily cause out-of-order packets. > > 3. It makes i...

...XDP assumption. So this patch fixes this > by reserving enough tailroom and using fixed size of rx buffer. > > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > Changes from V1: > - do not add duplicated tracepoint when redirection fails Acked-by: Jesper Dangaard Brouer <brouer at redhat.com> I gave it a quick spin on my testlab, and cpumap seems to work/not-crash now (if I managed to turn back config to receive_mergeable() correctly ;-)). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linke...

We don't support partial csumed packet since its metadata will be lost or incorrect during XDP processing. So fail the XDP set if guest_csum feature is negotiated. Fixes: f600b6905015 ("virtio_net: Add XDP support") Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Pavel Popa <pashinho1990 at gmail.com> Cc: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 5 +++-- 1 file changed, 3 inse...

...CT to another driver. > - XDP does not support checksum offload right now. > > So simply disable guest csum if possible in this the case of XDP. > > Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set") > Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> > Cc: Jesper Dangaard Brouer <brouer at redhat.com> > Cc: Pavel Popa <pashinho1990 at gmail.com> > Cc: David Ahern <dsahern at gmail.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> Applied and queued up for -stable. We rea...

On 2020/5/6 ??4:21, Jesper Dangaard Brouer wrote: > On Wed, 6 May 2020 14:16:32 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> We tried to reserve space for vnet header before >> xdp.data_hard_start. But this is useless since the packet could be >> modified by XDP which may invalidate the informati...

On 2020/5/6 ??4:21, Jesper Dangaard Brouer wrote: > On Wed, 6 May 2020 14:16:32 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> We tried to reserve space for vnet header before >> xdp.data_hard_start. But this is useless since the packet could be >> modified by XDP which may invalidate the informati...

...e too (RTM_{ADD,DEL}MDB). (Thanks to Thomas for patient reviews) Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <shemminger at vyatta.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: Thomas Graf <tgraf at suug.ch> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Cong Wang <amwang at redhat.com> --- include/uapi/linux/if_bridge.h | 55 ++++++++++++++ include/uapi/linux/rtnetlink.h | 3 + net/bridge/Makefile | 2 +- net/bridge/br_mdb.c | 163 +++++++++++++++++++++++++++++++...

On Thu, 1 Mar 2018 21:15:36 +0800 Jason Wang <jasowang at redhat.com> wrote: > On 2018?03?01? 18:35, Jesper Dangaard Brouer wrote: > > On Thu, 1 Mar 2018 17:23:37 +0800 > > Jason Wang <jasowang at redhat.com> wrote: > > > >> On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: > >>> On Thu, 1 Mar 2018 11:19:03 +0800 > >>> Jason Wang <jasowang at redhat.com&...