search for: brelse

...=================================== --- fs/ocfs2/super.c (revision 128) +++ fs/ocfs2/super.c (working copy) @@ -1203,6 +1203,12 @@ static int ocfs2_get_sector(struct super unlock_buffer(*bh); ll_rw_block(READ, 1, bh); wait_on_buffer(*bh); + if (!buffer_uptodate(*bh)) { + mlog_errno(-EIO); + brelse(*bh); + return -EIO; + } + return 0; }

hm, this backtrace actually has info... btw, I think we need this: --- 25/fs/ext3/namei.c~ext3-brelse-fix Sun Dec 29 06:53:39 2002 +++ 25-akpm/fs/ext3/namei.c Sun Dec 29 06:53:54 2002 @@ -576,8 +576,10 @@ int ext3_htree_fill_tree(struct file *di (hinfo.minor_hash < start_minor_hash))) continue; if ((err = ext3_htree_store_dirent(dir_file, - hinfo.hash, hinfo.minor_hash, d...

In ocfs2_find_entry_dx(), if ocfs2_read_inode_block() failed, both di_bh and dx_root_bh are both released. In this case, for dx_root_bh, it's unnecessary (even buggy if refcount of dx_root_bh is non-zero). This patch fixes this issue by change brelse order of di_bh and dx_root_bh. Signed-off-by: Coly Li <coly.li at suse.de> --- fs/ocfs2/dir.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 28c3ec2..05aa238 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1048,7 +1048...

I just booted 2.5-bk current as of last night with the below patch¹ (which was recently posted to ext3-users) that un-static-ifies a struct dx_frame in namei.c. I then did my best torture test for the brelse bug: starting gnus (3600+ nnmh folders² with a total of XXX messages; it does a readdir on each of those folders) while doing bk consistancy checks in 2.5 and/or 2.4 kernel trees. All while fetchmail+procmail+spamd processes a stream of incoming mail. That load had never failed to generate a bre...

...x went in. There is a single ext3 partition on the machine, and it generally doesn't do very much at all, especially not disk intensive stuff. Please let me know if I can provide any more assistance in finding the source of the problem, or resolving it. Dec 11 04:03:55 fendrian kernel: VFS: brelse: Trying to free free buffer Dec 11 04:03:55 fendrian kernel: buffer layer error at fs/buffer.c:1279 Dec 11 04:03:55 fendrian kernel: Call Trace: Dec 11 04:03:56 fendrian kernel: [__brelse+41/48] __brelse+0x29/0x30 Dec 11 04:03:56 fendrian kernel: [bh_lru_install+124/176] bh_lru_install+0x7c/0xb0...

...> -----Original Message----- > From: Daniel Phillips [mailto:phillips@arcor.de] > Sent: Wednesday, March 05, 2003 12:25 AM > To: James H. Cloos Jr.; ext2-devel@lists.sourceforge.net > Cc: ext3-users@redhat.com; linux-kernel@vger.kernel.org > Subject: [Ext2-devel] Re: ext3 htree brelse problems look to be fixed! > > > On Wed 05 Mar 03 00:57, James H. Cloos Jr. wrote: > > I beleive (with this patch) htree is now ready for prime time. > > Good that it's working for you, but it's not quite the last > issue. There is > some apparent cache thra...

Hello, When drop_progress isn't zero, the root->node's usage count is increased in btrfs_search_slot. Therefore, the get_bh in the body of while loop is redundant in most cases. (this change is in accordance with btrfs_defrag_leaves). The second change is decrease root->node's usage count when drop a snapshot. Regards YZ diff -r 29b8cc7794ac extent-tree.c --- a/extent-tree.c

...1]; - struct buffer_head *orphan_entry_bh = NULL; struct buffer_head *newfe_bh = NULL; struct buffer_head *old_inode_bh = NULL; - struct buffer_head *insert_entry_bh = NULL; struct ocfs2_super *osb = NULL; u64 newfe_blkno, old_de_ino; handle_t *handle = NULL; @@ -1455,8 +1453,6 @@ bail: brelse(old_inode_bh); brelse(old_dir_bh); brelse(new_dir_bh); - brelse(orphan_entry_bh); - brelse(insert_entry_bh); mlog_exit(status); -- 1.5.5

When the extended attribute namespace grows to a b-tree, the leaf clusters are organized by means of 'buckets'. Each bucket is 4K in size, regardless of blocksize. Thus, a bucket may be made of more than one block. fs/ocfs2/xattr.c has a nice little abstraction to wrap this, struct ocfs2_xattr_bucket. It contains a list of buffer_heads representing these blocks, and there is even an

The following patches implement indexed directory support in Ocfs2, mostly according to the design doc I wrote up a while ago: http://oss.oracle.com/osswiki/OCFS2/DesignDocs/IndexedDirectories The patches have been rebased on top of 2.6.29-rc2. It should be trivial to put them into merge_window. Things are what I'd call complete now. I'd like to get these into the merge_window branch

Can anyone tell me the history of CONFIG_EXT{2,3}_CHECK? There is code for a "check" option for mount if these options are enabled, but there's no way to enable them. TIA Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said.

I've backported all of the bugfixes to the 2.5 dxdir/htree patches to 2.4, and have created a new set of patches for Linux 2.4.21rc5. At this point it *looks* like we've fixed all of the htree bugs that people have reported, including the brelse bug, the memory leak bugs, and the NFS compatibility problems. I've done *very* light testing, and things seem to work, but I'm now looking for some brave souls/guinea pigs to give this some more strenous testing. Please don't use this on production systems just yet, until some people...

...1]; - struct buffer_head *orphan_entry_bh = NULL; struct buffer_head *newfe_bh = NULL; struct buffer_head *old_inode_bh = NULL; - struct buffer_head *insert_entry_bh = NULL; struct ocfs2_super *osb = NULL; u64 newfe_blkno, old_de_ino; handle_t *handle = NULL; @@ -1455,8 +1453,6 @@ bail: brelse(old_inode_bh); brelse(old_dir_bh); brelse(new_dir_bh); - brelse(orphan_entry_bh); - brelse(insert_entry_bh); mlog_exit(status); diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index b4ca591..8439f6b 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c @@ -2197,26 +2197,29 @@...

Hi, now that Ingo+redhat have discovered the cause of the ext2 corruption under heavy load of 2.4.x a couple of -preX patches ago (BTW ext2/3 gurus - what is the difference between bforget() and brelse() - I'm a bit too dense to understand the explanation given in the -pre patch?) I wonder whether you folks are still finding heavy load corruption problems for 2.4? [My production servers are running ext3(6b)+2.2.19.] Of course the real reason for asking is...are the showstoppers to fielding...

Hi, The following patches comprise the bulk of Ocfs2 updates for the 2.6.30 merge window. Aside from larger, more involved fixes, we're adding the following features, which I will describe in the order their patches are mailed. Sunil's exported some more state to our debugfs files, and consolidated some other aspects of our debugfs infrastructure. This will further aid us in debugging

...f->f_bfree; buf->f_files = numbits; buf->f_ffree = freebits; + buf->f_fsid.val[0] = crc32_le(0, osb->uuid_str, OCFS2_VOL_UUID_LEN) + & 0xFFFFFFFFUL; + buf->f_fsid.val[1] = crc32_le(0, osb->uuid_str + OCFS2_VOL_UUID_LEN, + OCFS2_VOL_UUID_LEN) & 0xFFFFFFFFUL; brelse(bh); -- Coly Li SuSE Labs

...fs/ocfs2/super.c @@ -1425,6 +1425,8 @@ static int ocfs2_statfs(struct dentry *dentry, struct kstatfs *buf) buf->f_bavail = buf->f_bfree; buf->f_files = numbits; buf->f_ffree = freebits; + buf->f_fsid.val[0] = osb->uuid_hash & 0xFFFFFFFFUL; + buf->f_fsid.val[1] = 0; brelse(bh); -- Coly Li SuSE Labs

...super *osb, goto out; } - offset = 0; - iter = NULL; - while(offset < i_size_read(orphan_dir_inode)) { - blk = offset >> sb->s_blocksize_bits; - - bh = ocfs2_bread(orphan_dir_inode, blk, &status, 0); - if (!bh) - status = -EINVAL; - if (status < 0) { - if (bh) - brelse(bh); - mlog_errno(status); - goto out_unlock; - } - - local = 0; - while(offset < i_size_read(orphan_dir_inode) - && local < sb->s_blocksize) { - de = (struct ocfs2_dir_entry *) (bh->b_data + local); - - if (!ocfs2_check_dir_entry(orphan_dir_inode, - de,...

...2003 @@ -20,6 +20,7 @@ #include <linux/module.h> #include <linux/string.h> #include <linux/slab.h> +#include <linux/vmalloc.h> #include <linux/init.h> #include <linux/blkdev.h> #include <linux/parser.h> @@ -145,7 +146,7 @@ kfree(sbi->s_debts); brelse (sbi->s_sbh); sb->s_fs_info = NULL; - kfree(sbi); + vfree(sbi); return; } @@ -571,7 +572,7 @@ int db_count; int i, j; - sbi = kmalloc(sizeof(*sbi), GFP_KERNEL); + sbi = vmalloc(sizeof(*sbi)); if (!sbi) return -ENOMEM; sb->s_fs_info = sbi; diff -Nru a/fs/ext3/super.c b/f...

Hi all, So I have finally finished the v3 of reflink for ocfs2. The biggest change is that we support 64bit cluster offset now(Thank Mark and Joel for it). [View] http://oss.oracle.com/git/?p=tma/linux-2.6.git;a=shortlog;h=refcount [Pull] git://oss.oracle.com/git/tma/linux-2.6.git refcount The general information for reflink, please see http://oss.oracle.com/osswiki/OCFS2/DesignDocs/Reflink.