search for: boolean_arguments_can_be_evil

On 06/01/2011 07:28, Duncan Sands wrote: > how about both? Patches welcome! Sorry, disregard the previous patch. Correct patch is attached. Yuri -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.txt URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110602/a49ab41c/attachment.txt>

A minor point: Make that function parameter an enum instead of a boolean. That would make it possible to extend the function so it returns other information without potentially breaking client code (which might pass in 1 or -1 or something entirely different to get repository information). Just my 2c. Regards, Jo