search for: boiler

Hi, I'm planning to replace a back boiler (which is at least 15 years old) with a combi boiler. Assuming that the rest of the system is the same age, is it sufficient to flush the existing radiators and pipes, or is it better to replace the radiators and pipework as well?

...AL; > + goto out_cleanup_queue; > + } > blk_queue_logical_block_size(q, blk_size); Hmm, I wonder if we should simply add the check and warning to blk_queue_logical_block_size and add an error in that case. Then drivers only have to check the error return, which might add a lot less boiler plate code.

...AL; > + goto out_cleanup_queue; > + } > blk_queue_logical_block_size(q, blk_size); Hmm, I wonder if we should simply add the check and warning to blk_queue_logical_block_size and add an error in that case. Then drivers only have to check the error return, which might add a lot less boiler plate code.

...nderlying objects, then you might as well set them up yourself and set up all the hooks, it's just a few more lines of code. Imo for simple pipe we should go more into that direction, not less. > I admit that not all are as shareable as prepare_fb() and enable_fb(). > But what else than boiler-plate wrappers do we get from simple display > pipe here? Boiler plate wrappers is pretty much the entire point of simple pipe helpers. Anytime you're interested in the things it abstracts away (crtc, plane, encoder) you probably want your own atomic implementation. That's why I don'...

...nderlying objects, then you might as well set them up yourself and set up all the hooks, it's just a few more lines of code. Imo for simple pipe we should go more into that direction, not less. > I admit that not all are as shareable as prepare_fb() and enable_fb(). > But what else than boiler-plate wrappers do we get from simple display > pipe here? Boiler plate wrappers is pretty much the entire point of simple pipe helpers. Anytime you're interested in the things it abstracts away (crtc, plane, encoder) you probably want your own atomic implementation. That's why I don'...

...might as well set them up yourself and set up all > the hooks, it's just a few more lines of code. > > Imo for simple pipe we should go more into that direction, not less. > >> I admit that not all are as shareable as prepare_fb() and enable_fb(). >> But what else than boiler-plate wrappers do we get from simple display >> pipe here? > > Boiler plate wrappers is pretty much the entire point of simple pipe > helpers. Anytime you're interested in the things it abstracts away > (crtc, plane, encoder) you probably want your own atomic > implementat...

I remember this being discussed, and may have even supported it, but I'm looking at cleaning up some of how the target transform info works, and it would be a lot less duplicate boiler-plate code to only have one. Having a narrower interface doesn't seem to make a lot of sense in this case because for the users, there is no real cost, and for the implementors, they always have to implement both and do so in the same location. If not shout out with a compelling reason why th...

...nit: Have we simplified the interface for devm_memremap_pages() at this point, or are you talking about later patches in this series. I checked this and all the called functions are exported symbols, so there is no blocker for a future driver to call devm_memremap_pages(), maybe even with all this boiler plate, in future. If we eventually get many users that need some simplified registration then we should add a devm_memremap_pages_simplified() interface and factor out that code when we can see the pattern. Reviewed-by: Jason Gunthorpe <jgg at mellanox.com> Jason

...TwoAskCustomer class EightTwoAskCustomer < Customer def bill #take all their money end end A controller: class TestController < ApplicationController def bill c = Customer.find params[:id] c.bill render :nothing => true end end A functional test: [snip boiler plate] require ''eight_two_ask_customer'' class EightTwoAskCustomer include Mocha::ExpectationLoader end [snip more boiler plate] # Replace this with your real tests. def test_bill_customer c = customers(:customer1) EightTwoAskCustomer.any_instance_with_id( c.id...

...erstand needing IR-level analysis for some kinds of transformations, but late IR-level passes can insert target-specific intrinsics, those can be matched to pseudo instructions, and those pseudo instructions can be expanded (as late as necessary) by a custom inserter. I agree that this may add more boiler-plate work, but it is not immediately obvious why this would be 1000x messier. > > -Hal I should probably qualify this with "1000 times messier for me" :) In this case the whole problem fit neatly in a simple IR level module pass. I had to create an alternate calling convention...

I am running Centos 5.8; at least uname -rmi gives me centos-release-5-8.el5.centos A CMS package is telling me that I need PHP 5.2x, however yum update says that I am fully up to date. Is there a "safe" way to upgrade PHP to 5.2x? Todd -- Ariste Software Bend, OR 97702 http://www.aristesoftware.com

On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Acked-by: Arnd Bergmann <arnd at arndb.de> In combination with patch 14, this looks like it should result in no change to the resulting code. Acked-by: Russell King <rmk+kernel at arm.linux.org.uk>...

On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Acked-by: Arnd Bergmann <arnd at arndb.de> In combination with patch 14, this looks like it should result in no change to the resulting code. Acked-by: Russell King <rmk+kernel at arm.linux.org.uk>...

...Thu, Dec 31, 2015 at 09:07:42PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for powerpc > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Acked-by: Arnd Bergmann <arnd at arndb.de> > --- > arch/powerpc/include/asm/barrier.h | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arc...

...Thu, Dec 31, 2015 at 09:07:42PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for powerpc > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > Acked-by: Arnd Bergmann <arnd at arndb.de> > --- > arch/powerpc/include/asm/barrier.h | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arc...

...:55 -0400, Martin K. Petersen wrote: > Christoph, > > > Hmm, I wonder if we should simply add the check and warning to > > blk_queue_logical_block_size and add an error in that case. Then > > drivers only have to check the error return, which might add a lot > > less boiler plate code. > > Yep, I agree. > I also agree that this would be cleaner (I actually tried to implement this the way you suggest), but let me explain my reasoning for doing it this way. The problem is that most current users of blk_queue_logical_block_size (43 uses in the tree, out of w...

...) and putu16_iotlb() don't depend on the above-mentioned side effects of kmap_atomic(), so that mere replacements of the old API with the new one is all that is required (i.e., there is no need to explicitly add calls to pagefault_disable() and/or preempt_disable()). This commit reuses a "boiler plate" commit message from Fabio, who has already did this change in several places. Cc: "Fabio M. De Francesco" <fmdefrancesco at gmail.com> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- Notes: v3: - credited Fabio for the commit message -...

...r some kinds >> of transformations, but late IR-level passes can insert target-specific >> intrinsics, those can be matched to pseudo instructions, and those pseudo >> instructions can be expanded (as late as necessary) by a custom inserter. I >> agree that this may add more boiler-plate work, but it is not immediately >> obvious why this would be 1000x messier. >> >> -Hal > > I should probably qualify this with "1000 times messier for me" :) > > In this case the whole problem fit neatly in a simple IR level module pass. > > I h...

...;>> of transformations, but late IR-level passes can insert target-specific >>> intrinsics, those can be matched to pseudo instructions, and those pseudo >>> instructions can be expanded (as late as necessary) by a custom inserter. I >>> agree that this may add more boiler-plate work, but it is not immediately >>> obvious why this would be 1000x messier. >>> >>> -Hal >> I should probably qualify this with "1000 times messier for me" :) >> >> In this case the whole problem fit neatly in a simple IR level module...

...erstand needing IR-level analysis for some kinds of transformations, but late IR-level passes can insert target-specific intrinsics, those can be matched to pseudo instructions, and those pseudo instructions can be expanded (as late as necessary) by a custom inserter. I agree that this may add more boiler-plate work, but it is not immediately obvious why this would be 1000x messier. -Hal > > There are other stubs to be created for other parts of the mips32 > port. > > So I'd like to get a solution to these ugly APP/NOAPP markers. > > Maybe you would not do things this...