search for: blocksrequired

Hello, I am planning on contributing path profiling to LLVM by the end of August. I have written a document of what the interface to the path profiles would look like at that time. If someone has any amendments, I can incorporate them. http://www.cs.ualberta.ca/~pejic/PathProfiling.html Slobodan Pejic

...these questions are answered later in your document but they really need to be specified up front. PathProfileInfo::DESC, for example, has no meaning outside of the comments in this context: > /* Query for paths in hot to cold order. */ > PathProfileInfo::iterator path = PI.selectPaths(F, blocksRequired.begin(), > blocksRequired.end(), PathProfileInfo::DESC); All in all, looks good. This will be a useful addition. -Dave

...swered later in your document but they really > need to be specified up front. PathProfileInfo::DESC, for example, has no > meaning outside of the comments in this context: > >> /* Query for paths in hot to cold order. */ >> PathProfileInfo::iterator path = PI.selectPaths(F, blocksRequired.begin(), >> blocksRequired.end(), PathProfileInfo::DESC); > > All in all, looks good. This will be a useful addition. Thanks for the feedback. > > -Dave > _______________________________________________ > LLVM Developers mailing list >...