search for: blockfrequencyanalysi

...As of now, it seems that inliner can exploit the information only when profile data is available. However, instructions such as __builtin_expect may set branch weight metadata as well, which is useful for inliner. I think this problem can be addressed by letting llvm::getInlineCost function to use BlockFrequencyAnalysis regardless of availability of profile data, and making CallAnalyzer::updateThreshold to use callsite frequency instead of callsite count. Is there a reason that we allow inliner to use block frequency information only when profile data is given? Thanks, Taewook -------------- next part ----------...

...gt; > > > [1] We cannot call AnalysisManager::getResult for an outer scope but only > getCachedResult. Probably because of potential pipelining or concurrency > issues. > [2] For example, potentially breaking up multiple pipelined loop passes > and insert RequireAnalysisPass<BlockFrequencyAnalysis> in front of each of > them. > [3] For example, -fprofile-instr-use and -fprofile-sample-use aren’t > present in ThinLTO post link builds. > [4] For example, we could check whether the module has the profile summary > metadata annotated when building pass pipelines but we don’t a...

...ed levels of "hotness" (e.g. Unexpected, Unlikely, Likely, Expected...). A low level interface that exposes edge weights will only be used by passes that need to incrementally update the result, or perform computations using branch probability. ** Block Frequency The result produced by BlockFrequencyAnalysis for mid-level IR and MBBFrequencyAnalysis for MachineInstrs with mostly shared implementation across IR and MI. Conceptually, this is a floating point value that satisfies the closed form: frequency(block) == (sum edgeFrequency(pred, block) for pred in block.preds()) Where "edge frequency&...

.... > GlobalsAA: Result keeps pointer to TLI (this is a function analysis). > > Function analyses: 9/17 keep pointers to other analysis > AAManager: Its Result holds TLI pointer and pointers to individual AA > result objects. > AssumptionAnalysis: No pointers to other analyses. > BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and BPI. > BranchProbabilityAnalysis: Stores no pointers to other analyses. (uses > LoopInfo to "recalculate" though) > DominatorTreeAnalysis: Stores no pointers to other analyses. > PostDominatorTreeAnalysis: Stores no pointers to other...

...ally depend on an analysis under it. [1] We cannot call AnalysisManager::getResult for an outer scope but only getCachedResult. Probably because of potential pipelining or concurrency issues. [2] For example, potentially breaking up multiple pipelined loop passes and insert RequireAnalysisPass<BlockFrequencyAnalysis> in front of each of them. [3] For example, -fprofile-instr-use and -fprofile-sample-use aren’t present in ThinLTO post link builds. [4] For example, we could check whether the module has the profile summary metadata annotated when building pass pipelines but we don’t always pass the module dow...

On Tue, Jul 12, 2016 at 11:34 PM Sean Silva <chisophugis at gmail.com> wrote: > On Tue, Jul 12, 2016 at 11:32 PM, Xinliang David Li <davidxl at google.com> > wrote: > >> >> >> On Tue, Jul 12, 2016 at 10:57 PM, Chandler Carruth <chandlerc at gmail.com> >> wrote: >> >>> Yea, this is a nasty problem. >>> >>> One

...t; [1] We cannot call AnalysisManager::getResult for an outer scope but only >> getCachedResult. Probably because of potential pipelining or concurrency >> issues. >> [2] For example, potentially breaking up multiple pipelined loop passes >> and insert RequireAnalysisPass<BlockFrequencyAnalysis> in front of each of >> them. >> [3] For example, -fprofile-instr-use and -fprofile-sample-use aren’t >> present in ThinLTO post link builds. >> [4] For example, we could check whether the module has the profile >> summary metadata annotated when building pass pipe...

...ope but only getCachedResult. Probably because >>> of potential pipelining or concurrency issues. >>> [2] For example, potentially breaking up multiple >>> pipelined loop passes and insert >>> RequireAnalysisPass<BlockFrequencyAnalysis> in front of >>> each of them. >>> [3] For example, -fprofile-instr-use and >>> -fprofile-sample-use aren’t present in ThinLTO post link >>> builds. >>> [4] For example, we could check wheth...

...his is a function analysis). >>> >>> Function analyses: 9/17 keep pointers to other analysis >>> AAManager: Its Result holds TLI pointer and pointers to individual AA >>> result objects. >>> AssumptionAnalysis: No pointers to other analyses. >>> BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and BPI. >>> BranchProbabilityAnalysis: Stores no pointers to other analyses. (uses >>> LoopInfo to "recalculate" though) >>> DominatorTreeAnalysis: Stores no pointers to other analyses. >>> PostDominatorTreeAnaly...

...obably >>>> because of potential pipelining or concurrency issues. >>>> [2] For example, potentially breaking up multiple >>>> pipelined loop passes and insert >>>> RequireAnalysisPass<BlockFrequencyAnalysis> in >>>> front of each of them. >>>> [3] For example, -fprofile-instr-use and >>>> -fprofile-sample-use aren’t present in ThinLTO post >>>> link builds. >>>>...

...lining or >>>>> concurrency issues. >>>>> [2] For example, potentially breaking up >>>>> multiple pipelined loop passes and insert >>>>> RequireAnalysisPass<BlockFrequencyAnalysis> in >>>>> front of each of them. >>>>> [3] For example, -fprofile-instr-use and >>>>> -fprofile-sample-use aren’t present in ThinLTO >>>>> post link builds...

...sis. > GlobalsAA: Result keeps pointer to TLI (this is a function analysis). > Function analyses: 9/17 keep pointers to other analysis > AAManager: Its Result holds TLI pointer and pointers to individual AA > result objects. > AssumptionAnalysis: No pointers to other analyses. > BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and > BPI. > BranchProbabilityAnalysis: Stores no pointers to other analyses. > (uses LoopInfo to "recalculate" though) > DominatorTreeAnalysis: Stores no pointers to other analyses. > PostDominatorTreeAnalysis: Stores no pointers...

...; >>>>> Function analyses: 9/17 keep pointers to other analysis >>>>> AAManager: Its Result holds TLI pointer and pointers to individual AA >>>>> result objects. >>>>> AssumptionAnalysis: No pointers to other analyses. >>>>> BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and BPI. >>>>> BranchProbabilityAnalysis: Stores no pointers to other analyses. (uses >>>>> LoopInfo to "recalculate" though) >>>>> DominatorTreeAnalysis: Stores no pointers to other analyses. >>&gt...

...> > individual > > > > > AA > > > > > result objects. > > > > > > > > > > > > > > > AssumptionAnalysis: No pointers to other analyses. > > > > > > > > > > > > > > > BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo > > > > > and > > > > > BPI. > > > > > > > > > > > > > > > BranchProbabilityAnalysis: Stores no pointers to other > > > > > analyses. > > > > > (uses...

...; > > > > > > > > > > > > > > > > > > > AssumptionAnalysis: No pointers to other analyses. > > > > > > > > > > > > > > > > > > > > > > > > > > > > BlockFrequencyAnalysis: Its Result holds pointers to > > > > > > > LoopInfo > > > > > > > and > > > > > > > BPI. > > > > > > > > > > > > > > > > > > > > > > > > > > > &gt...

...; > > > > > > > > > > > > > > > > > > > AssumptionAnalysis: No pointers to other analyses. > > > > > > > > > > > > > > > > > > > > > > > > > > > > BlockFrequencyAnalysis: Its Result holds pointers to > > > > > > > LoopInfo > > > > > > > and > > > > > > > BPI. > > > > > > > > > > > > > > > > > > > > > > > > > > > &gt...

...; > > > > > > > > > > > > > > > > > > > AssumptionAnalysis: No pointers to other analyses. > > > > > > > > > > > > > > > > > > > > > > > > > > > > BlockFrequencyAnalysis: Its Result holds pointers to > > > > > > > LoopInfo > > > > > > > and > > > > > > > BPI. > > > > > > > > > > > > > > > > > > > > > > > > > > > &gt...

...t;> Function analyses: 9/17 keep pointers to other analysis >>>>>> AAManager: Its Result holds TLI pointer and pointers to individual AA >>>>>> result objects. >>>>>> AssumptionAnalysis: No pointers to other analyses. >>>>>> BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and BPI. >>>>>> BranchProbabilityAnalysis: Stores no pointers to other analyses. >>>>>> (uses LoopInfo to "recalculate" though) >>>>>> DominatorTreeAnalysis: Stores no pointers to other analyses....

...analyses: 9/17 keep pointers to other analysis >>>>>>> AAManager: Its Result holds TLI pointer and pointers to individual >>>>>>> AA result objects. >>>>>>> AssumptionAnalysis: No pointers to other analyses. >>>>>>> BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and >>>>>>> BPI. >>>>>>> BranchProbabilityAnalysis: Stores no pointers to other analyses. >>>>>>> (uses LoopInfo to "recalculate" though) >>>>>>> DominatorTreeAnalys...

...analyses: 9/17 keep pointers to other analysis >>>>>>> AAManager: Its Result holds TLI pointer and pointers to individual >>>>>>> AA result objects. >>>>>>> AssumptionAnalysis: No pointers to other analyses. >>>>>>> BlockFrequencyAnalysis: Its Result holds pointers to LoopInfo and >>>>>>> BPI. >>>>>>> BranchProbabilityAnalysis: Stores no pointers to other analyses. >>>>>>> (uses LoopInfo to "recalculate" though) >>>>>>> DominatorTreeAnalys...