search for: block_minimum

...b/info/nbdinfo.c index 455cfc8..4c58815 100644 --- a/info/nbdinfo.c +++ b/info/nbdinfo.c @@ -264,6 +264,7 @@ list_one_export (struct nbd_handle *nbd) int is_rotational, is_read_only; int can_cache, can_df, can_fast_zero, can_flush, can_fua, can_multi_conn, can_trim, can_zero; + int64_t block_minimum, block_preferred, block_maximum; /* Collect the metadata we are going to display. */ size = nbd_get_size (nbd); @@ -288,6 +289,9 @@ list_one_export (struct nbd_handle *nbd) can_multi_conn = nbd_can_multi_conn (nbd); can_trim = nbd_can_trim (nbd); can_zero = nbd_can_zero (nbd); + bl...

Necessary when writing a client that wants to avoid unnecessary EINVAL errors from sending unaligned requests. At some point, we may want to add synchronous convenience API wrappers that do request splitting or read-modify-write to obey server constraints while still appearing to the library client as accepting any possible request. But such a wrapper should only be synchronous and not copied to

...dle *, int64_t size); >> >> @@ -181,13 +182,9 @@ show_one_export (struct nbd_handle *nbd, const char *desc, >> show_boolean ("can_trim", can_trim); >> if (can_zero >= 0) >> show_boolean ("can_zero", can_zero); >> - if (block_minimum > 0) >> - fprintf (fp, "\t%s: %" PRId64 "\n", "block_size_minimum", block_minimum); >> - if (block_preferred > 0) >> - fprintf (fp, "\t%s: %" PRId64 "\n", "block_size_preferred", >> -...

Based on Laszlo's approval of my idea here: https://listman.redhat.com/archives/libguestfs/2023-September/032661.html but as I would like to resync human-size.h back to nbdkit, I'm reluctant to apply patch 1 this until I get Rich's consent to relicensing (this email serves as my consent for my contribution here): https://listman.redhat.com/archives/libguestfs/2023-October/032755.html

...uot;true" : "false"); if (can_zero >= 0) - printf ("\t%s: %s\n", "can_zero", can_zero ? "true" : "false"); + fprintf (fp, "\t%s: %s\n", "can_zero", can_zero ? "true" : "false"); if (block_minimum > 0) - printf ("\t%s: %" PRId64 "\n", "block_size_minimum", block_minimum); + fprintf (fp, "\t%s: %" PRId64 "\n", "block_size_minimum", block_minimum); if (block_preferred > 0) - printf ("\t%s: %" PRId64...

...next; + return 0; +} + static int collect_export (void *opaque, const char *name, const char *desc) { @@ -368,8 +396,15 @@ list_one_export (struct nbd_handle *nbd, const char *desc, int can_cache, can_df, can_fast_zero, can_flush, can_fua, can_multi_conn, can_trim, can_zero; int64_t block_minimum, block_preferred, block_maximum; + struct context_list *contexts = NULL; + bool show_context = false; /* Collect the metadata we are going to display. */ + if (nbd_aio_is_negotiating (nbd) && + nbd_opt_info (nbd) == -1) { + fprintf (stderr, "%s\n", nbd_get_error ())...

In v2: ack'ed preliminary patches have been pushed, and I've added a lot of testsuite coverage as well as putting the new API to use in nbdinfo. Eric Blake (2): api: Add nbd_opt_list_meta_context info: List available meta-contexts lib/internal.h | 1 + generator/API.ml | 84 ++++++++-

This adds coalescing of adjacent extents of the same type, as mentioned by Eric Blake in the commit message here: https://github.com/libguestfs/libnbd/commit/46072f6611f80245846a445766da071e457b00cd The patch series is rather long because it detours through adding the <vector.h> library from nbdkit into libnbd and replacing ad hoc uses of realloc, char ** etc in various places. Rich.

This replaces 13/13 of my v2 series; and now that it has pretty good testsuite coverage and demonstrable performance improvement to nbdinfo, I'm going ahead and pushing this now. We may still want to add further nbd_opt_* commands for other fine-grained tuning of negotiation, but for now, I think things have stabilized on this end, and I can return to polishing .list_exports on the nbdkit

Well, I'm not quite done (I still want to get nbdinfo to work on a single nbd connection for all cases when reading the heads of the file is not required), but I'm happy with patches 1-11, and 12-13 show where I'm headed for getting NBD_OPT_INFO to work. Posting now to see if some of the earlier patches are ready to commit while I continue working on the latter half. Eric Blake (13):