search for: block_list

...uint32_t flags, > + struct nbdkit_extents *extents) > +{ > + struct vddk_handle *h = handle; > + bool req_one = flags & NBDKIT_FLAG_REQ_ONE; > + uint64_t position, end, start_sector; > + > + position = offset; > + ... > + > + for (i = 0; i < block_list->numBlocks; ++i) { > + uint64_t offset, length; > + > + offset = block_list->blocks[i].offset * VIXDISKLIB_SECTOR_SIZE; > + length = block_list->blocks[i].length * VIXDISKLIB_SECTOR_SIZE; > + > + /* The query returns blocks. We must insert holes betwe...

...atic VixError (*VixDiskLib_Write) (VixDiskLibHandle handle, uint64_t start_sector, uint64_t nr_sectors, const unsigned char *buf); +static VixError (*VixDiskLib_QueryAllocatedBlocks) (VixDiskLibHandle diskHandle, uint64_t start_sector, uint64_t nr_sectors, uint64_t chunk_size, VixDiskLibBlockList **block_list); +static VixError (*VixDiskLib_FreeBlockList) (VixDiskLibBlockList *block_list); /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 @@ -174,6 +178,11 @@ vddk_load (void) VixDiskLib_FreeInfo = dlsym (dl, "VixDiskLib_FreeInfo"); VixDiskLib_Read = dlsym (dl, "VixDiskLib_...

On Sat, Mar 23, 2019 at 02:29:54PM -0500, Eric Blake wrote: > On 3/20/19 5:11 PM, Richard W.M. Jones wrote: ... > > + for (i = 0; i < block_list->numBlocks; ++i) { > > + uint64_t offset, length; > > + > > + offset = block_list->blocks[i].offset * VIXDISKLIB_SECTOR_SIZE; > > + length = block_list->blocks[i].length * VIXDISKLIB_SECTOR_SIZE; > > + > > + /* The query returns block...

On Mon, Mar 25, 2019 at 05:34:25PM +0000, Richard W.M. Jones wrote: > On Sat, Mar 23, 2019 at 02:29:54PM -0500, Eric Blake wrote: > > On 3/20/19 5:11 PM, Richard W.M. Jones wrote: > ... > > > + for (i = 0; i < block_list->numBlocks; ++i) { > > > + uint64_t offset, length; > > > + > > > + offset = block_list->blocks[i].offset * VIXDISKLIB_SECTOR_SIZE; > > > + length = block_list->blocks[i].length * VIXDISKLIB_SECTOR_SIZE; > > > + > > > +...

Not sure what version we're up to, but this reimplements extents using the new simpler structure described in this thread: https://www.redhat.com/archives/libguestfs/2019-March/msg00077.html I also fixed most of the things that Eric pointed out in the previous review, although I need to go back over his replies and check I've got everything. This needs a bit more testing. However the

...the call and if it's * non-functional return false. @@ -889,6 +935,7 @@ vddk_can_extents (void *handle) 0, VIXDISKLIB_MIN_CHUNK_SIZE, VIXDISKLIB_MIN_CHUNK_SIZE, &block_list); + clear_error_suppression (); if (err == VIX_OK) { DEBUG_CALL ("VixDiskLib_FreeBlockList", "block_list"); VixDiskLib_FreeBlockList (block_list); @@ -1027,6 +1074,7 @@ static struct nbdkit_plugin plugin = { .name = "vddk", .longname...

Couple of fixes to return correct data and one nice-to-have clean-up which is not needed. I just find it nicer to read. Martin Kletzander (3): vddk: Use a separate handle for single-link=true vddk: Do not report hole extents to be zero with single-link=true vddk: Eliminate one needless goto plugins/vddk/vddk.c | 48 +++++++++++++++++++++++++++++++++------------ 1 file changed, 36

...(h->handle, + err = VixDiskLib_QueryAllocatedBlocks (single_link ? h->handle_single_link : h->handle, 0, VIXDISKLIB_MIN_CHUNK_SIZE, VIXDISKLIB_MIN_CHUNK_SIZE, &block_list); @@ -809,7 +827,7 @@ vddk_extents (void *handle, uint32_t count, uint64_t offset, uint32_t flags, "handle, %" PRIu64 " sectors, %" PRIu64 " sectors, " "%d sectors", start_sector, nr_sectors, VIXDISKLIB_MIN_C...

...t log (15 MB) : https://ruvoip.net/_other/voip/2016-09-05-2/full.txt third segfault: Program terminated with signal 11, Segmentation fault. #0 0x00007f592bcad53d in pj_pool_alloc (pool=0x7f580000002c, size=80) at ../include/pj/pool_i.h:60 60 void *ptr = pj_pool_alloc_from_block(pool->block_list.next, size); backtrace: https://ruvoip.net/_other/voip/2016-09-05-3/backtrace-threads.txt log (11 MB) : https://ruvoip.net/_other/voip/2016-09-05-3/full.txt

I believe this roughly implements Nir's proposal here: https://www.redhat.com/archives/libguestfs/2020-August/msg00028.html Unfortunately it doesn't work for me. It actually slows things down quite a lot, for reasons I don't understand. Note the adjustment of the pool-max parameter and how it affects the total time. The results are quite reproducible. $ ./nbdkit -r -U - vddk

...lush"); return -1; @@ -783,7 +894,8 @@ vddk_flush (void *handle, uint32_t flags) static int vddk_can_extents (void *handle) { - struct vddk_handle *h = handle; + struct handle *h = handle; + GET_VDDK_HANDLE_FOR_CURRENT_SCOPE (h, vddk_handle); VixError err; VixDiskLibBlockList *block_list; @@ -808,7 +920,7 @@ vddk_can_extents (void *handle) DEBUG_CALL ("VixDiskLib_QueryAllocatedBlocks", "handle, 0, %d sectors, %d sectors", VIXDISKLIB_MIN_CHUNK_SIZE, VIXDISKLIB_MIN_CHUNK_SIZE); - err = VixDiskLib_QueryAllocatedBlocks (h->hand...

I'm not sure exactly which version we're up to, but let's say it's version 4. I'm a lot happier with this version: - all filters have been reviewed and changed where I think that's necessary - can_extents is properly defined and implemented now - NBD protocol is followed - I believe it addresses all previous review points where possible The "only" thing

...894,8 @@ vddk_flush (void *handle, uint32_t flags) > static int > vddk_can_extents (void *handle) > { > - struct vddk_handle *h = handle; > + struct handle *h = handle; > + GET_VDDK_HANDLE_FOR_CURRENT_SCOPE (h, vddk_handle); > VixError err; > VixDiskLibBlockList *block_list; > > @@ -808,7 +920,7 @@ vddk_can_extents (void *handle) > DEBUG_CALL ("VixDiskLib_QueryAllocatedBlocks", > "handle, 0, %d sectors, %d sectors", > VIXDISKLIB_MIN_CHUNK_SIZE, VIXDISKLIB_MIN_CHUNK_SIZE); > - err = VixDiskLib_Quer...

I want to post this but mainly for discussion and early review. It's not safe for these patches to all go upstream yet (because not all filters have been checked/adjusted), but if any patches were to go upstream then probably 1 & 2 only are safe. File, VDDK, memory and data plugins all work, although I have only done minimal testing on them. The current tests, such as they are, all

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.

..._table; + int x; + int y; + int offset; + }scan_list[10]; + int scan_h_subsample; + int scan_v_subsample; + + /* scan state */ + int x,y; + int dc[4]; }; -struct jpeg_scan_struct -{ - int length; - - int n_components; - struct - { - int index; - int dc_table; - int ac_table; - } block_list[10]; +struct _JpegScan { + int length; + + int n_components; + struct { + int index; + int dc_table; + int ac_table; + }block_list[10]; }; /* jpeg.c */ -int jpeg_decoder_sof_baseline_dct (JpegDecoder * dec, bits_t * bits); -int jpeg_decoder_define_quant_table (JpegDecoder * dec, bits_t...