search for: blkdiscard

This patch is easier to read if you use the 'git show -w' option. Also observe that: fun a -> ( fun () -> (* code *) ) (ie. returning a closure) is identical to: fun a () -> (* code *) Rich.

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

Hi! This question emerged during testing of oVirt sparsify integration. oVirt now is able to run virt-sparsify on VM disks. But virt-sparsify seems to have no effect on iSCSI disks. Does virt-sparsify work on iSCSI disks? Maybe in sum situation, with some configuration of iSCSI server, with some specific virt-sparsify options? Shmuel

...in - - (* Create a qcow2 v3 overlay to protect the source image(s). There - * is a specific reason to use the newer qcow2 variant: Because the - * L2 table can store zero clusters efficiently, and because - * discarded blocks are stored as zero clusters, this should allow us - * to fstrim/blkdiscard and avoid copying significant parts of the - * data over the wire. - *) - message (f_"Creating an overlay to protect the source from being modified"); - let overlay_dir = (new Guestfs.guestfs ())#get_cachedir () in - let overlays = - List.map ( - fun ({ s_qemu_uri = qemu_ur...

..., 142 deletions(-) delete mode 100644 daemon/augeas.c diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 220b934a3..f20dc8584 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -85,7 +85,6 @@ guestfsd_SOURCES = \ acl.c \ actions.h \ available.c \ - augeas.c \ base64.c \ blkdiscard.c \ blkid.c \ @@ -256,7 +255,6 @@ guestfsd_CPPFLAGS = \ guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(RPC_CFLAGS) \ - $(AUGEAS_CFLAGS) \ $(HIVEX_CFLAGS) \ $(SD_JOURNAL_CFLAGS) \ $(JANSSON_CFLAGS) \ diff --git a/daemon/augeas.c b/daemon/augeas.c deleted file mode 100644 index...

..., 142 deletions(-) delete mode 100644 daemon/augeas.c diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 220b934a3..f20dc8584 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -85,7 +85,6 @@ guestfsd_SOURCES = \ acl.c \ actions.h \ available.c \ - augeas.c \ base64.c \ blkdiscard.c \ blkid.c \ @@ -256,7 +255,6 @@ guestfsd_CPPFLAGS = \ guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(RPC_CFLAGS) \ - $(AUGEAS_CFLAGS) \ $(HIVEX_CFLAGS) \ $(SD_JOURNAL_CFLAGS) \ $(JANSSON_CFLAGS) \ diff --git a/daemon/augeas.c b/daemon/augeas.c deleted file mode 100644 index...

Hello，everyone I ran virt-resize(v1.30.4) on my CentOS 7.1 to resize win2008r2 and got the warning message (virt-resize: warning: unknown/unavailable method for expanding the ntfs filesystem on /dev/sda2): >/usr/local/libguestfs-1.30.4/run virt-resize --expand /dev/sda2 /images/win2008_src.raw /dev/vg0/win2008_resize_dst [ 0.0] Examining

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

...2 +- tests/bigdirs/test-big-dirs.pl | 2 +- tests/btrfs/test-btrfs-misc.pl | 2 +- tests/btrfs/test-btrfs-subvolume-default.pl | 2 +- tests/daemon/test-btrfs.pl | 2 +- tests/daemon/test-daemon-start.pl | 2 +- tests/discard/test-blkdiscard.pl | 2 +- tests/discard/test-discard.pl | 2 +- tests/discard/test-fstrim.pl | 2 +- tests/disk-labels/test-disk-labels.pl | 2 +- tests/disks/test-max-disks.pl | 2 +- tests/events/test-console-debug.pl | 2 +-...

...ks = + (* Create a qcow2 v3 overlay to protect the source image(s). There + * is a specific reason to use the newer qcow2 variant: Because the + * L2 table can store zero clusters efficiently, and because + * discarded blocks are stored as zero clusters, this should allow us + * to fstrim/blkdiscard and avoid copying significant parts of the + * data over the wire. + *) + message (f_"Creating overlays to protect the sources from being modified"); + let overlay_dir = (new Guestfs.guestfs ())#get_cachedir () in + List.mapi ( + fun i ({ s_qemu_uri = qemu_uri; s_format = format...

...| 1 + src/MAX_PROC_NR | 2 +- 5 files changed, 215 insertions(+), 1 deletion(-) create mode 100644 daemon/bmap.c diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 8ccf322..b6444fa 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -86,6 +86,7 @@ guestfsd_SOURCES = \ blkdiscard.c \ blkid.c \ blockdev.c \ + bmap.c \ btrfs.c \ cap.c \ checksum.c \ diff --git a/daemon/bmap.c b/daemon/bmap.c new file mode 100644 index 0000000..555f776 --- /dev/null +++ b/daemon/bmap.c @@ -0,0 +1,168 @@ +/* libguestfs - the guestfsd daemon + * Copyright (C) 2014 Red Hat Inc. + * + *...

Does *not* incorporate changes suggested by Pino yet. Rich.

...on the list!] On Mon, Dec 14, 2015 at 10:46:00AM +0800, Jeffrey wrote: > > > libguestfs-winsupport-7.1-4.el7.x86_64 doesn't work for me either. :( > > > >./run guestfish -a /dev/null run : supported > acl yes > augeas yes > blkdiscard yes > blkdiscardzeroes yes > btrfs yes > extlinux yes > fstrim yes > gdisk yes > grub no > hivex yes > inotify yes > journal yes > ldm no > linuxcaps yes > l...

See http://rwmj.wordpress.com/2014/11/23/mapping-files-to-disk/

On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones <rjones@redhat.com> wrote: > It has to be said it would be really convenient to have a 'zero' > and/or 'trim' method of some sort. > 'trim' means discard? Currently we cannot support discard on block storage since ovirt may need to wipe lvs when deleting a disk, and discarding may leave unwiped user data.

....finalize does? > Currently we cannot support discard on block storage since ovirt may > need to wipe lvs when deleting a disk, and discarding may leave > unwiped user data. This may change in 4.3 if we switch to wipe on > creation instead of wipe after delete. I think this depends on BLKDISCARDZEROES[1] for the block device? Of course if you're worried about data remanence for someone who has access to the physical device then that wouldn't be enough. [1] https://rwmj.wordpress.com/2014/03/11/blkdiscard-blkzeroout-blkdiscardzeroes-blksecdiscard/ > POST /images/ticket-id ......

...in - (* Create a qcow2 v3 overlay to protect the source image(s). There - * is a specific reason to use the newer qcow2 variant: Because the - * L2 table can store zero clusters efficiently, and because - * discarded blocks are stored as zero clusters, this should allow us - * to fstrim/blkdiscard and avoid copying significant parts of the - * data over the wire. - *) - message (f_"Creating an overlay to protect the source from being modified"); let overlay_dir = (new Guestfs.guestfs ())#get_cachedir () in - let overlays = - List.map ( - fun ({ s_qemu_uri = qemu_ur...

...qcow2 v3 overlay to protect the source image(s). There > - * is a specific reason to use the newer qcow2 variant: Because the > - * L2 table can store zero clusters efficiently, and because > - * discarded blocks are stored as zero clusters, this should allow us > - * to fstrim/blkdiscard and avoid copying significant parts of the > - * data over the wire. > - *) > - message (f_"Creating an overlay to protect the source from being modified"); > let overlay_dir = (new Guestfs.guestfs ())#get_cachedir () in Part of this patch is a refactoring -- moving t...

...much development that's happened since the tree found in RHEL/CentOS kernels. Also FWIW Red Hat is deprecating Btrfs, in the RHEL 7.4 announcement. Support will be removed probably in RHEL 8. I have no idea how it'll affect CentOS kernels though. It will remain in Fedora kernels. Anyway, blkdiscard can be used on an SSD, whole or partition to zero them out. And at least recent ext4 and XFS mkfs will do a blkdisard, same as mksfs.btrfs. Chris Murphy > < > https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&amp...

To be honest, I'd not try a btrfs volume on a notebook SSD. I did that on a couple of systems and it corrupted pretty quickly. I'd stick with xfs/ext4 if you manage to get the drive working again. <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> Virus-free. www.avast.com