search for: blkdev_put

...trfs tries to open the device O_EXCL, and somebody still has it. Using systemtap to track bdev gets & puts shows a kworker thread doing a blkdev put after mkfs attempts a get; this is left over from the unmount. Adding an rcu_barrier() to btrfs_close_devices() causes unmount to wait until all blkdev_put()s are done, and the device is truly free once unmount completes. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- p.s. I debated putting it into close_ctree(); I don''t know if there'' anything else to wait for. Thoughts? diff --git a/fs/btrfs/volumes.c b/fs/btrfs/vol...

...9;s site. The changes to make it compile were: 1. /* if (bdev && blkdev_get(bdev, FMODE_READ, 0 __BDEV_RAW)==0) { # Above for < 2.6.28 */ if (bdev && blkdev_get(bdev, FMODE_READ)==0) { Note that the last two parms from the original call were removed. 2. /* blkdev_put(bdev __BDEV_RAW); (or, in another case, just BDEV_RAW) # above < 2.6.28 */ blkdev_put(bdev, FMODE_READ); 3. In osm_linux.h, their definition redefines what the Linux header files say. I made the following change. Note that I wanted to make sure IRQ_HANDLED was defined, presum...

''bh'' is forgot to release if no error is detected Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- fs/btrfs/volumes.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 8b9fb8c..69fc902 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -631,6 +631,7 @@ static int

...045] [<ffffffff814d27de>] device_release+0x3e/0xc0 [ 165.633045] [<ffffffff8139f8a2>] kobject_cleanup+0x82/0x1c0 [ 165.633045] [<ffffffff8139f730>] kobject_put+0x30/0x70 [ 165.633045] [<ffffffff8137c797>] put_disk+0x17/0x20 [ 165.633045] [<ffffffff812278a5>] __blkdev_put+0x125/0x1b0 [ 165.633045] [<ffffffff8122798b>] blkdev_put+0x5b/0x160 [ 165.633045] [<ffffffff81227ab5>] blkdev_close+0x25/0x30 [ 165.633045] [<ffffffff811f129d>] __fput+0xbd/0x250 [ 165.633045] [<ffffffff811f147e>] ____fput+0xe/0x10 [ 165.633045] [<ffffffff81091...

...045] [<ffffffff814d27de>] device_release+0x3e/0xc0 [ 165.633045] [<ffffffff8139f8a2>] kobject_cleanup+0x82/0x1c0 [ 165.633045] [<ffffffff8139f730>] kobject_put+0x30/0x70 [ 165.633045] [<ffffffff8137c797>] put_disk+0x17/0x20 [ 165.633045] [<ffffffff812278a5>] __blkdev_put+0x125/0x1b0 [ 165.633045] [<ffffffff8122798b>] blkdev_put+0x5b/0x160 [ 165.633045] [<ffffffff81227ab5>] blkdev_close+0x25/0x30 [ 165.633045] [<ffffffff811f129d>] __fput+0xbd/0x250 [ 165.633045] [<ffffffff811f147e>] ____fput+0xe/0x10 [ 165.633045] [<ffffffff81091...

...8d Chris Mason 2008-05-07 1502 a061fc8d Chris Mason 2008-05-07 1503 error_brelse: a061fc8d Chris Mason 2008-05-07 1504 brelse(bh); a061fc8d Chris Mason 2008-05-07 @1505 error_close: dfe25020 Chris Mason 2008-05-13 1506 if (bdev) e525fd89 Tejun Heo 2010-11-13 1507 blkdev_put(bdev, FMODE_READ | FMODE_EXCL); a061fc8d Chris Mason 2008-05-07 1508 out: a061fc8d Chris Mason 2008-05-07 1509 mutex_unlock(&uuid_mutex); a061fc8d Chris Mason 2008-05-07 1510 return ret; 9b3517e9 Ilya Dryomov 2011-02-15 1511 error_undo: 9b3517e9 Ilya Dryomov 2011-02-15 1...

...14d27de>] device_release+0x3e/0xc0 > [ 165.633045] [<ffffffff8139f8a2>] kobject_cleanup+0x82/0x1c0 > [ 165.633045] [<ffffffff8139f730>] kobject_put+0x30/0x70 > [ 165.633045] [<ffffffff8137c797>] put_disk+0x17/0x20 > [ 165.633045] [<ffffffff812278a5>] __blkdev_put+0x125/0x1b0 > [ 165.633045] [<ffffffff8122798b>] blkdev_put+0x5b/0x160 > [ 165.633045] [<ffffffff81227ab5>] blkdev_close+0x25/0x30 > [ 165.633045] [<ffffffff811f129d>] __fput+0xbd/0x250 > [ 165.633045] [<ffffffff811f147e>] ____fput+0xe/0x10 > [ 165.63...

...14d27de>] device_release+0x3e/0xc0 > [ 165.633045] [<ffffffff8139f8a2>] kobject_cleanup+0x82/0x1c0 > [ 165.633045] [<ffffffff8139f730>] kobject_put+0x30/0x70 > [ 165.633045] [<ffffffff8137c797>] put_disk+0x17/0x20 > [ 165.633045] [<ffffffff812278a5>] __blkdev_put+0x125/0x1b0 > [ 165.633045] [<ffffffff8122798b>] blkdev_put+0x5b/0x160 > [ 165.633045] [<ffffffff81227ab5>] blkdev_close+0x25/0x30 > [ 165.633045] [<ffffffff811f129d>] __fput+0xbd/0x250 > [ 165.633045] [<ffffffff811f147e>] ____fput+0xe/0x10 > [ 165.63...

..._o2hb_region(item); - if (reg->hr_tmp_block) - kfree(reg->hr_tmp_block); + kfree(reg->hr_tmp_block); if (reg->hr_slot_data) { for (i = 0; i < reg->hr_num_pages; i++) { @@ -978,8 +977,7 @@ static void o2hb_region_release(struct config_item *item) if (reg->hr_bdev) blkdev_put(reg->hr_bdev, FMODE_READ|FMODE_WRITE); - if (reg->hr_slots) - kfree(reg->hr_slots); + kfree(reg->hr_slots); spin_lock(&o2hb_live_lock); list_del(&reg->hr_all_item); diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 9fbe849..7530d10 100644 --- a/fs/oc...

Hello, This patch series adds an initial implementation of restriper (it''s a clever name for relocation framework that allows to do selective profile changing and selective balancing with some goodies like pausing/resuming and reporting progress to the user. Profile changing is global (per-FS) so far, per-subvolume profiles require some discussion and can be implemented in future.

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk