search for: blk_start_queue

...out how it works: for example: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -69,6 +69,8 @@ static void blk_done(struct virtqueue *v /* In case queue is stopped waiting for more buffers. */ blk_start_queue(vblk->disk->queue); spin_unlock_irqrestore(&vblk->lock, flags); + + vq->vq_ops->enable_cb(vq); } static bool do_req(struct request_queue *q, struct virtio_blk *vblk, Since this does not check the return status from enable_cb, it seems we could loose an interrup...

...out how it works: for example: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -69,6 +69,8 @@ static void blk_done(struct virtqueue *v /* In case queue is stopped waiting for more buffers. */ blk_start_queue(vblk->disk->queue); spin_unlock_irqrestore(&vblk->lock, flags); + + vq->vq_ops->enable_cb(vq); } static bool do_req(struct request_queue *q, struct virtio_blk *vblk, Since this does not check the return status from enable_cb, it seems we could loose an interrup...

When user hot-unplug a disk which is busy serving I/O, __blk_run_queue might be unable to drain all the requests. As a result, the blk_drain_queue() would loop forever and blk_cleanup_queue would not return. So hot-unplug will fail. This patch adds a callback in blk_drain_queue() for low lever driver to abort requests. Currently, this is useful for virtio-blk to do cleanup in hot-unplug. Cc:

When user hot-unplug a disk which is busy serving I/O, __blk_run_queue might be unable to drain all the requests. As a result, the blk_drain_queue() would loop forever and blk_cleanup_queue would not return. So hot-unplug will fail. This patch adds a callback in blk_drain_queue() for low lever driver to abort requests. Currently, this is useful for virtio-blk to do cleanup in hot-unplug. Cc:

...oc_grant_references+0x15/0x30 [ 32.304933] [<ffffffffa000bd4f>] do_blkif_request+0x6bf/0x8a0 [xen_blkfront] [ 32.304945] [<ffffffff812eb0e2>] ? __freed_request+0x92/0xa0 [ 32.304951] [<ffffffff812eb6e3>] __blk_run_queue+0x33/0x40 [ 32.304957] [<ffffffff812eb719>] blk_start_queue+0x29/0x40 [ 32.304964] [<ffffffffa000bf51>] kick_pending_request_queues+0x21/0x30 [xen_blkfront] [ 32.304975] [<ffffffffa000c6ce>] blkif_interrupt+0x76e/0x820 [xen_blkfront] [ 32.304986] [<ffffffff811dcc8b>] ? kmem_cache_free+0x1bb/0x1f0 [ 32.304995] [<ffffffff81130...

...get major 8 with name sd Unable to handle kernel NULL pointer dereference at virtual address 00000104 printing eip: c0254428 *pde = ma 00000000 pa 55555000 Oops: 0002 [#1] SMP Modules linked in: CPU: 0 EIP: 0061:[<c0254428>] Not tainted VLI EFLAGS: 00010286 (2.6.12-xenU) EIP is at blk_start_queue+0x8/0x60 eax: 00000000 ebx: 00000000 ecx: 00000000 edx: fbffc000 esi: c12e0004 edi: c12b2d85 ebp: c119bf9c esp: c119bf28 ds: 007b es: 007b ss: 0069 Process xenwatch (pid: 10, threadinfo=c119a000 task=c006e580) Stack: c0264862 c12e0000 c0266a8e 00000000 c12e0000 c026759c c12e0000 000...

...gt; not, we want to restore them when we unfreeze. For the blk code, I added blk_drain_queue() and related calls to the freeze handler, that was missed earlier. > 2) Does it stop more I/O from reaching do_virtblk_request during freeze? > If not, we need to. Added blk_stop_queue() and blk_start_queue() calls to ensure this. > If we need to save and restore requests, I don't think we should do this > on a per-driver basis, but try to do it in the core. Agreed, however currently we don't save and restore any pending vq items. If it is necessary, we should do it in common code (ea...

...gt; not, we want to restore them when we unfreeze. For the blk code, I added blk_drain_queue() and related calls to the freeze handler, that was missed earlier. > 2) Does it stop more I/O from reaching do_virtblk_request during freeze? > If not, we need to. Added blk_stop_queue() and blk_start_queue() calls to ensure this. > If we need to save and restore requests, I don't think we should do this > on a per-driver basis, but try to do it in the core. Agreed, however currently we don't save and restore any pending vq items. If it is necessary, we should do it in common code (ea...

...lk->lock, flags); + spin_lock_irqsave(vblk->disk->queue->queue_lock, flags); while ((vbr = virtqueue_get_buf(vblk->vq, &len)) != NULL) { int error; @@ -104,7 +102,7 @@ static void blk_done(struct virtqueue *v } /* In case queue is stopped waiting for more buffers. */ blk_start_queue(vblk->disk->queue); - spin_unlock_irqrestore(&vblk->lock, flags); + spin_unlock_irqrestore(vblk->disk->queue->queue_lock, flags); } static bool do_req(struct request_queue *q, struct virtio_blk *vblk, @@ -438,7 +436,6 @@ static int __devinit virtblk_probe(struc } INI...

...lk->lock, flags); + spin_lock_irqsave(vblk->disk->queue->queue_lock, flags); while ((vbr = virtqueue_get_buf(vblk->vq, &len)) != NULL) { int error; @@ -104,7 +102,7 @@ static void blk_done(struct virtqueue *v } /* In case queue is stopped waiting for more buffers. */ blk_start_queue(vblk->disk->queue); - spin_unlock_irqrestore(&vblk->lock, flags); + spin_unlock_irqrestore(vblk->disk->queue->queue_lock, flags); } static bool do_req(struct request_queue *q, struct virtio_blk *vblk, @@ -438,7 +436,6 @@ static int __devinit virtblk_probe(struc } INI...

On 01/06/2018 03:16 AM, Dmitry Melekhov wrote: > The same problem with latest centos 6 kernel,i.e. with meltdown fix. > > I can't see console output, because I have it on "cloud" provider > hosting :-) > > > > 06.01.2018 05:13, Shaun Reitan ?????: >> Broken! >> >> For those of you looking for a PV enabled client Kernel for CentOS Linux

...587.145018]? [<ffffffff813629e5>] gnttab_alloc_grant_references+0x15/0x30 > [? 587.145018]? [<ffffffffa0000cc3>] do_blkif_request+0x683/0x850 > [xen_blkfront] > [? 587.145018]? [<ffffffff812906c3>] __blk_run_queue+0x33/0x40 > [? 587.145018]? [<ffffffff812906f9>] blk_start_queue+0x29/0x40 > [? 587.145018]? [<ffffffffa0000eb1>] > kick_pending_request_queues+0x21/0x30 [xen_blkfront] > [? 587.145018]? [<ffffffffa0001487>] blkif_interrupt+0x5c7/0x670 > [xen_blkfront] > [? 587.145018]? [<ffffffff810f735e>] handle_irq_event_percpu+0x3e/0x1e0 >...

Hi, Jens & Rusty This version is rebased against linux-next which resolves the conflict with Paolo Bonzini's 'virtio-blk: allow toggling host cache between writeback and writethrough' patch. Patch 1/3 and 2/3 applies on linus's master as well. Since Rusty will pick up patch 3/3 so the changes to block core (adding blk_bio_map_sg()) will have a user. Jens, could you please

Hi, Jens & Rusty This version is rebased against linux-next which resolves the conflict with Paolo Bonzini's 'virtio-blk: allow toggling host cache between writeback and writethrough' patch. Patch 1/3 and 2/3 applies on linus's master as well. Since Rusty will pick up patch 3/3 so the changes to block core (adding blk_bio_map_sg()) will have a user. Jens, could you please

This patchset implements bio-based IO path for virito-blk to improve performance. Fio test shows it gives, 28%, 24%, 21%, 16% IOPS boost and 32%, 17%, 21%, 16% latency improvement for sequential read/write, random read/write respectively. Asias He (2): block: Add blk_bio_map_sg() helper virtio-blk: Add bio-based IO path for virtio-blk block/blk-merge.c | 63 ++++++++++++++

This patchset implements bio-based IO path for virito-blk to improve performance. Fio test shows it gives, 28%, 24%, 21%, 16% IOPS boost and 32%, 17%, 21%, 16% latency improvement for sequential read/write, random read/write respectively. Asias He (2): block: Add blk_bio_map_sg() helper virtio-blk: Add bio-based IO path for virtio-blk block/blk-merge.c | 63 ++++++++++++++

...ies+0x100/0x2e0 [ 587.145018] [<ffffffff813629e5>] gnttab_alloc_grant_references+0x15/0x30 [ 587.145018] [<ffffffffa0000cc3>] do_blkif_request+0x683/0x850 [xen_blkfront] [ 587.145018] [<ffffffff812906c3>] __blk_run_queue+0x33/0x40 [ 587.145018] [<ffffffff812906f9>] blk_start_queue+0x29/0x40 [ 587.145018] [<ffffffffa0000eb1>] kick_pending_request_queues+0x21/0x30 [xen_blkfront] [ 587.145018] [<ffffffffa0001487>] blkif_interrupt+0x5c7/0x670 [xen_blkfront] [ 587.145018] [<ffffffff810f735e>] handle_irq_event_percpu+0x3e/0x1e0 [ 587.145018] [<ffffff...

...0x30 > [ 32.304933] [<ffffffffa000bd4f>] do_blkif_request+0x6bf/0x8a0 > [xen_blkfront] > [ 32.304945] [<ffffffff812eb0e2>] ? __freed_request+0x92/0xa0 > [ 32.304951] [<ffffffff812eb6e3>] __blk_run_queue+0x33/0x40 > [ 32.304957] [<ffffffff812eb719>] blk_start_queue+0x29/0x40 > [ 32.304964] [<ffffffffa000bf51>] kick_pending_request_queues+0x21/0x30 > [xen_blkfront] > [ 32.304975] [<ffffffffa000c6ce>] blkif_interrupt+0x76e/0x820 > [xen_blkfront] > [ 32.304986] [<ffffffff811dcc8b>] ? kmem_cache_free+0x1bb/0x1f0 > [...

Hi folks, This version added REQ_FLUSH and REQ_FUA support as suggested by Christoph and rebased against latest linus's tree. Jens, could you please consider picking up the dependencies 1/4 and 2/4 in your tree. Thanks! This patchset implements bio-based IO path for virito-blk to improve performance. Fio test shows bio-based IO path gives the following performance improvement: 1) Ramdisk

Hi folks, This version added REQ_FLUSH and REQ_FUA support as suggested by Christoph and rebased against latest linus's tree. Jens, could you please consider picking up the dependencies 1/4 and 2/4 in your tree. Thanks! This patchset implements bio-based IO path for virito-blk to improve performance. Fio test shows bio-based IO path gives the following performance improvement: 1) Ramdisk