search for: blk_register_queu

..._register_owner(bdi, disk_to_dev(disk)); > + retval = bdi_register_owner(bdi, disk_to_dev(disk)); > + if (retval) > + goto fail; > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > - exact_match, exact_lock, disk); > - register_disk(parent, disk); > - blk_register_queue(disk); > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > + exact_match, exact_lock, disk); > + if (retval) > + goto fail; > + retval = register_disk(parent, disk); > + if (retval) > + goto fail; > + retval = blk_register_queue(disk); >...

..._register_owner(bdi, disk_to_dev(disk)); > + retval = bdi_register_owner(bdi, disk_to_dev(disk)); > + if (retval) > + goto fail; > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > - exact_match, exact_lock, disk); > - register_disk(parent, disk); > - blk_register_queue(disk); > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > + exact_match, exact_lock, disk); > + if (retval) > + goto fail; > + retval = register_disk(parent, disk); > + if (retval) > + goto fail; > + retval = blk_register_queue(disk); >...

...owner(bdi, disk_to_dev(disk)); > > > + if (retval) > > > + goto fail; > > > > > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > > > - exact_match, exact_lock, disk); > > > - register_disk(parent, disk); > > > - blk_register_queue(disk); > > > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > > > + exact_match, exact_lock, disk); > > > + if (retval) > > > + goto fail; > > > + retval = register_disk(parent, disk); > > > + if (retval) > &...

...owner(bdi, disk_to_dev(disk)); > > > + if (retval) > > > + goto fail; > > > > > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > > > - exact_match, exact_lock, disk); > > > - register_disk(parent, disk); > > > - blk_register_queue(disk); > > > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > > > + exact_match, exact_lock, disk); > > > + if (retval) > > > + goto fail; > > > + retval = register_disk(parent, disk); > > > + if (retval) > &...

...> > + retval = bdi_register_owner(bdi, disk_to_dev(disk)); > > + if (retval) > > + goto fail; > > > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > > - exact_match, exact_lock, disk); > > - register_disk(parent, disk); > > - blk_register_queue(disk); > > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > > + exact_match, exact_lock, disk); > > + if (retval) > > + goto fail; > > + retval = register_disk(parent, disk); > > + if (retval) > > + goto fail; > > +...

...k->queue->backing_dev_info; - bdi_register_owner(bdi, disk_to_dev(disk)); + retval = bdi_register_owner(bdi, disk_to_dev(disk)); + if (retval) + goto fail; - blk_register_region(disk_devt(disk), disk->minors, NULL, - exact_match, exact_lock, disk); - register_disk(parent, disk); - blk_register_queue(disk); + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, + exact_match, exact_lock, disk); + if (retval) + goto fail; + retval = register_disk(parent, disk); + if (retval) + goto fail; + retval = blk_register_queue(disk); + if (retval) + goto fail; /* * Take...

...> > > + if (retval) > > > > + goto fail; > > > > > > > > - blk_register_region(disk_devt(disk), disk->minors, NULL, > > > > - exact_match, exact_lock, disk); > > > > - register_disk(parent, disk); > > > > - blk_register_queue(disk); > > > > + retval = blk_register_region(disk_devt(disk), disk->minors, NULL, > > > > + exact_match, exact_lock, disk); > > > > + if (retval) > > > > + goto fail; > > > > + retval = register_disk(parent, disk); > >...

...27ed858 ffff8800027ed800 ffff8800027ed800 [ 173.233768] <0> ffff8800027ed800 ffff8800026c11a0 ffff8800027ed858 ffff880002038000 [ 173.233788] <0> 0000000000000000 ffffffff81180e8e 0000000000000000 ffff8800027ed800 [ 173.233811] Call Trace: [ 173.233823] [<ffffffff81180e8e>] ? blk_register_queue+0xbe/0xcc [ 173.233836] [<ffffffff81184c89>] ? add_disk+0xb8/0x108 [ 173.233850] [<ffffffffa000f224>] ? backend_changed+0x44e/0x468 [xen_blkfront] [ 173.233865] [<ffffffff811f1c8f>] ? xenwatch_thread+0x117/0x14a [ 173.233878] [<ffffffff81065042>] ? autoremove_wake_f...

.../** * add_disk - add partitioning information to kernel list @@ -618,7 +633,7 @@ void add_disk(struct gendisk *disk, bool gen_uevent) blk_register_region(disk_devt(disk), disk->minors, NULL, exact_match, exact_lock, disk); - register_disk(disk); + register_disk(disk, gen_uevent); blk_register_queue(disk); /* diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 038be80..87ad9e5 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -416,6 +416,7 @@ extern void part_round_stats(int cpu, struct hd_struct *part); /* block/genhd.c */ extern void add_disk(struct gendis...

Hello, I trying to run XEN 2.0 (2.4.27, 2.4.28, 2.6.9) on gentoo 2004.3. When i boot guest domain i get this: anubis xen # xm create -f ttylinux -c Using config file "ttylinux". Started domain ttylinux, console on port 9601 ************ REMOTE CONSOLE: CTRL-] TO QUIT ******** Linux version 2.4.28-xenU (root@anubis) (gcc version 3.3.3 20040217 (Gentoo Linux 3.3.3, propolice-3.3-7))

This is an attempt to fix the issue that some disks' sysfs attributes are not ready at the time its KOBJ_ADD event is sent. The symptom is during device hotplug, udev may fail to find certain attributes, such as serial or wwn, of the disk. As a result the /dev/disk/by-id entries are not created. The cause is device_add_disk emits the uevent before returning, and the callers have to create

This is an attempt to fix the issue that some disks' sysfs attributes are not ready at the time its KOBJ_ADD event is sent. The symptom is during device hotplug, udev may fail to find certain attributes, such as serial or wwn, of the disk. As a result the /dev/disk/by-id entries are not created. The cause is device_add_disk emits the uevent before returning, and the callers have to create

...122730c>] sysfs_create_dir+0x9a/0xb5 [ 15.182542] [<ffffffff814ff060>] kobject_add_internal+0x11a/0x20e [ 15.183445] [<ffffffff814ff49c>] kobject_add+0x93/0xa5 [ 15.184741] [<ffffffff814e8029>] blk_mq_register_disk+0x139/0x18a [ 15.185668] [<ffffffff814e116a>] blk_register_queue+0xc4/0x116 [ 15.186535] [<ffffffff814ea7ed>] add_disk+0x340/0x459 [ 15.187444] [<ffffffff815c1c8d>] virtblk_probe+0x4e2/0x5cc [ 15.188947] [<ffffffff8157bcc3>] virtio_dev_probe+0xbc/0xfa [ 15.189799] [<ffffffff815aea3a>] driver_probe_device+0x11a/0x2f2 [ 15.19...

...122730c>] sysfs_create_dir+0x9a/0xb5 [ 15.182542] [<ffffffff814ff060>] kobject_add_internal+0x11a/0x20e [ 15.183445] [<ffffffff814ff49c>] kobject_add+0x93/0xa5 [ 15.184741] [<ffffffff814e8029>] blk_mq_register_disk+0x139/0x18a [ 15.185668] [<ffffffff814e116a>] blk_register_queue+0xc4/0x116 [ 15.186535] [<ffffffff814ea7ed>] add_disk+0x340/0x459 [ 15.187444] [<ffffffff815c1c8d>] virtblk_probe+0x4e2/0x5cc [ 15.188947] [<ffffffff8157bcc3>] virtio_dev_probe+0xbc/0xfa [ 15.189799] [<ffffffff815aea3a>] driver_probe_device+0x11a/0x2f2 [ 15.19...

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk

...(QUEUE_FLAG_STOPPED, &(q)->queue_flags) #define blk_queue_dead(q) test_bit(QUEUE_FLAG_DEAD, &(q)->queue_flags) @@ -657,21 +634,21 @@ extern void rq_flush_dcache_pages(struct request *rq); #else static inline void rq_flush_dcache_pages(struct request *rq) { } #endif extern int blk_register_queue(struct gendisk *disk); extern void blk_unregister_queue(struct gendisk *disk); extern void generic_make_request(struct bio *bio); -extern void blk_rq_init(struct request_queue *q, struct request *rq); +extern void blk_rq_init(struct blk_queue_ctx *ctx, struct request *rq); extern void blk_put_r...

...(QUEUE_FLAG_STOPPED, &(q)->queue_flags) #define blk_queue_dead(q) test_bit(QUEUE_FLAG_DEAD, &(q)->queue_flags) @@ -657,21 +634,21 @@ extern void rq_flush_dcache_pages(struct request *rq); #else static inline void rq_flush_dcache_pages(struct request *rq) { } #endif extern int blk_register_queue(struct gendisk *disk); extern void blk_unregister_queue(struct gendisk *disk); extern void generic_make_request(struct bio *bio); -extern void blk_rq_init(struct request_queue *q, struct request *rq); +extern void blk_rq_init(struct blk_queue_ctx *ctx, struct request *rq); extern void blk_put_r...