search for: bitwriter

Here is the patch that allows to set FLAC__BYTES_PER_WORD to 8. This is disabled by default though. To test FLAC__BYTES_PER_WORD==8: open src/libFLAC/bitreader.c, src/libFLAC/bitwriter.c, src/test_libFLAC/bitwriter.c and change '#if 1' to '#if 0'. The value of FLAC__BYTES_PER_WORD must be the same in src/libFLAC/bitwriter.c and src/test_libFLAC/bitwriter.c. OTOH, their value in src/libFLAC/bitwriter.c and src/libFLAC/bitwriter.c are independent, so sizeof(brword)...

Dagobert Michelsen wrote: > There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following compile errors: > > > CC bitreader.lo > > "bitreader.c", line 494: warning: implicit function declaration: MIN > > CC bitwriter.lo > > "bitwriter.c", line 273: reference to static identifier "bitwriter_grow_" in extern inline function > > "bitwriter.c", line 277: warning: implicit function declaration: MIN > > "bitwriter.c", line 316: reference to static identifier &...

1) The definition of FLAC__BitWriter was updated with the current text from /libFLAC/bitwriter.c (the text in comments was changed). And the definition of TOTAL_BITS was made closer to the code from /libFLAC/bitwriter.c. 2) The values for 'words' and 'bits' values now calculated, not just some magic constants. 3) A...

--- src/libFLAC/bitwriter.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/libFLAC/bitwriter.c b/src/libFLAC/bitwriter.c index 651440d..7da4b15 100644 --- a/src/libFLAC/bitwriter.c +++ b/src/libFLAC/bitwriter.c @@ -43,12 +43,11 @@ /* Things should be fastest wh...

The commit <http://git.xiph.org/?p=flac.git;a=commitdiff;h=e3c8095336249182b6a8871747df3cc99640103a> fixed UB in bitwriter.c. But there are 2 unused functions - FLAC__bitwriter_rice_bits() and FLAC__bitwriter_write_rice_signed() that also have this UB. IMHO it makes sense to fix their code as well. Maybe someone will use them in future. -------------- next part -------------- A non-text attachment was scrubbed... Name:...

Building with MinGW-w64 GCC 5.3.0 via Makefile.lite, I get the following warnings: bitwriter.c: In function 'FLAC__bitwriter_write_utf8_uint64': bitwriter.c:324:19: warning: inlining failed in call to 'FLAC__bitwriter_write_raw_uint32.constprop': --param large-function-growth limit reached [-Winline] inline FLAC__bool FLAC__bitwriter_write_raw_uint32(FLAC__BitWriter *bw, F...

...o some difficulties. I started with the 'LLVM Project Guide', but got hung up in the complexities of configure.ac. I'm now using llvm-config to provide the linker directives, but this results in undefined references: $ llvm-g++ `$HOME/local/bin/llvm-config --cppflags --ldflags --libs bitwriter` ModuleMaker.cpp Yields: /tmp/ccjh9OY1.o: In function `main': ModuleMaker.cpp:(.text+0x13): undefined reference to `llvm::LLVMContext::LLVMContext()' ModuleMaker.cpp:(.text+0x66): undefined reference to `llvm::Module::Module(llvm::StringRef, llvm::LLVMContext&)' ModuleMaker.cpp:(....

There are preprocessor definitions in bitreader.c and bitwriter.c: /* Things should be fastest when this matches the machine word size */ /* WATCHOUT: if you change this you must also change the following #defines down to SWAP_BE_WORD_TO_HOST below to match */ /* WATCHOUT: there are a few places where the code will not work unless uint32_t is &g...

....com>: > Dagobert Michelsen wrote: >> There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following compile errors: >> >>> CC bitreader.lo >>> "bitreader.c", line 494: warning: implicit function declaration: MIN >>> CC bitwriter.lo >>> "bitwriter.c", line 273: reference to static identifier "bitwriter_grow_" in extern inline function >>> "bitwriter.c", line 277: warning: implicit function declaration: MIN >>> "bitwriter.c", line 316: reference to static ide...

...AC__BYTES_PER_WORD == 8 code all together. > > I'll try to do it, but I don't have a deep understanding of bit(read|write) > routines such as FLAC__bitreader_read_rice_signed_block() and other. > Maybe Miroslav Lichvar can say something? Using larger registers in the bitreader/bitwriter should reduce the number of instructions needed when reading/writing the encoded stream as fewer words need to be read/written and encoded values are less likely to be split across two words. In the measurements comparing 32-bit and 64-bit words you posted later, I'm wondering why there is a s...

Erik de Castro Lopo wrote: > The think in and ideal world we would a: > > * Make it work correctly FLAC__BYTES_PER_WORD == 8 and compare the performance > with FLAC__BYTES_PER_WORD == 4. > * If there is an statistically measurable performance, keep it, otherwise > remove the FLAC__BYTES_PER_WORD == 8 code all together. I'll try to do it, but I don't have a deep

...> > Please report back successes and failures (hopefully with patches). There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following compile errors: > CC bitreader.lo > "bitreader.c", line 494: warning: implicit function declaration: MIN > CC bitwriter.lo > "bitwriter.c", line 273: reference to static identifier "bitwriter_grow_" in extern inline function > "bitwriter.c", line 277: warning: implicit function declaration: MIN > "bitwriter.c", line 316: reference to static identifier "bitwriter_...

...working, and I've built ocaml bindings on > top of it. Now with constants and globals variables. Functions and basic blocks next, then on to LLVMBuilder. — Gordon //===-- c-bindings.patch (+730) -------------------------------===// include/llvm/CHelpers.h (+94) include/llvm-c/BitWriter.h (+42) include/llvm-c/Core.h (+221) lib/Bitcode/Writer/BitWriter.cpp (+51) lib/VMCore/Core.cpp (+322) Tedious C bindings for libLLVMCore.a and libLLVMBitWriter.a! - The naming prefix is LLVM. - All types are represented using opaque references. - Functions are not named LLVM{Type}{Metho...

On Sat, Jun 5, 2010 at 3:18 AM, Duncan Sands <baldrick at free.fr> wrote: > Hi Tom, > > I'm pretty sure that the LLVMContext constructor is defined in libLLVMCore.a > What is the output of `llvm-config --libs bitwriter`?  Does it include > -lLLVMCore? Hi Duncan, e0082888 at e0082888-laptop:~$ local/bin/llvm-config --libs bitwriter -lLLVMBitWriter -lLLVMCore -lLLVMSupport -lLLVMSystem I verified it's pulling from the right library directory, because if I hide libLLVMCore.a from view and I get: e0082888...

.../CMakeLists.txt index 90f24ba..fd32a68 100644 --- a/tools/bugpoint/CMakeLists.txt +++ b/tools/bugpoint/CMakeLists.txt @@ -1,4 +1,4 @@ -set(LLVM_LINK_COMPONENTS asmparser instrumentation scalaropts ipo +set(LLVM_LINK_COMPONENTS asmparser instcombine instrumentation scalaropts ipo linker bitreader bitwriter) set(LLVM_REQUIRES_EH 1) diff --git a/tools/llvm-ld/CMakeLists.txt b/tools/llvm-ld/CMakeLists.txt index 2ae4a1d..257d1e9 100644 --- a/tools/llvm-ld/CMakeLists.txt +++ b/tools/llvm-ld/CMakeLists.txt @@ -1,4 +1,4 @@ -set(LLVM_LINK_COMPONENTS ipo scalaropts linker archive bitwriter) +set(LLVM_LINK_...

Fixes typos in comments in these two files. -------------- next part -------------- A non-text attachment was scrubbed... Name: typo.patch Type: application/octet-stream Size: 1602 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140212/f8f231cf/attachment.obj

...sizeof is better here. Also, bitreader.c already uses asserts like "FLAC__ASSERT(parameter <= 31)". 4) Fixed the calculation of mask1 and mask2. The current code is incorrect if FLAC__WORD_ALL_ONES is not 32-bit, so better to replace it with the proper 32-bit constant. 5) In FLAC__bitwriter_write_rice_signed_block() the new variable total_bits was added (just as in FLAC__bitwriter_write_rice_signed()). The code was simplified. Example: - bw->bits = bw->bits + msbits + lsbits; + bw->bits += total_bits; -------------- next part -------------- A non-text attachment was scrub...

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c | 2 +- src/share/utf8/charset.c | 1 + src/test_libFLAC++/encoders.cpp | 8 ++++---- src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ++++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/s...

...stinfo/llvm-commits Begin forwarded message: > From: Gordon Henriksen <gordonhenriksen at mac.com> > Date: October 22, 2008 08:41:55 EDT > To: llvm-commits at cs.uiuc.edu > Subject: [llvm-commits] [llvm] r57976 - in /llvm/trunk/test/Bindings/ > Ocaml: analysis.ml bitreader.ml bitwriter.ml executionengine.ml > scalar_opts.ml target.ml vmcore.ml > Reply-To: Commit Messages and Patches for LLVM <llvm-commits at cs.uiuc.edu > > > > Author: gordon > Date: Wed Oct 22 07:41:54 2008 > New Revision: 57976 > > URL: http://llvm.org/viewvc/llvm-project?rev...

...ed with the 'LLVM Project Guide', but got hung > up in the complexities of configure.ac. I'm now using llvm-config to > provide the linker directives, but this results in undefined > references: > > $ llvm-g++ `$HOME/local/bin/llvm-config --cppflags --ldflags --libs > bitwriter` ModuleMaker.cpp > > Yields: > > /tmp/ccjh9OY1.o: In function `main': > ModuleMaker.cpp:(.text+0x13): undefined reference to > `llvm::LLVMContext::LLVMContext()' > ModuleMaker.cpp:(.text+0x66): undefined reference to > `llvm::Module::Module(llvm::StringRef, llvm::LLV...