Displaying 5 results from an estimated 5 matches for "bittoset".
Did you mean:
bitset
2012 Nov 15
2
[LLVMdev] [llvm-commits] [PATCH] fast-math patches!
...ou should use logical ors here not bitwise.
+ bool any() {
+ return UnsafeAlgebra | NoNaNs | NoInfs | NoSignedZeros |
+ AllowReciprocal;
+ }
Gripe: This pattern is probably super fast and has precedence… but the code is non-obvious:
SubclassOptionalData =
(SubclassOptionalData & ~BitToSet) | (B * BitToSet);
This is likely one iota slower.. but it sure is easier to get the intent.
B ? SubclassOptionalData |= BitToSet :
SubclassOptionalData &= ~BitToSet;
Otherwise looks good to me.
Joe
On Nov 15, 2012, at 5:50 PM, Joe Abbey <joe.abbey at gmail.com> wrote:
> Tr...
2012 Nov 15
0
[LLVMdev] [llvm-commits] [PATCH] fast-math patches!
...l any() {
> + return UnsafeAlgebra | NoNaNs | NoInfs | NoSignedZeros |
> + AllowReciprocal;
> + }
>
Will do.
> Gripe: This pattern is probably super fast and has precedence… but the code is non-obvious:
>
> SubclassOptionalData =
> (SubclassOptionalData & ~BitToSet) | (B * BitToSet);
>
This is an existing pattern that's used elsewhere in the file, so I had assumed it was well understood and preferred.
> This is likely one iota slower.. but it sure is easier to get the intent.
>
> B ? SubclassOptionalData |= BitToSet :
> SubclassOp...
2012 Nov 16
2
[LLVMdev] [llvm-commits] [PATCH] fast-math patches!
...NoNaNs | NoInfs | NoSignedZeros |
>> + AllowReciprocal;
>> + }
>>
>
> Will do.
>
>> Gripe: This pattern is probably super fast and has precedence… but the code is non-obvious:
>>
>> SubclassOptionalData =
>> (SubclassOptionalData & ~BitToSet) | (B * BitToSet);
>>
>
> This is an existing pattern that's used elsewhere in the file, so I had assumed it was well understood and preferred.
>
>> This is likely one iota slower.. but it sure is easier to get the intent.
>>
>> B ? SubclassOptionalData |=...
2012 Nov 15
0
[LLVMdev] [llvm-commits] [PATCH] fast-math patches!
Trying to apply patches..
What's your base revision?
Joe
On Nov 15, 2012, at 5:44 PM, Michael Ilseman <milseman at apple.com> wrote:
> New patches with review feedback incorporated:
> * Changed single letter flags to short abbreviations ('S' ==> 'nsz')
> * Indentation fixes
> * Comments don't state function names
>
>
2012 Nov 15
3
[LLVMdev] [PATCH] fast-math patches!
New patches with review feedback incorporated:
* Changed single letter flags to short abbreviations ('S' ==> 'nsz')
* Indentation fixes
* Comments don't state function names
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fast-math-flags-added-to-FPMathOperator.patch
Type: application/octet-stream
Size: 4937 bytes
Desc: not