Displaying 13 results from an estimated 13 matches for "binderman".
Did you mean:
biederman
2017 Aug 24
2
dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c: 4 * suspicious expression ?
....32/src/doveadm/doveadm-mail-fetch.c:237]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
[dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:261]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Regards
David Binderman
2017 Oct 11
1
dovecot-2.2.33 bug report
Hello there,
dovecot-2.2.33/src/lib/str-find.c:86]: (warning) Calling 'sizeof' on 'sizeof'
Source code is
ctx = p_malloc(pool, MALLOC_ADD(sizeof(struct str_find_context),
MALLOC_MULTIPLY(sizeof(ctx->goodtab[0]), key_len)));
Regards
David Binderman
2010 Jan 19
1
static analysis tool cppcheck meets the btrfs code - four issues
... fs_devices = fs_devices->seed;
}
fs_devices->seed = device->fs_devices->seed;
So presumably fs_devices can never be NULL i.e. the while loop will
always find what it is looking for and so no code to test for NULL is
required.
Regards
David Binderman
_________________________________________________________________
Do you have a story that started on Hotmail? Tell us now
http://clk.atdmt.com/UKM/go/195013117/direct/01/--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to m...
2013 Oct 08
1
nut-2.6.5:rhino.c:190: bad if test ?
...e is
????? if(? ( BattVoltage> 129 ) || ( BattVoltage < 144 ) )
Maybe swap || for && would be better.
This problem I found by using cppcheck. It said
[rhino.c:190]: (warning) Logical disjunction always evaluates to true: BattVoltage> 129 || BattVoltage < 144.
Regards
David Binderman
2013 Jun 28
1
version 2.3.3, file log.c bug report
...n 2.3.3
Amongst many other things, it said
[log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25.
Source code is
??? if (log_id < 0 && log_id>= LOG_MAXLOGS)
??????? return;
Suggest replace && with ||.
Regards
David Binderman
2012 Aug 06
1
[Announce] Samba 3.6.7 Available for Download
...* BUG 8974: Fix kernel oplocks when uid(file) != uid(process).
* BUG 8989: Send correct responses to NT Transact Secondary when no data and
no params for the Trans2 calls are set.
* BUG 9034: Fix typo in set_re_uid() call when USE_SETRESUID selected in
configure.
o David Binderman <dcb314 at hotmail.com>
* BUG 9062: rpcclient: Fix bad call to data_blob_const.
o G?nther Deschner <gd at samba.org>
* BUG 9026: Fix migrating printers while upgrading from 3.5.x.
o David Disseldorp <ddiss at samba.org>
* BUG 8719: Printing fails in function cu...
2012 Aug 06
1
[Announce] Samba 3.6.7 Available for Download
...* BUG 8974: Fix kernel oplocks when uid(file) != uid(process).
* BUG 8989: Send correct responses to NT Transact Secondary when no data and
no params for the Trans2 calls are set.
* BUG 9034: Fix typo in set_re_uid() call when USE_SETRESUID selected in
configure.
o David Binderman <dcb314 at hotmail.com>
* BUG 9062: rpcclient: Fix bad call to data_blob_const.
o G?nther Deschner <gd at samba.org>
* BUG 9026: Fix migrating printers while upgrading from 3.5.x.
o David Disseldorp <ddiss at samba.org>
* BUG 8719: Printing fails in function cu...
2017 May 02
0
drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c:124:: possible unintended fallthrough ?
...004000;
break;
case NV_MEM_ACCESS_WO:
dmaobj->flags0 |= 0x00008000;
case NV_MEM_ACCESS_RW:
dmaobj->flags2 |= 0x00000002;
break;
default:
return -EINVAL;
}
Suggest either document the fallthrough or add the missing break.
Regards
David Binderman
2017 Sep 04
0
linux-4.13/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c:86: possible faulty logic ?
...bios.slow_down_period;
u64 delay;
if (duty > target)
delay = slow_down_period;
else if (duty == target)
delay = min(bump_period, slow_down_period) ;
Last if can never be true, so call to min can never execute. Suggest code rework.
Regards
David Binderman
2019 Aug 05
0
linux-5.3-rc3 bug report
...veau_svm.c:763]: (style) Array index 'i' is used before limits check.
Source code is
for (i = 0; buffer->fault[i] && i < buffer->entries; i++)
Maybe better code:
for (i = 0; (i < buffer->entries) && buffer->fault[i]; i++)
Regards
David Binderman
2013 Apr 30
0
[PATCH] Btrfs: fix typo in send.c
A user reported a bug where we do sizeof(*ptr * count) instead of sizeof(*ptr) *
count. Fix this.
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
fs/btrfs/send.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index ff40f1c..7c8964b 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -4587,8 +...
2012 Sep 17
0
[Announce] Samba 3.6.8 Available for Download
...ke 'smbclient allinfo' show the snapshot list.
o Andrew Bartlett <abartlet at samba.org>
* BUG 9066: "Domain Users" incorrectly added as additional group on domain
members.
* BUG 9067: Use correct RID for "Domain Guests" primary group.
o David Binderman <dcb314 at hotmail.com>
* BUG 9065: Fix bad call to memcpy source3/registry/regfio.c.
o David Disseldorp <ddiss at samba.org>
* BUG 9123: Fix lprng job tracking errors.
o Salvador I. Gonzalez <sgonzalez at codejunkie.net>
* BUG 9088: Fix smbclient/tarmode panic...
2012 Sep 17
0
[Announce] Samba 3.6.8 Available for Download
...ke 'smbclient allinfo' show the snapshot list.
o Andrew Bartlett <abartlet at samba.org>
* BUG 9066: "Domain Users" incorrectly added as additional group on domain
members.
* BUG 9067: Use correct RID for "Domain Guests" primary group.
o David Binderman <dcb314 at hotmail.com>
* BUG 9065: Fix bad call to memcpy source3/registry/regfio.c.
o David Disseldorp <ddiss at samba.org>
* BUG 9123: Fix lprng job tracking errors.
o Salvador I. Gonzalez <sgonzalez at codejunkie.net>
* BUG 9088: Fix smbclient/tarmode panic...