search for: bigbase0

...cut out unecessary CFL queries). Perhaps this is > an irrelevant effect, but we should have some documented rationale. > > > > Yeah, this was a mistake (Chandler had suggested it was right > earlier, but we were both wrong :P) > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > -define i8 @test0(i8* %base, i1 %x) { > +define i8 @test0(i1 %x) { > entry: > + %base = alloca i8, align 4 > %baseplusone = getelementptr i8* %base, i64 1 > br i1 %x, label %red, label %green > red: > @@ -25,8 +26,9 @@ green: > } > > why should this ret...

...but we should have some documented rationale. >> > >> > >> > >> > Yeah, this was a mistake (Chandler had suggested it was right >> > earlier, but we were both wrong :P) >> > >> > >> > >> > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi >> > -define i8 @test0(i8* %base, i1 %x) { >> > +define i8 @test0(i1 %x) { >> > entry: >> > + %base = alloca i8, align 4 >> > %baseplusone = getelementptr i8* %base, i64 1 >> > br i1 %x, label %red, label %green >> > red: >...

...hould have some documented rationale. > > > > > > > > > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > earlier, but we were both wrong :P) > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > -define i8 @test0(i8* %base, i1 %x) { > > > +define i8 @test0(i1 %x) { > > > entry: > > > + %base = alloca i8, align 4 > > > %baseplusone = getelementptr i8* %base, i64 1 > > > br i1 %x, label %red, label %green > > > re...

...t; > > > > > > > > > > > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > > earlier, but we were both wrong :P) > > > > > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > > -define i8 @test0(i8* %base, i1 %x) { > > > > +define i8 @test0(i1 %x) { > > > > entry: > > > > + %base = alloca i8, align 4 > > > > %baseplusone = getelementptr i8* %base, i64 1 > > > > br i1 %x, label %red,...

...> > > > > > > > > > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > > earlier, but we were both wrong :P) > > > > > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > > -define i8 @test0(i8* %base, i1 %x) { > > > > +define i8 @test0(i1 %x) { > > > > entry: > > > > + %base = alloca i8, align 4 > > > > %baseplusone = getelementptr i8* %base, i64 1 > > > > br i1 %x, label...

...d be better (guessing that the metadata queries would be faster than the CFL queries, so if the metadata could quickly return a NoAlias, then we'd cut out unecessary CFL queries). Perhaps this is an irrelevant effect, but we should have some documented rationale. ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi -define i8 @test0(i8* %base, i1 %x) { +define i8 @test0(i1 %x) { entry: + %base = alloca i8, align 4 %baseplusone = getelementptr i8* %base, i64 1 br i1 %x, label %red, label %green red: @@ -25,8 +26,9 @@ green: } why should this return PartialAlias? %ohi does partially overlap...

...gt;>> > > > Yeah, this was a mistake (Chandler had suggested it was right >>> > > > earlier, but we were both wrong :P) >>> > > > >>> > > > >>> > > > >>> > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi >>> > > > -define i8 @test0(i8* %base, i1 %x) { >>> > > > +define i8 @test0(i1 %x) { >>> > > > entry: >>> > > > + %base = alloca i8, align 4 >>> > > > %baseplusone = getelementptr i8* %base, i64...

...> > > > > > > > > > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > > earlier, but we were both wrong :P) > > > > > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > > -define i8 @test0(i8* %base, i1 %x) { > > > > +define i8 @test0(i1 %x) { > > > > entry: > > > > + %base = alloca i8, align 4 > > > > %baseplusone = getelementptr i8* %base, i64 1 > > > > br i1 %x, label...

...t; > > > > > > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > > > earlier, but we were both wrong :P) > > > > > > > > > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > > > -define i8 @test0(i8* %base, i1 %x) { > > > > > +define i8 @test0(i1 %x) { > > > > > entry: > > > > > + %base = alloca i8, align 4 > > > > > %baseplusone = getelementptr i8* %base, i64 1 > > > &g...

...t; > > > > Yeah, this was a mistake (Chandler had suggested it was right > > > > > > earlier, but we were both wrong :P) > > > > > > > > > > > > > > > > > > > > > > > > ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi > > > > > > -define i8 @test0(i8* %base, i1 %x) { > > > > > > +define i8 @test0(i1 %x) { > > > > > > entry: > > > > > > + %base = alloca i8, align 4 > > > > > > %baseplusone = getelementptr i8* %base...

On Thu, Jan 15, 2015 at 1:26 PM, Nick Lewycky <nlewycky at google.com> wrote: > On 15 January 2015 at 13:10, Daniel Berlin <dberlin at dberlin.org> wrote: > >> Yes. >> I've attached an updated patch that does the following: >> >> 1. Fixes the partialalias of globals/arguments >> 2. Enables partialalias for cases where nothing has been unified to

Inline George > On Jan 26, 2015, at 1:05 PM, Daniel Berlin <dberlin at dberlin.org> wrote: > > George, given that, can you just build constexpr handling (it's not as easy as you think) as a separate funciton and have it use it in the right places? Will do. :) > FWIW, my current list of CFLAA issues is: > > 1. Unknown values (results from ptrtoint, incoming

George, given that, can you just build constexpr handling (it's not as easy as you think) as a separate funciton and have it use it in the right places? FWIW, my current list of CFLAA issues is: 1. Unknown values (results from ptrtoint, incoming pointers, etc) are not treated as unknown. These should be done through graph edge (so that they can be one way, otherwise, you will unify

...; When merging MustAlias and PartialAlias, merge to PartialAlias ; instead of MayAlias. target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" -; CHECK: PartialAlias: i16* %bigbase0, i8* %phi -define i8 @test0(i8* %base, i1 %x) { +; FIXME: This could be PartialAlias but CFLAA can't currently prove it +; CHECK: MayAlias: i16* %bigbase0, i8* %phi +define i8 @test0(i1 %x) { entry: + %base = alloca i8, align 1 %baseplusone = getelementptr i8* %base, i64 1 br i1 %x, la...

...must-and-partial.ll +++ b/test/Analysis/CFLAliasAnalysis/must-and-partial.ll @@ -7,8 +7,9 @@ target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" ; CHECK: PartialAlias: i16* %bigbase0, i8* %phi -define i8 @test0(i8* %base, i1 %x) { +define i8 @test0(i1 %x) { entry: + %base = alloca i8, align 4 %baseplusone = getelementptr i8* %base, i64 1 br i1 %x, label %red, label %green red: @@ -25,8 +26,9 @@ green: } ; CHECK: PartialAlias: i16* %bigbase1, i8* %sel -define i8 @t...

Oh, sorry, i didn't rebase it when i changed the fix, you would have had to apply the first on top of the second. Here is one against HEAD On Wed, Jan 14, 2015 at 12:32 PM, Ana Pazos <apazos at codeaurora.org> wrote: > Daniel, your patch does not apply cleanly. Are you on the tip? > > The code I see there is no line if (QueryResult == MayAlias|| QueryResult == PartialAlias)