search for: bhutch

On Thu, 2014-01-16 at 11:07 -0800, Michael Dalton wrote: > On Jan 16, 2014 at 10:57 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > > Why write a loop when you can do: > > i = queue - dev->_rx; > Good point, the loop approach was done in get_netdev_queue_index -- > I agree your fix is faster and simpler. I'll fix in next patchset. It's simpler but we don...

On Thu, 2014-01-16 at 11:07 -0800, Michael Dalton wrote: > On Jan 16, 2014 at 10:57 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > > Why write a loop when you can do: > > i = queue - dev->_rx; > Good point, the loop approach was done in get_netdev_queue_index -- > I agree your fix is faster and simpler. I'll fix in next patchset. It's simpler but we don...

On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > From: Ben Hutchings <bhutchings at solarflare.com> > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > If the consensus is still that we must preserve packets exactly (aside > > from the usual modifications by IP routers) then LRO should be disabled > > on all devices for which forwarding is enabled. >...

On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > From: Ben Hutchings <bhutchings at solarflare.com> > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > If the consensus is still that we must preserve packets exactly (aside > > from the usual modifications by IP routers) then LRO should be disabled > > on all devices for which forwarding is enabled. >...

On Thu, 2014-01-16 at 01:38 -0800, Michael Dalton wrote: [...] > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h [...] > @@ -2401,6 +2416,23 @@ static inline int netif_copy_real_num_queues(struct net_device *to_dev, > #endif > } > > +#ifdef CONFIG_SYSFS > +static inline unsigned int get_netdev_rx_queue_index( > + struct netdev_rx_queue *queue) >

On Thu, 2014-01-16 at 01:38 -0800, Michael Dalton wrote: [...] > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h [...] > @@ -2401,6 +2416,23 @@ static inline int netif_copy_real_num_queues(struct net_device *to_dev, > #endif > } > > +#ifdef CONFIG_SYSFS > +static inline unsigned int get_netdev_rx_queue_index( > + struct netdev_rx_queue *queue) >

On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must preserve packets exactly (aside > > > > from the usual modifications by IP routers) then LRO should be disabled > > > > on...

On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must preserve packets exactly (aside > > > > from the usual modifications by IP routers) then LRO should be disabled > > > > on...

...redhat.com> writes: > > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > >> > > From: Ben Hutchings <bhutchings at solarflare.com> > >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > >> > > > >> > > > If the consensus is still that we must preserve packets exactly (aside > >> > > > from the usual modifications by IP routers) then LRO shoul...

...redhat.com> writes: > > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > >> > > From: Ben Hutchings <bhutchings at solarflare.com> > >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > >> > > > >> > > > If the consensus is still that we must preserve packets exactly (aside > >> > > > from the usual modifications by IP routers) then LRO shoul...

On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > From: Ben Hutchings <bhutchings at solarflare.com> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > If the consensus is still that we must preserve packets exactly (aside > > > from the usual modifications by IP routers) then LRO should be disabled > > > on all devices for which fo...

...in" <mst at redhat.com> writes: > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: >> > > From: Ben Hutchings <bhutchings at solarflare.com> >> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 >> > > >> > > > If the consensus is still that we must preserve packets exactly (aside >> > > > from the usual modifications by IP routers) then LRO should be disabled >&g...

On Mon, Jan 13, 2014 at 7:38 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > I don't think RPS should own this structure. It's just that there are > currently no per-RX-queue attributes other than those defined by RPS. Agreed, there is useful attribute-independent functionality already built around netdev_rx_queue - e.g., d...

On Jan 16, 2014 at 10:57 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > Why write a loop when you can do: > i = queue - dev->_rx; Good point, the loop approach was done in get_netdev_queue_index -- I agree your fix is faster and simpler. I'll fix in next patchset. Thanks! Best, Mike

On Thu, Jan 16, 2014 Ben Hutchings <bhutchings at solarflare.com> wrote: > It's simpler but we don't know if it's faster (and I don't believe that > matters for the current usage). > > If one of these functions starts to be used in the data path, at that > point it could be worth optimising, e.g. by doing a...

On Mon, 2014-01-13 at 11:40 +0200, Michael S. Tsirkin wrote: > On Sun, Jan 12, 2014 at 03:32:28PM -0800, Michael Dalton wrote: [...] > > The last issue is how the rx_queue_attribute 'show' function > > implementation for mergeable_rx_buffer_size will access the appropriate > > per-receive queue EWMA data. The arguments to the show function will be > > the

On Mon, 2014-01-13 at 11:40 +0200, Michael S. Tsirkin wrote: > On Sun, Jan 12, 2014 at 03:32:28PM -0800, Michael Dalton wrote: [...] > > The last issue is how the rx_queue_attribute 'show' function > > implementation for mergeable_rx_buffer_size will access the appropriate > > per-receive queue EWMA data. The arguments to the show function will be > > the

...------------------------------------------------ People who touched revisions under test: Alex Deucher <alexander.deucher@amd.com> Andi Kleen <ak@linux.intel.com> Andrew Morton <akpm@linux-foundation.org> Arnaldo Carvalho de Melo <acme@redhat.com> Ben Hutchings <bhutchings@solarflare.com> Ben Skeggs <bskeggs@redhat.com> Benjamin Tissoires <benjamin.tissoires@gmail.com> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> Daniel Santos <daniel.santos@pobox.com> Daniel Tobias <dan.g.tob@gmail.com> Dave Airlie <airlied@redh...

...gt; >> On Jul 28, 2011, at 8:51 AM, Rose, Gregory V wrote: >> >> >> -----Original Message----- >> From: David Miller [mailto:davem at davemloft.net] >> Sent: Wednesday, July 27, 2011 10:28 PM >> To: Rose, Gregory V >> Cc: netdev at vger.kernel.org; bhutchings at solarflare.com; Kirsher, Jeffrey T >> Subject: Re: [RFC net-next PATCH 3/4] ethtool: Add new set commands >> >> From: Greg Rose <gregory.v.rose at intel.com> >> Date: Wed, 27 Jul 2011 15:17:59 -0700 >> >> Add new set commands to configure the numbe...

...gt; >> On Jul 28, 2011, at 8:51 AM, Rose, Gregory V wrote: >> >> >> -----Original Message----- >> From: David Miller [mailto:davem at davemloft.net] >> Sent: Wednesday, July 27, 2011 10:28 PM >> To: Rose, Gregory V >> Cc: netdev at vger.kernel.org; bhutchings at solarflare.com; Kirsher, Jeffrey T >> Subject: Re: [RFC net-next PATCH 3/4] ethtool: Add new set commands >> >> From: Greg Rose <gregory.v.rose at intel.com> >> Date: Wed, 27 Jul 2011 15:17:59 -0700 >> >> Add new set commands to configure the numbe...