search for: bh_freed

...is JBDDirty instead, to stop if from being written to disc prematurey). One option might be to simply clear the JBDDirty flag at this point. However this causes a number of assertions later on to fail, so it isn't a good idea. The approach that I have taken in the patch is to make use of the BH_Freed flag which is currently unused but is defined in jbd.h as BH_Freed, /* 1 if buffer has been freed (truncated) */ It seems perfect for the job. At this point in journal_unmap_buffer, we set BH_Freed on the buffer. Then in phase 7 of the commit, when we are looking at the t_forget buffers and co...

Hi, I found the following, suspect looking, gem in ext3-2.4-0.9.1-246.gz. Is this supposed to compile or is it just a tyypo ? +enum jbd_state_bits { + BH_JWrite + = BH_PrivateStart, /* 1 if being written to log (@@@ DEBUGGING) */ + BH_Freed, /* 1 if buffer has been freed (truncated) */ Rik -- Virtual memory is like a game you can't win; However, without VM there's truly nothing to lose... http://www.surriel.com/ http://distro.conectiva.com/ Send all your spam to aardvark@nl.linux.org (spam digging piggy)

..._ASSERT (!test_and_set_bit(BH_Alloced, &bh->b_state)) If J_ASSERT is only use as debug, why it will modify data? I found the 'BH_Alloced' flag only occures at two place: one is balloc.c as above, the other is at journal_forget() in fs/jfs/transaction.c: J_ASSERT (!test_and_set_bit(BH_Freed, &bh->b_state)); clear_bit(BH_Alloced, &bh->b_state); here after assert, we clear the bit right away. So the other question is: If one block was new alloced, BH_Alloced was set in it's buffer_header and there is no way to clear it until the buffer was destroyed. Is that right? In...

In 2.4.20-pre5 an optimisation was made to the ext3 fsync function which can very easily cause file data corruption at unmount time. This was first reported by Nick Piggin on November 29th (one day after 2.4.20 was released, and three months after the bug was merged. Unfortunate timing) This only affects filesystems which were mounted with the `data=journal' option. Or files which are

...*/ + #define BH_Temp 8 /* 1 if the buffer is temporary (unlinked) */ + #define BH_JWrite 9 /* 1 if being written to log (@@@ DEBUGGING) */ + #define BH_QuickFree 10 /* 1 if alloced and freed quickly (see below)*/ + #define BH_Alloced 11 /* 1 if buffer has been allocated */ + #define BH_Freed 12 /* 1 if buffer has been freed (truncated) */ + #define BH_Revoked 13 /* 1 if buffer has b ===== redhat latest 2.2.19 /* bh state bits */ #define BH_Uptodate 0 /* 1 if the buffer contains valid data */ #define BH_Dirty 1 /* 1 if the buffer is dirty */ #define BH_Lock 2 /* 1 i...

...ttle on this buffer */ +#define BH_Temp 8 /* 1 if the buffer is temporary (unlinked) */ +#define BH_JWrite 9 /* 1 if being written to log (@@@ DEBUGGING) */ +#define BH_QuickFree 10 /* 1 if alloced and freed quickly (see below)*/ +#define BH_Alloced 11 /* 1 if buffer has been allocated */ +#define BH_Freed 12 /* 1 if buffer has been freed (truncated) */ +#define BH_Revoked 13 /* 1 if buffer has been revoked from the log */ +#define BH_RevokeValid 14 /* 1 if buffer revoked flag is valid */ +#define BH_JDirty 15 /* 1 if buffer is dirty but journaled */ + +/* journaling buffer types */ +#define BJ_None...

...prio */ +#define BH_Temp 9 /* 1 if the buffer is temporary (unlinked) */ +#define BH_JWrite 10 /* 1 if being written to log (@@@ DEBUGGING) */ +#define BH_QuickFree 11 /* 1 if alloced and freed quickly (see below)*/ +#define BH_Alloced 12 /* 1 if buffer has been allocated */ +#define BH_Freed 13 /* 1 if buffer has been freed (truncated) */ +#define BH_Revoked 14 /* 1 if buffer has been revoked from the log */ +#define BH_RevokeValid 15 /* 1 if buffer revoked flag is valid */ +#define BH_JDirty 16 /* 1 if buffer is dirty but journaled */ + +/* journaling buffer types */ +#define B...

...t = 1 EXT3-fs error (device sd(8,49)): ext3_free_blocks: Freeing blocks not in datazone - block = 1291668583, count = 1 EXT3-fs warning (device sd(8,49)): ext3_free_blocks: bit already cleared for block 2213 Assertion failure in journal_forget() at transaction.c line 860: "!test_and_set_bit(BH_Freed, &bh->b_state)" Unable to handle kernel NULL pointer dereference at virtual address 00000000 current->tss.cr3 = 00101000, %cr3 = 00101000 *pde = 00000000 Oops: 0002 CPU: 0EXT3-fs warning (device sd(8,49)): ext3_free_blocks: bit already cleared for block 56037886 EXT3-fs error (de...