Displaying 5 results from an estimated 5 matches for "bf639b5789".
2023 Feb 17
1
[PATCH] python: Avoid leaking py_array along error paths
...tps://listman.redhat.com/archives/libguestfs/2023-February/030730.html
> Fixes: commit 6ef5837e2d8c5d4d83eff51c0201eb2e08f719de
> Thanks: Laszlo Ersek
> ---
> python/handle.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/python/handle.c b/python/handle.c
> index bf639b5789..717eee83ed 100644
> --- a/python/handle.c
> +++ b/python/handle.c
> @@ -136,6 +136,7 @@ guestfs_int_py_event_callback_wrapper (guestfs_h *g,
> buf, buf_len, py_array);
> if (args == NULL) {
> PyErr_PrintEx (0);
> + Py_DECREF (py_array);
>...
2023 Feb 14
2
[PATCH 2/2] python: Use bytes instead of str for event callback buffer
...137: unexpected end of data
Use bytes instead.
Reported-by: Yonatan Shtarkman
See: https://listman.redhat.com/archives/libguestfs/2023-February/030653.html
---
python/handle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/handle.c b/python/handle.c
index f37e939e03..bf639b5789 100644
--- a/python/handle.c
+++ b/python/handle.c
@@ -131,7 +131,7 @@ guestfs_int_py_event_callback_wrapper (guestfs_h *g,
}
/* XXX As with Perl we don't pass the guestfs_h handle here. */
- args = Py_BuildValue ("(Kis#O)",
+ args = Py_BuildValue ("(Kiy#O)",...
2023 Feb 16
1
[PATCH] python: Avoid leaking py_array along error paths
Tested by reverting bbf396fc5562b4f so that the error path is used,
and re-running the reproducer supplied by Google.
Rich.
2023 Feb 17
2
[PATCH v3 0/2] python: Avoid leaking py_array and py_args in event callbacks
Version 1 was here:
https://listman.redhat.com/archives/libguestfs/2023-February/030732.html
(Ignore version 2 which had a mistake, this is version 3)
Following Eric's suggestion here:
https://listman.redhat.com/archives/libguestfs/2023-February/030746.html
let's decrement the reference of py_array right after adding it to the
args. (This works even if args fails to be built).
2023 Feb 14
2
[PATCH 1/2] python: Avoid crash if callback parameters cannot be built
In the case that building the parameters to the Python event callback
fails, args was returned as NULL. We immediately tried to call
Py_INCREF on this which crashed. Returning NULL means the Python
function threw an exception, so print the exception and return (there
is no way to return an error here - the event is lost).
Reported-by: Yonatan Shtarkman
See: