search for: best_kernel

v1: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v2: https://www.redhat.com/archives/libguestfs/2017-April/msg00040.html v3: https://www.redhat.com/archives/libguestfs/2017-April/msg00051.html v3 -> v4: - Properly fix Xen PV-only kernel detection, and test it. Rich.

Yaniv pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1438794 that virt-v2v both doesn't install the virtio-rng driver for Windows, and doesn't give the guest a virtio-rng PCI device either. There are two problems here: Firstly the Windows virtio-rng driver isn't included in the exploded tree (/usr/share/virtio-win) so it doesn't get copied into the guest. The solution

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v1 -> v2: - Add support for -o glance. - Add support for -o qemu. - Fix the -o libvirt support for balloon as pointed out by Dan. - Fix a test failure caused by changing libvirt XML output. Rich.

...bly wrong) fallback if it happens to be unavailable, this now > tries to enable the common virtio kernel modules (just the ones needed > for virtio-blk and virtio-net to work). The fallback is only used if > none of the common virtio modules can be found. > --- > [...] > let best_kernel = > let compare_best_kernels k1 k2 = > - let i = compare k1.ki_supports_virtio k2.ki_supports_virtio in > + let i = compare k1.ki_supports_virtio_net k2.ki_supports_virtio_net in Should this consider both virtio-net+virtio-blk to determine that a kernel "supports...

v1: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v2: https://www.redhat.com/archives/libguestfs/2017-April/msg00040.html v2 -> v3: - Fix Xen PV-only kernel detection. Rich.

...then + Linux.augeas_reload g and unconfigure_xen () = (* Remove kmod-xenpv-* (RHEL 3). *) @@ -733,7 +611,7 @@ let rec convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = let kernels = List.rev kernels (* so best is first *) in List.hd kernels in if best_kernel <> List.hd grub_kernels then - grub_set_bootable best_kernel; + bootloader#set_default_kernel best_kernel.ki_vmlinuz; (* Does the best/bootable kernel support virtio? *) let virtio = best_kernel.ki_supports_virtio in @@ -751,46 +629,6 @@ let rec convert ~keep_serial_cons...

...> > and unconfigure_xen () = > (* Remove kmod-xenpv-* (RHEL 3). *) > @@ -733,7 +611,7 @@ let rec convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = > let kernels = List.rev kernels (* so best is first *) in > List.hd kernels in > if best_kernel <> List.hd grub_kernels then > - grub_set_bootable best_kernel; > + bootloader#set_default_kernel best_kernel.ki_vmlinuz; > > (* Does the best/bootable kernel support virtio? *) > let virtio = best_kernel.ki_supports_virtio in > @@ -751,46 +629,6 @@ let...

...then + Linux.augeas_reload g and unconfigure_xen () = (* Remove kmod-xenpv-* (RHEL 3). *) @@ -740,7 +610,7 @@ let rec convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = let kernels = List.rev kernels (* so best is first *) in List.hd kernels in if best_kernel <> List.hd grub_kernels then - grub_set_bootable best_kernel; + bootloader#set_default_kernel best_kernel.ki_vmlinuz; (* Does the best/bootable kernel support virtio? *) let virtio = best_kernel.ki_supports_virtio in @@ -758,46 +628,6 @@ let rec convert ~keep_serial_cons...

...else compare k2.ki_is_debug k1.ki_is_debug ) in - let kernels = grub_kernels in + let kernels = bootloader_kernels in let kernels = List.filter (fun { ki_is_xen_kernel = is_xen_kernel } -> not is_xen_kernel) kernels in let kernels = List.sort compare_best_kernels kernels in let kernels = List.rev kernels (* so best is first *) in List.hd kernels in - if best_kernel <> List.hd grub_kernels then + if best_kernel <> List.hd bootloader_kernels then bootloader#set_default_kernel best_kernel.ki_vmlinuz; (* Does the b...

This is a sort of follow-up to the Linux_bootloaders patch. It turns out all the kernel detection code is nicely self- contained and can therefore be moved to its own module. Rich.

...VIRTUALIZED GUESTS\", to see what to do.") prog; (* Enable the best non-Xen kernel, where "best" means the one with - * the highest version which supports virtio. + * the highest version, preferring non-debug kernels which support + * virtio. *) let best_kernel = let compare_best_kernels k1 k2 = - let i = compare k1.ki_supports_virtio k2.ki_supports_virtio in + let i = compare k1.ki_supports_virtio_net k2.ki_supports_virtio_net in if i <> 0 then i else ( let i = compare_app2_versions k1.ki_app k2.ki_...

...Not necessary for grub2. *) + if bootloader#set_augeas_configuration () then + Linux.augeas_reload g and autorelabel () = (* Only do autorelabel if load_policy binary exists. Actually @@ -741,44 +618,7 @@ let rec convert ~keep_serial_console (g : G.guestfs) inspect source = best_kernel, virtio and grub_set_bootable kernel = - match grub with - | `Grub1 -> - if not (String.is_prefix kernel.ki_vmlinuz grub_prefix) then - error (f_"kernel %s is not under grub tree %s") - kernel.ki_vmlinuz grub_prefix; - let kernel_under_grub_prefix =...