search for: beginof

On Friday 15 May 2009 05:50, Jay Foad wrote: > > 3. Any comments on the patch itself? > > > > The one major thing to be aware of is that it isn't safe to use &V[0] > > when V is an empty std::vector > > Oh dear. That's a bit of a flaw in the plan. I suppose the solution is > to switch to SmallVector whenever this might be a problem. Or use iterators.

...name T, size_t N> struct range_traits<T[N]> { typedef T value_type; typedef T *iterator; // .. etc ... }; and by (2b) indirecting calls to seq.begin() and seq.end() through template functions: template<typename ConvertibleToRange> typename range_traits<T>::iterator beginof(T &seq) { seq.begin(); } template<typename ConvertibleToRange, size_t N> typename range_traits<T[N]>::iterator beginof(T (&seq)[N]) { return seq; } template<typename ConvertibleToRange> typename range_traits<T>::iterator endof(T &seq) { seq.begin(); } template...

> 3. Any comments on the patch itself? > > The one major thing to be aware of is that it isn't safe to use &V[0] when V > is an empty std::vector Oh dear. That's a bit of a flaw in the plan. I suppose the solution is to switch to SmallVector whenever this might be a problem. I'm a bit concerned that any new &empty[0] problems that are introduced will go unnoticed.