Displaying 3 results from an estimated 3 matches for "becamezero".
2007 Sep 07
0
[LLVMdev] [PATCH]: Add SparseBitmap implementation
...ike the iterator doesn't allow modification of the iterator, as
such you could also typedef "const_iterator".
+ while (ElementIter != RHS.Elements.end())
+ Elements.push_back(new SparseBitVectorElement<ElementSize>(*(*ElementIter)));
line too long.
+ if (BecameZero) {
+ ElementListIter IterTmp = Iter1;
+ delete *IterTmp;
A few tabs are in here before delete, please convert to spaces.
+ iterator begin() {
+ return iterator(*this);
+ }
+
+ iterator end() {
+ return iterator(*this, ~0);
+ }
Can these both be const?
-Chri...
2007 Sep 04
6
[LLVMdev] [PATCH]: Add SparseBitmap implementation
On 9/4/07, Dan Gohman <djg at cray.com> wrote:
> On Tue, Sep 04, 2007 at 10:35:10AM -0400, Daniel Berlin wrote:
> > On 9/4/07, Dan Gohman <djg at cray.com> wrote:
> > > On Fri, Aug 31, 2007 at 08:10:33PM -0400, Daniel Berlin wrote:
> > > > + template <int ElementSize>
> > > > + class SparseBitmap {
> > >
> > > Do you
2007 Sep 07
1
[LLVMdev] [PATCH]: Add SparseBitmap implementation
...the iterator, as
> such you could also typedef "const_iterator".
Done
>
> + while (ElementIter != RHS.Elements.end())
> + Elements.push_back(new SparseBitVectorElement<ElementSize>(*(*ElementIter)));
>
> line too long.
Split.
>
> + if (BecameZero) {
> + ElementListIter IterTmp = Iter1;
> + delete *IterTmp;
>
> A few tabs are in here before delete, please convert to spaces.
M-x whitespace-cleanup done :)
>
>
> + iterator begin() {
> + return iterator(*this);
> + }
> +
> +...