search for: beauz

..._M_IX86 and _M_X64, as Martin said. I sent a patch to this ML that fixed these a few months ago but it was forgotten/ignored. Hopefully the issue gets addressed this time. Cameron On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > > --- >> celt/float_cast.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/celt/float_cast.h b/celt/float_cast.h >> index ede6574..4892e2c 100644 >> --- a/celt/float_cast.h >> +++ b/celt/float_cast.h...

...ach the person managing the list at opus-owner at xiph.org When replying, please edit your Subject line so it is more specific than "Re: Contents of opus digest..." Today's Topics: 1. Re: opus Digest, Vol 70, Issue 1 (Heng Lou) 2. [PATCH] float_cast: Fix MSVC ARM build (Hugo Beauz?e-Luyssen) 3. Re: [PATCH] float_cast: Fix MSVC ARM build (Martin Storsj?) ---------------------------------------------------------------------- Message: 1 Date: Wed, 5 Nov 2014 20:19:04 +0000 From: Heng Lou <Heng_Lou at starkey.com> Subject: Re: [opus] opus Digest, Vol 70, Issue 1 To:...

Hi, The attached patch fixes build on Windows/ARM platform, as it doesn't have inline assembly. Regards, -- Hugo Beauz?e-Luyssen hugo at beauzee.fr -------------- next part -------------- A non-text attachment was scrubbed... Name: fix_msvc_build.patch Type: text/x-patch Size: 489 bytes Desc: not available Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20150227/9acf1cbc/attachment.bin

--- celt/float_cast.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/celt/float_cast.h b/celt/float_cast.h index ede6574..4892e2c 100644 --- a/celt/float_cast.h +++ b/celt/float_cast.h @@ -90,14 +90,14 @@ #include <math.h> #define float2int(x) lrint(x) -#elif (defined(_MSC_VER) && _MSC_VER >= 1400) && (defined (WIN64) || defined (_WIN64))

...p://lists.xiph.org/pipermail/opus/attachments/20140406/e19d33cd/attachment.obj > > Best, > Tristan > > > > > Cameron > > > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/celt/float_cast.h b/celt/float_cast.h > >>> index ede6574..4892e2c 100644...

On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > --- > celt/float_cast.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/celt/float_cast.h b/celt/float_cast.h > index ede6574..4892e2c 100644 > --- a/celt/float_cast.h > +++ b/celt/float_cast.h > @@ -90,14 +90,14 @@ > #in...

...ts addressed this time. This one, I gather? http://lists.xiph.org/pipermail/opus/attachments/20140406/e19d33cd/attachment.obj Best, Tristan > > Cameron > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st> wrote: >> >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: >> >>> --- >>> celt/float_cast.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/celt/float_cast.h b/celt/float_cast.h >>> index ede6574..4892e2c 100644 >>> --- a/celt/float_cast....

...> > Best, > Tristan > > > > > Cameron > > > > On Nov 6, 2014 9:53 AM, "Martin Storsj?" <martin at martin.st > <mailto:martin at martin.st>> wrote: > >> > >> On Thu, 6 Nov 2014, Hugo Beauz?e-Luyssen wrote: > >> > >>> --- > >>> celt/float_cast.h | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/celt/float_cast.h b/celt/float_cast.h > >>> in...

On Thu, 6 Nov 2014, Jean-Marc Valin wrote: > Is there any consensus on what's the correct fix here? Cameron's fix looks correct to me (I didn't read the code closely enough in my first comment). // Martin

...t; // Martin > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus > That looks good to me as well, I'm happy to drop the original patch in favor of this one! Also, thanks for the review! -- Hugo Beauz?e-Luyssen hugo at beauzee.fr +33-7-83-33-84-08 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/opus/attachments/20141110/c0688c18/...