search for: bd4c32ef7

...formats). Instead of using a whitelist for backing formats, just validate that the string is alphanumeric and short. Thanks: Mike Goodwin for reporting the bug. --- lib/create.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/create.c b/lib/create.c index bd4c32ef7..fff5cf332 100644 --- a/lib/create.c +++ b/lib/create.c @@ -241,6 +241,14 @@ is_power_of_2 (unsigned v) return v && ((v & (v - 1)) == 0); } +/** + * Check for valid backing format. Allow any C<^[[:alnum]]+$> + * (in C locale), but limit the length to something reasonable. +...

...com> > --- > lib/create.c | 5 +++-- > lib/guestfs-internal.h | 2 ++ > lib/launch-direct.c | 2 ++ > lib/launch-libvirt.c | 15 +++++++++------ > 4 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/lib/create.c b/lib/create.c > index bd4c32ef7..aedfe8670 100644 > --- a/lib/create.c > +++ b/lib/create.c > @@ -272,7 +272,8 @@ disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size, > */ > if (STRNEQ (backingformat, "raw") && > STRNEQ (backingformat, "qcow2")...

...estfs_h *g, return -1; if (r == 0) { - error (g, _("'%s' is not a file or directory"), remotepath); + error (g, _("‘%s’ is not a file or directory"), remotepath); return -1; } diff --git a/lib/create.c b/lib/create.c index 6f1584ed3..bd4c32ef7 100644 --- a/lib/create.c +++ b/lib/create.c @@ -93,7 +93,7 @@ guestfs_impl_disk_create (guestfs_h *g, const char *filename, * want to make unlimited promises through the API. We can always * add more later. */ - error (g, _("unsupported format '%s'"), format...