Displaying 2 results from an estimated 2 matches for "bc87".
Did you mean:
b87
2024 Jan 22
1
[PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret
On 1/16/24 13:31, Dan Carpenter wrote:
> On Tue, Jan 16, 2024 at 11:16:09AM +0000, Colin Ian King wrote:
>> The variable ret is being assigned a value but it isn't being
>> read afterwards. The assignment is redundant and so ret can be
>> removed.
>>
>> Cleans up clang scan build warning:
>> warning: Although the value stored to 'ret' is used in
2024 Jan 23
1
[PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret
...ublished Smatch checks only complain about:
if (ret)
return ret;
if (failure)
return ret;
I have a different check that I haven't published but I wish that I
could which looks like:
if (!ret)
return ret;
Here is a bug that check found recently.
https://lore.kernel.org/all/9c81251b-bc87-4ca3-bb86-843dc85e5145 at moroto.mountain/
I have a different unpublished check for every time ret is zero and we
do:
return ret;
But I only review those warnings for specific code. Perhaps, I could
make a warning for:
if (failure)
return ret;
I'm sure I tried this in the past and it h...