search for: base64exportname

...ar *value) { if (strcmp (key, "mode") == 0) { if (strcasecmp (value, "exportname") == 0 || @@ -89,15 +89,15 @@ reflection_config (const char *key, const char *value) return 0; } -#define reflection_config_help \ +#define info_config_help \ "mode=exportname|base64exportname|address Plugin mode (default exportname)." /* Provide a way to detect if the base64 feature is supported. */ static void -reflection_dump_plugin (void) +info_dump_plugin (void) { #ifdef HAVE_BASE64 - printf ("reflection_base64=yes\n"); + printf ("info_base64=yes\n"...

v1 was: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00361 v2: - Adds a patch to rename the reflection plugin to the info plugin. - Adds tests. Rich.

--- common/include/test-tvdiff.c | 75 +++++++++++++++++++++++++++++------- common/include/tvdiff.h | 13 ++++++- 2 files changed, 74 insertions(+), 14 deletions(-) diff --git a/common/include/test-tvdiff.c b/common/include/test-tvdiff.c index 9cbcfc0..abefb2e 100644 --- a/common/include/test-tvdiff.c +++ b/common/include/test-tvdiff.c @@ -36,7 +36,6 @@ #include <stdlib.h> #include

...nbdkit-reflection-plugin.pod new file mode 100644 index 0000000..1b260b6 --- /dev/null +++ b/plugins/reflection/nbdkit-reflection-plugin.pod @@ -0,0 +1,104 @@ +=head1 NAME + +nbdkit-reflection-plugin - reflect export name back to the client + +=head1 SYNOPSIS + + nbdkit reflection [mode=]exportname|base64exportname + +=head1 DESCRIPTION + +C<nbdkit-reflection-plugin> is a test plugin which reflects +information sent by the client back to the client. + +In its default mode (C<mode=exportname>) it converts the export name +passed from the client into a disk image. C<mode=base64exportname> is...

...eflection-plugin.pod index f971cef..09deb26 100644 --- a/plugins/reflection/nbdkit-reflection-plugin.pod +++ b/plugins/reflection/nbdkit-reflection-plugin.pod @@ -4,7 +4,8 @@ nbdkit-reflection-plugin - reflect client info back to the client =head1 SYNOPSIS - nbdkit reflection [mode=]exportname|base64exportname|address + nbdkit reflection [mode=]exportname|base64exportname|address| + time|uptime|conntime =head1 DESCRIPTION @@ -22,6 +23,10 @@ than this. C<mode=address> creates a disk which contains the client's IP address and port number as a string. +C<mode=t...

...e <sys/time.h> #include <sys/socket.h> #include <netinet/in.h> #include <arpa/inet.h> @@ -48,14 +49,29 @@ #include <nbdkit-plugin.h> +#include "byte-swapping.h" +#include "tvdiff.h" + /* The mode. */ enum mode { MODE_EXPORTNAME, MODE_BASE64EXPORTNAME, MODE_ADDRESS, + MODE_TIME, + MODE_UPTIME, + MODE_CONNTIME, }; static enum mode mode = MODE_EXPORTNAME; +/* Plugin load time. */ +static struct timeval load_t; + +static void +info_load (void) +{ + gettimeofday (&load_t, NULL); +} + static int info_config (const char *key, const ch...

This series is based on my blog posting here: https://rwmj.wordpress.com/2019/09/13/nbdkit-supports-exportnames/ It depends on the fix for realloc: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00103 This series adds a fun plugin, and also an semi-related feature I've long thought to be desirable. You can consider patches 1 & 4, and patches 2 & 3 as forming

...flection-plugin.pod +++ b/plugins/reflection/nbdkit-reflection-plugin.pod @@ -1,10 +1,10 @@ =head1 NAME -nbdkit-reflection-plugin - reflect export name back to the client +nbdkit-reflection-plugin - reflect client info back to the client =head1 SYNOPSIS - nbdkit reflection [mode=]exportname|base64exportname + nbdkit reflection [mode=]exportname|base64exportname|address =head1 DESCRIPTION @@ -17,6 +17,9 @@ similar except the client must base64-encode the data in the export name, allowing arbitrary binary data to be sent (see L</EXAMPLES> below to make this clearer). +C<mode=address&gt...

...ture > db 0x55,0xaa > --- > +++ b/plugins/reflection/nbdkit-reflection-plugin.pod > @@ -0,0 +1,104 @@ > +=head1 NAME > + > +nbdkit-reflection-plugin - reflect export name back to the client > + > +=head1 SYNOPSIS > + > + nbdkit reflection [mode=]exportname|base64exportname > + > +=head1 DESCRIPTION > + > +C<nbdkit-reflection-plugin> is a test plugin which reflects > +information sent by the client back to the client. > + > +In its default mode (C<mode=exportname>) it converts the export name > +passed from the client into a disk im...

...) { > > + if (strcasecmp (value, "exportname") == 0) { > > Do we want to be nice and allow 'export-name' as an [undocumented] > alternative spelling? OK. > > + mode = MODE_EXPORTNAME; > > + } > > + else if (strcasecmp (value, "base64exportname") == 0) { > > similarly for 'base64-export-name' OK. > > > +#define reflection_config_help \ > > + "mode=MODE Plugin mode." > > + > > Worth listing the valid values of MODE, or the fact that this parameter > is optional because it...

...ot;exportname") == 0 || - strcasecmp (value, "export-name") == 0) { + if (ascii_strcasecmp (value, "exportname") == 0 || + ascii_strcasecmp (value, "export-name") == 0) { mode = MODE_EXPORTNAME; } - else if (strcasecmp (value, "base64exportname") == 0 || - strcasecmp (value, "base64-export-name") == 0) { + else if (ascii_strcasecmp (value, "base64exportname") == 0 || + ascii_strcasecmp (value, "base64-export-name") == 0) { #ifdef HAVE_BASE64 mode = MODE_BASE64EXPORTNAME...

...arse array is reused between consecutive clients, a later client might get different answers than the first client. The null and full plugins are obviously zero. The zero plugin doesn't return any data, so it doesn't need changes. The info plugin is never sparse, but can be all zeroes in base64exportname mode. Adding initial state support to file-based and language binding plugins will be done separately. Testing of this addition relies on a contemporary patch to libnbd adding a new nbd_get_init_flags() function for reading the advertised initial state, then demonstrating changes in state observa...

I will be following up to this email with four separate threads each addressed to the appropriate single list, with proposed changes to: - the NBD protocol - qemu: both server and client - libnbd: client - nbdkit: server The feature in question adds a new optional NBD_INFO_ packet to the NBD_OPT_GO portion of handshake, adding up to 16 bits of information that the server can advertise to the