search for: bagder

Using the libcurl share interface we can share data between the separate curl easy handles in the pool. For more about this see: https://curl.se/libcurl/c/CURLSHOPT_SHARE.html https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b https://everything.curl.dev/libcurl/sharing --- plugins/curl/curldefs.h | 3 +- plugins/curl/curl.c | 4 ++- plugins/curl/pool.c | 75 +++++++++++++++++++++++++++++++++++++++-- 3 files changed, 78 insertions(+), 4 deletions(-) diff --git a/plugins/curl/c...

On 2/22/23 16:01, Richard W.M. Jones wrote: > Using the libcurl share interface we can share data between the > separate curl easy handles in the pool. For more about this see: > > https://curl.se/libcurl/c/CURLSHOPT_SHARE.html > https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b > https://everything.curl.dev/libcurl/sharing > --- > plugins/curl/curldefs.h | 3 +- > plugins/curl/curl.c | 4 ++- > plugins/curl/pool.c | 75 +++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 78 insertions(+), 4 deletions(-...

...s whole curl > facility useless? > > The facility in general looks super weird; what sense does it make *not* > to share some particular CURL_LOCK_DATA_xxx? I can only conclude this cannot be true. Daniel Stenberg wrote this code which definitely uses threads: https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b Also I did a lot of testing and didn't hit any obvious threading bugs. Nevertheless I'm not planning to integrate this patch any time soon. > Laszlo Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read...

I'm mainly posting this to the list as a back-up. It does work, it does _not_ improve performance in any noticable way. However I'm having lots of trouble getting HTTP/2 to work (with or without this patch) and that's stopping me from testing anything properly. Rich.